[PATCH] drm/amdgpu/display: remove unused variable

[PATCH] drm/amdgpu/display: remove unused variable

[Alex Deucher]

No longer used, drop it.

Fixes: 1e07005161fc ("drm/amd/display: add function to convert hw to dpcd lane settings")
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
---
 drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
index 029cc78bc9e9..5eb40dcff315 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
@@ -520,7 +520,6 @@ static void dpcd_set_lt_pattern_and_lane_settings(
 
 	uint8_t dpcd_lt_buffer[5] = {0};
 	union dpcd_training_pattern dpcd_pattern = { {0} };
-	uint32_t lane;
 	uint32_t size_in_bytes;
 	bool edp_workaround = false; /* TODO link_prop.INTERNAL */
 	dpcd_base_lt_offset = DP_TRAINING_PATTERN_SET;
@@ -1020,7 +1019,6 @@ enum dc_status dpcd_set_lane_settings(
 	uint32_t offset)
 {
 	union dpcd_training_lane dpcd_lane[LANE_COUNT_DP_MAX] = {{{0}}};
-	uint32_t lane;
 	unsigned int lane0_set_address;
 	enum dc_status status;
 
-- 
2.31.1

Re: [PATCH] drm/amdgpu/display: remove unused variable

[Alex Deucher]

Ping?

On Mon, Sep 27, 2021 at 3:08 PM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> No longer used, drop it.
>
> Fixes: 1e07005161fc ("drm/amd/display: add function to convert hw to dpcd lane settings")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 029cc78bc9e9..5eb40dcff315 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -520,7 +520,6 @@ static void dpcd_set_lt_pattern_and_lane_settings(
>
>         uint8_t dpcd_lt_buffer[5] = {0};
>         union dpcd_training_pattern dpcd_pattern = { {0} };
> -       uint32_t lane;
>         uint32_t size_in_bytes;
>         bool edp_workaround = false; /* TODO link_prop.INTERNAL */
>         dpcd_base_lt_offset = DP_TRAINING_PATTERN_SET;
> @@ -1020,7 +1019,6 @@ enum dc_status dpcd_set_lane_settings(
>         uint32_t offset)
>  {
>         union dpcd_training_lane dpcd_lane[LANE_COUNT_DP_MAX] = {{{0}}};
> -       uint32_t lane;
>         unsigned int lane0_set_address;
>         enum dc_status status;
>
> --
> 2.31.1
>

RE: [PATCH] drm/amdgpu/display: remove unused variable

[Ma, Hanghong]

[AMD Official Use Only]

Hi Alex,
This looks good to me, and thanks for the clean up.
Reviewed-by: Leo (Hanghong) Ma <hanghong.ma@amd.com>

-Leo
-----Original Message-----
From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> On Behalf Of Alex Deucher
Sent: Wednesday, September 29, 2021 1:47 PM
To: Deucher, Alexander <Alexander.Deucher@amd.com>
Cc: amd-gfx list <amd-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amdgpu/display: remove unused variable

Ping?

On Mon, Sep 27, 2021 at 3:08 PM Alex Deucher <alexander.deucher@amd.com> wrote:
>
> No longer used, drop it.
>
> Fixes: 1e07005161fc ("drm/amd/display: add function to convert hw to 
> dpcd lane settings")
> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c 
> b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> index 029cc78bc9e9..5eb40dcff315 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c
> @@ -520,7 +520,6 @@ static void dpcd_set_lt_pattern_and_lane_settings(
>
>         uint8_t dpcd_lt_buffer[5] = {0};
>         union dpcd_training_pattern dpcd_pattern = { {0} };
> -       uint32_t lane;
>         uint32_t size_in_bytes;
>         bool edp_workaround = false; /* TODO link_prop.INTERNAL */
>         dpcd_base_lt_offset = DP_TRAINING_PATTERN_SET; @@ -1020,7 
> +1019,6 @@ enum dc_status dpcd_set_lane_settings(
>         uint32_t offset)
>  {
>         union dpcd_training_lane dpcd_lane[LANE_COUNT_DP_MAX] = {{{0}}};
> -       uint32_t lane;
>         unsigned int lane0_set_address;
>         enum dc_status status;
>
> --
> 2.31.1
>