* [PATCH] drm/amd/display: add virtual_setup_stream_attribute decl to header
@ 2022-04-18 19:48 ` Tom Rix
0 siblings, 0 replies; 5+ messages in thread
From: Tom Rix @ 2022-04-18 19:48 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, stylon.wang,
Jun.Lei, wenjing.liu
Cc: amd-gfx, dri-devel, linux-kernel, Tom Rix
Smatch reports this issue
virtual_link_hwss.c:32:6: warning: symbol
'virtual_setup_stream_attribute' was not declared.
Should it be static?
virtual_setup_stream_attribute is only used in
virtual_link_hwss.c, but the other functions in the
file are declared in the header file and used elsewhere.
For consistency, add the virtual_setup_stream_attribute
decl to virtual_link_hwss.h.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
index e6bcb4bb0f3a..fbcbc5afb47d 100644
--- a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
+++ b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
@@ -28,6 +28,7 @@
#include "core_types.h"
void virtual_setup_stream_encoder(struct pipe_ctx *pipe_ctx);
+void virtual_setup_stream_attribute(struct pipe_ctx *pipe_ctx);
void virtual_reset_stream_encoder(struct pipe_ctx *pipe_ctx);
const struct link_hwss *get_virtual_link_hwss(void);
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drm/amd/display: add virtual_setup_stream_attribute decl to header
@ 2022-04-18 19:48 ` Tom Rix
0 siblings, 0 replies; 5+ messages in thread
From: Tom Rix @ 2022-04-18 19:48 UTC (permalink / raw)
To: harry.wentland, sunpeng.li, Rodrigo.Siqueira, alexander.deucher,
christian.koenig, Xinhui.Pan, airlied, daniel, stylon.wang,
Jun.Lei, wenjing.liu
Cc: Tom Rix, dri-devel, amd-gfx, linux-kernel
Smatch reports this issue
virtual_link_hwss.c:32:6: warning: symbol
'virtual_setup_stream_attribute' was not declared.
Should it be static?
virtual_setup_stream_attribute is only used in
virtual_link_hwss.c, but the other functions in the
file are declared in the header file and used elsewhere.
For consistency, add the virtual_setup_stream_attribute
decl to virtual_link_hwss.h.
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
index e6bcb4bb0f3a..fbcbc5afb47d 100644
--- a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
+++ b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
@@ -28,6 +28,7 @@
#include "core_types.h"
void virtual_setup_stream_encoder(struct pipe_ctx *pipe_ctx);
+void virtual_setup_stream_attribute(struct pipe_ctx *pipe_ctx);
void virtual_reset_stream_encoder(struct pipe_ctx *pipe_ctx);
const struct link_hwss *get_virtual_link_hwss(void);
--
2.27.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: add virtual_setup_stream_attribute decl to header
2022-04-18 19:48 ` Tom Rix
(?)
@ 2022-04-19 14:50 ` Alex Deucher
-1 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-04-19 14:50 UTC (permalink / raw)
To: Tom Rix
Cc: Wentland, Harry, Leo (Sunpeng) Li, Siqueira, Rodrigo, Deucher,
Alexander, Christian Koenig, xinhui pan, Dave Airlie,
Daniel Vetter, Stylon Wang, Jun Lei, Wenjing Liu,
Maling list - DRI developers, amd-gfx list, LKML
Applied. Thanks!
On Mon, Apr 18, 2022 at 3:48 PM Tom Rix <trix@redhat.com> wrote:
>
> Smatch reports this issue
> virtual_link_hwss.c:32:6: warning: symbol
> 'virtual_setup_stream_attribute' was not declared.
> Should it be static?
>
> virtual_setup_stream_attribute is only used in
> virtual_link_hwss.c, but the other functions in the
> file are declared in the header file and used elsewhere.
> For consistency, add the virtual_setup_stream_attribute
> decl to virtual_link_hwss.h.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> index e6bcb4bb0f3a..fbcbc5afb47d 100644
> --- a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> +++ b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> @@ -28,6 +28,7 @@
> #include "core_types.h"
>
> void virtual_setup_stream_encoder(struct pipe_ctx *pipe_ctx);
> +void virtual_setup_stream_attribute(struct pipe_ctx *pipe_ctx);
> void virtual_reset_stream_encoder(struct pipe_ctx *pipe_ctx);
> const struct link_hwss *get_virtual_link_hwss(void);
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: add virtual_setup_stream_attribute decl to header
@ 2022-04-19 14:50 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-04-19 14:50 UTC (permalink / raw)
To: Tom Rix
Cc: Stylon Wang, Leo (Sunpeng) Li, Wenjing Liu, xinhui pan, Siqueira,
Rodrigo, LKML, Maling list - DRI developers, Dave Airlie,
amd-gfx list, Deucher, Alexander, Jun Lei, Christian Koenig
Applied. Thanks!
On Mon, Apr 18, 2022 at 3:48 PM Tom Rix <trix@redhat.com> wrote:
>
> Smatch reports this issue
> virtual_link_hwss.c:32:6: warning: symbol
> 'virtual_setup_stream_attribute' was not declared.
> Should it be static?
>
> virtual_setup_stream_attribute is only used in
> virtual_link_hwss.c, but the other functions in the
> file are declared in the header file and used elsewhere.
> For consistency, add the virtual_setup_stream_attribute
> decl to virtual_link_hwss.h.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> index e6bcb4bb0f3a..fbcbc5afb47d 100644
> --- a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> +++ b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> @@ -28,6 +28,7 @@
> #include "core_types.h"
>
> void virtual_setup_stream_encoder(struct pipe_ctx *pipe_ctx);
> +void virtual_setup_stream_attribute(struct pipe_ctx *pipe_ctx);
> void virtual_reset_stream_encoder(struct pipe_ctx *pipe_ctx);
> const struct link_hwss *get_virtual_link_hwss(void);
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amd/display: add virtual_setup_stream_attribute decl to header
@ 2022-04-19 14:50 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-04-19 14:50 UTC (permalink / raw)
To: Tom Rix
Cc: Stylon Wang, Leo (Sunpeng) Li, Wenjing Liu, xinhui pan, Siqueira,
Rodrigo, LKML, Maling list - DRI developers, Dave Airlie,
amd-gfx list, Daniel Vetter, Deucher, Alexander, Jun Lei,
Wentland, Harry, Christian Koenig
Applied. Thanks!
On Mon, Apr 18, 2022 at 3:48 PM Tom Rix <trix@redhat.com> wrote:
>
> Smatch reports this issue
> virtual_link_hwss.c:32:6: warning: symbol
> 'virtual_setup_stream_attribute' was not declared.
> Should it be static?
>
> virtual_setup_stream_attribute is only used in
> virtual_link_hwss.c, but the other functions in the
> file are declared in the header file and used elsewhere.
> For consistency, add the virtual_setup_stream_attribute
> decl to virtual_link_hwss.h.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> index e6bcb4bb0f3a..fbcbc5afb47d 100644
> --- a/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> +++ b/drivers/gpu/drm/amd/display/dc/virtual/virtual_link_hwss.h
> @@ -28,6 +28,7 @@
> #include "core_types.h"
>
> void virtual_setup_stream_encoder(struct pipe_ctx *pipe_ctx);
> +void virtual_setup_stream_attribute(struct pipe_ctx *pipe_ctx);
> void virtual_reset_stream_encoder(struct pipe_ctx *pipe_ctx);
> const struct link_hwss *get_virtual_link_hwss(void);
>
> --
> 2.27.0
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-19 14:50 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-18 19:48 [PATCH] drm/amd/display: add virtual_setup_stream_attribute decl to header Tom Rix
2022-04-18 19:48 ` Tom Rix
2022-04-19 14:50 ` Alex Deucher
2022-04-19 14:50 ` Alex Deucher
2022-04-19 14:50 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.