* [PATCH] drm/scheduler: make unexported items static
@ 2019-10-09 12:14 Ben Dooks
2019-10-10 7:54 ` Ben Dooks
2019-10-10 14:18 ` Alex Deucher
0 siblings, 2 replies; 4+ messages in thread
From: Ben Dooks @ 2019-10-09 12:14 UTC (permalink / raw)
To: linux-kernel; +Cc: David Airlie, Ben Dooks, dri-devel
The drm_sched_fence_ops_{scheduled,finished} are not exported
from the file so make them static to avoid the following
warnings from sparse:
drivers/gpu/drm/scheduler/sched_fence.c:131:28: warning: symbol 'drm_sched_fence_ops_scheduled' was not declared. Should it be static?
drivers/gpu/drm/scheduler/sched_fence.c:137:28: warning: symbol 'drm_sched_fence_ops_finished' was not declared. Should it be static?
Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
Cc: David Airlie <airlied@linux.ie>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
---
drivers/gpu/drm/scheduler/sched_fence.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/scheduler/sched_fence.c b/drivers/gpu/drm/scheduler/sched_fence.c
index 54977408f574..8b45c3a1b84e 100644
--- a/drivers/gpu/drm/scheduler/sched_fence.c
+++ b/drivers/gpu/drm/scheduler/sched_fence.c
@@ -128,13 +128,13 @@ static void drm_sched_fence_release_finished(struct dma_fence *f)
dma_fence_put(&fence->scheduled);
}
-const struct dma_fence_ops drm_sched_fence_ops_scheduled = {
+static const struct dma_fence_ops drm_sched_fence_ops_scheduled = {
.get_driver_name = drm_sched_fence_get_driver_name,
.get_timeline_name = drm_sched_fence_get_timeline_name,
.release = drm_sched_fence_release_scheduled,
};
-const struct dma_fence_ops drm_sched_fence_ops_finished = {
+static const struct dma_fence_ops drm_sched_fence_ops_finished = {
.get_driver_name = drm_sched_fence_get_driver_name,
.get_timeline_name = drm_sched_fence_get_timeline_name,
.release = drm_sched_fence_release_finished,
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/scheduler: make unexported items static
2019-10-09 12:14 [PATCH] drm/scheduler: make unexported items static Ben Dooks
@ 2019-10-10 7:54 ` Ben Dooks
2019-10-11 13:07 ` Alex Deucher
2019-10-10 14:18 ` Alex Deucher
1 sibling, 1 reply; 4+ messages in thread
From: Ben Dooks @ 2019-10-10 7:54 UTC (permalink / raw)
To: linux-kernel; +Cc: David Airlie, dri-devel
On 09/10/2019 13:14, Ben Dooks wrote:
> The drm_sched_fence_ops_{scheduled,finished} are not exported
> from the file so make them static to avoid the following
> warnings from sparse:
>
> drivers/gpu/drm/scheduler/sched_fence.c:131:28: warning: symbol 'drm_sched_fence_ops_scheduled' was not declared. Should it be static?
> drivers/gpu/drm/scheduler/sched_fence.c:137:28: warning: symbol 'drm_sched_fence_ops_finished' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
If it is useful I can get these into a public git repo and send
a pull request.
--
Ben Dooks http://www.codethink.co.uk/
Senior Engineer Codethink - Providing Genius
https://www.codethink.co.uk/privacy.html
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/scheduler: make unexported items static
2019-10-10 7:54 ` Ben Dooks
@ 2019-10-11 13:07 ` Alex Deucher
0 siblings, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2019-10-11 13:07 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, David Airlie, Maling list - DRI developers
Already applied. thanks.
Alex
On Fri, Oct 11, 2019 at 2:48 AM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> On 09/10/2019 13:14, Ben Dooks wrote:
> > The drm_sched_fence_ops_{scheduled,finished} are not exported
> > from the file so make them static to avoid the following
> > warnings from sparse:
> >
> > drivers/gpu/drm/scheduler/sched_fence.c:131:28: warning: symbol 'drm_sched_fence_ops_scheduled' was not declared. Should it be static?
> > drivers/gpu/drm/scheduler/sched_fence.c:137:28: warning: symbol 'drm_sched_fence_ops_finished' was not declared. Should it be static?
> >
> > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>
> If it is useful I can get these into a public git repo and send
> a pull request.
>
> --
> Ben Dooks http://www.codethink.co.uk/
> Senior Engineer Codethink - Providing Genius
>
> https://www.codethink.co.uk/privacy.html
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/scheduler: make unexported items static
2019-10-09 12:14 [PATCH] drm/scheduler: make unexported items static Ben Dooks
2019-10-10 7:54 ` Ben Dooks
@ 2019-10-10 14:18 ` Alex Deucher
1 sibling, 0 replies; 4+ messages in thread
From: Alex Deucher @ 2019-10-10 14:18 UTC (permalink / raw)
To: Ben Dooks; +Cc: linux-kernel, David Airlie, Maling list - DRI developers
On Thu, Oct 10, 2019 at 2:55 AM Ben Dooks <ben.dooks@codethink.co.uk> wrote:
>
> The drm_sched_fence_ops_{scheduled,finished} are not exported
> from the file so make them static to avoid the following
> warnings from sparse:
>
> drivers/gpu/drm/scheduler/sched_fence.c:131:28: warning: symbol 'drm_sched_fence_ops_scheduled' was not declared. Should it be static?
> drivers/gpu/drm/scheduler/sched_fence.c:137:28: warning: symbol 'drm_sched_fence_ops_finished' was not declared. Should it be static?
>
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Reviewed and pushed out to drm-misc-next.
Thanks!
Alex
> ---
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: dri-devel@lists.freedesktop.org
> ---
> drivers/gpu/drm/scheduler/sched_fence.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/scheduler/sched_fence.c b/drivers/gpu/drm/scheduler/sched_fence.c
> index 54977408f574..8b45c3a1b84e 100644
> --- a/drivers/gpu/drm/scheduler/sched_fence.c
> +++ b/drivers/gpu/drm/scheduler/sched_fence.c
> @@ -128,13 +128,13 @@ static void drm_sched_fence_release_finished(struct dma_fence *f)
> dma_fence_put(&fence->scheduled);
> }
>
> -const struct dma_fence_ops drm_sched_fence_ops_scheduled = {
> +static const struct dma_fence_ops drm_sched_fence_ops_scheduled = {
> .get_driver_name = drm_sched_fence_get_driver_name,
> .get_timeline_name = drm_sched_fence_get_timeline_name,
> .release = drm_sched_fence_release_scheduled,
> };
>
> -const struct dma_fence_ops drm_sched_fence_ops_finished = {
> +static const struct dma_fence_ops drm_sched_fence_ops_finished = {
> .get_driver_name = drm_sched_fence_get_driver_name,
> .get_timeline_name = drm_sched_fence_get_timeline_name,
> .release = drm_sched_fence_release_finished,
> --
> 2.23.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-11 13:07 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-09 12:14 [PATCH] drm/scheduler: make unexported items static Ben Dooks
2019-10-10 7:54 ` Ben Dooks
2019-10-11 13:07 ` Alex Deucher
2019-10-10 14:18 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.