* [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static
@ 2017-10-11 9:21 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2017-10-11 9:21 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Rex Zhu,
James Zhu, Ken Wang, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function uvd_v6_0_enc_get_destroy_msg is local to the source and
does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
index 60af7310a234..71299c67c517 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
@@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t handle
*
* Close up a stream for HW test or if userspace failed to do so
*/
-int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
- bool direct, struct dma_fence **fence)
+static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
+ uint32_t handle,
+ bool direct, struct dma_fence **fence)
{
const unsigned ib_size_dw = 16;
struct amdgpu_job *job;
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static
@ 2017-10-11 9:21 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2017-10-11 9:21 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Rex Zhu,
James Zhu, Ken Wang, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function uvd_v6_0_enc_get_destroy_msg is local to the source and
does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
index 60af7310a234..71299c67c517 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
@@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t handle
*
* Close up a stream for HW test or if userspace failed to do so
*/
-int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
- bool direct, struct dma_fence **fence)
+static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
+ uint32_t handle,
+ bool direct, struct dma_fence **fence)
{
const unsigned ib_size_dw = 16;
struct amdgpu_job *job;
--
2.14.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static
@ 2017-10-11 9:21 ` Colin King
0 siblings, 0 replies; 9+ messages in thread
From: Colin King @ 2017-10-11 9:21 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Rex Zhu,
James Zhu, Ken Wang, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The function uvd_v6_0_enc_get_destroy_msg is local to the source and
does not need to be in global scope, so make it static.
Cleans up sparse warning:
symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
static?
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
index 60af7310a234..71299c67c517 100644
--- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
@@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t handle
*
* Close up a stream for HW test or if userspace failed to do so
*/
-int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
- bool direct, struct dma_fence **fence)
+static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
+ uint32_t handle,
+ bool direct, struct dma_fence **fence)
{
const unsigned ib_size_dw = 16;
struct amdgpu_job *job;
--
2.14.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static
2017-10-11 9:21 ` Colin King
(?)
@ 2017-10-11 10:41 ` Christian König
-1 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2017-10-11 10:41 UTC (permalink / raw)
To: Colin King, Alex Deucher, Christian König, David Airlie,
Rex Zhu, James Zhu, Ken Wang, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
Am 11.10.2017 um 11:21 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function uvd_v6_0_enc_get_destroy_msg is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
> static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> index 60af7310a234..71299c67c517 100644
> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> @@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t handle
> *
> * Close up a stream for HW test or if userspace failed to do so
> */
> -int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
> - bool direct, struct dma_fence **fence)
> +static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
> + uint32_t handle,
> + bool direct, struct dma_fence **fence)
> {
> const unsigned ib_size_dw = 16;
> struct amdgpu_job *job;
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static
@ 2017-10-11 10:41 ` Christian König
0 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2017-10-11 10:41 UTC (permalink / raw)
To: Colin King, Alex Deucher, Christian König, David Airlie,
Rex Zhu, James Zhu, Ken Wang, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
Am 11.10.2017 um 11:21 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function uvd_v6_0_enc_get_destroy_msg is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
> static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> index 60af7310a234..71299c67c517 100644
> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> @@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t handle
> *
> * Close up a stream for HW test or if userspace failed to do so
> */
> -int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
> - bool direct, struct dma_fence **fence)
> +static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
> + uint32_t handle,
> + bool direct, struct dma_fence **fence)
> {
> const unsigned ib_size_dw = 16;
> struct amdgpu_job *job;
--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static
@ 2017-10-11 10:41 ` Christian König
0 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2017-10-11 10:41 UTC (permalink / raw)
To: Colin King, Alex Deucher, Christian König, David Airlie,
Rex Zhu, James Zhu, Ken Wang, amd-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
Am 11.10.2017 um 11:21 schrieb Colin King:
> From: Colin Ian King <colin.king@canonical.com>
>
> The function uvd_v6_0_enc_get_destroy_msg is local to the source and
> does not need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
> static?
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> index 60af7310a234..71299c67c517 100644
> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
> @@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct amdgpu_ring *ring, uint32_t handle
> *
> * Close up a stream for HW test or if userspace failed to do so
> */
> -int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t handle,
> - bool direct, struct dma_fence **fence)
> +static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
> + uint32_t handle,
> + bool direct, struct dma_fence **fence)
> {
> const unsigned ib_size_dw = 16;
> struct amdgpu_job *job;
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static
@ 2017-10-11 16:28 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2017-10-11 16:28 UTC (permalink / raw)
To: Christian Koenig
Cc: Colin King, Alex Deucher, David Airlie, Rex Zhu, James Zhu,
Ken Wang, amd-gfx list, Maling list - DRI developers,
kernel-janitors, LKML
On Wed, Oct 11, 2017 at 6:41 AM, Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
> Am 11.10.2017 um 11:21 schrieb Colin King:
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The function uvd_v6_0_enc_get_destroy_msg is local to the source and
>> does not need to be in global scope, so make it static.
>>
>> Cleans up sparse warning:
>> symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
>> static?
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
Applied. thanks!
Alex
>> ---
>> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> index 60af7310a234..71299c67c517 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> @@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct
>> amdgpu_ring *ring, uint32_t handle
>> *
>> * Close up a stream for HW test or if userspace failed to do so
>> */
>> -int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t
>> handle,
>> - bool direct, struct dma_fence **fence)
>> +static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
>> + uint32_t handle,
>> + bool direct, struct dma_fence
>> **fence)
>> {
>> const unsigned ib_size_dw = 16;
>> struct amdgpu_job *job;
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static
@ 2017-10-11 16:28 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2017-10-11 16:28 UTC (permalink / raw)
To: Christian Koenig
Cc: David Airlie, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, LKML,
amd-gfx list, Maling list - DRI developers, Ken Wang,
Alex Deucher, Colin King, James Zhu, Rex Zhu
On Wed, Oct 11, 2017 at 6:41 AM, Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
> Am 11.10.2017 um 11:21 schrieb Colin King:
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The function uvd_v6_0_enc_get_destroy_msg is local to the source and
>> does not need to be in global scope, so make it static.
>>
>> Cleans up sparse warning:
>> symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
>> static?
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
Applied. thanks!
Alex
>> ---
>> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> index 60af7310a234..71299c67c517 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> @@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct
>> amdgpu_ring *ring, uint32_t handle
>> *
>> * Close up a stream for HW test or if userspace failed to do so
>> */
>> -int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t
>> handle,
>> - bool direct, struct dma_fence **fence)
>> +static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
>> + uint32_t handle,
>> + bool direct, struct dma_fence
>> **fence)
>> {
>> const unsigned ib_size_dw = 16;
>> struct amdgpu_job *job;
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static
@ 2017-10-11 16:28 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2017-10-11 16:28 UTC (permalink / raw)
To: Christian Koenig
Cc: David Airlie, kernel-janitors-u79uwXL29TY76Z2rM5mHXA, LKML,
amd-gfx list, Maling list - DRI developers, Ken Wang,
Alex Deucher, Colin King, James Zhu, Rex Zhu
On Wed, Oct 11, 2017 at 6:41 AM, Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
> Am 11.10.2017 um 11:21 schrieb Colin King:
>>
>> From: Colin Ian King <colin.king@canonical.com>
>>
>> The function uvd_v6_0_enc_get_destroy_msg is local to the source and
>> does not need to be in global scope, so make it static.
>>
>> Cleans up sparse warning:
>> symbol 'uvd_v6_0_enc_get_destroy_msg' was not declared. Should it be
>> static?
>>
>> Signed-off-by: Colin Ian King <colin.king@canonical.com>
>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
Applied. thanks!
Alex
>> ---
>> drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> index 60af7310a234..71299c67c517 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/uvd_v6_0.c
>> @@ -268,8 +268,9 @@ static int uvd_v6_0_enc_get_create_msg(struct
>> amdgpu_ring *ring, uint32_t handle
>> *
>> * Close up a stream for HW test or if userspace failed to do so
>> */
>> -int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring, uint32_t
>> handle,
>> - bool direct, struct dma_fence **fence)
>> +static int uvd_v6_0_enc_get_destroy_msg(struct amdgpu_ring *ring,
>> + uint32_t handle,
>> + bool direct, struct dma_fence
>> **fence)
>> {
>> const unsigned ib_size_dw = 16;
>> struct amdgpu_job *job;
>
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-10-11 16:28 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-11 9:21 [PATCH][drm-next] drm/amdgpu: make function uvd_v6_0_enc_get_destroy_msg static Colin King
2017-10-11 9:21 ` Colin King
2017-10-11 9:21 ` Colin King
2017-10-11 10:41 ` Christian König
2017-10-11 10:41 ` Christian König
2017-10-11 10:41 ` Christian König
2017-10-11 16:28 ` Alex Deucher
2017-10-11 16:28 ` Alex Deucher
2017-10-11 16:28 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.