[PATCH] dma-buf: fix kerneldoc for renamed members

[PATCH] dma-buf: fix kerneldoc for renamed members

[Christian König]

Those members where renamed, update the kerneldoc as well.

Signed-off-by: Christian König <christian.koenig@amd.com>
---
 include/linux/dma-buf.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
index 02c2eb874da6..9807aef33685 100644
--- a/include/linux/dma-buf.h
+++ b/include/linux/dma-buf.h
@@ -433,8 +433,8 @@ struct dma_buf {
 	/** @poll: for userspace poll support */
 	wait_queue_head_t poll;
 
-	/** @cb_excl: for userspace poll support */
-	/** @cb_shared: for userspace poll support */
+	/** @cb_in: for userspace poll support */
+	/** @cb_out: for userspace poll support */
 	struct dma_buf_poll_cb_t {
 		struct dma_fence_cb cb;
 		wait_queue_head_t *poll;
-- 
2.25.1

Re: [PATCH] dma-buf: fix kerneldoc for renamed members

[Alex Deucher]

On Thu, Oct 21, 2021 at 10:19 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Those members where renamed, update the kerneldoc as well.
>
> Signed-off-by: Christian König <christian.koenig@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  include/linux/dma-buf.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
> index 02c2eb874da6..9807aef33685 100644
> --- a/include/linux/dma-buf.h
> +++ b/include/linux/dma-buf.h
> @@ -433,8 +433,8 @@ struct dma_buf {
>         /** @poll: for userspace poll support */
>         wait_queue_head_t poll;
>
> -       /** @cb_excl: for userspace poll support */
> -       /** @cb_shared: for userspace poll support */
> +       /** @cb_in: for userspace poll support */
> +       /** @cb_out: for userspace poll support */
>         struct dma_buf_poll_cb_t {
>                 struct dma_fence_cb cb;
>                 wait_queue_head_t *poll;
> --
> 2.25.1
>

Re: [PATCH] dma-buf: fix kerneldoc for renamed members

[Sumit Semwal]

[-- Attachment #1: Type: text/plain, Size: 1490 bytes --]

Hi Christian,

On Thu, 21 Oct 2021 at 19:55, Alex Deucher <alexdeucher@gmail.com> wrote:

> On Thu, Oct 21, 2021 at 10:19 AM Christian König
> <ckoenig.leichtzumerken@gmail.com> wrote:
> >
> > Those members where renamed, update the kerneldoc as well.
> >
> > Signed-off-by: Christian König <christian.koenig@amd.com>
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
LGTM, but perhaps you want to send it from your amd.com account?
Acked-by: Sumit Semwal <sumit.semwal@linaro.org>

>
> > ---
> >  include/linux/dma-buf.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
> > index 02c2eb874da6..9807aef33685 100644
> > --- a/include/linux/dma-buf.h
> > +++ b/include/linux/dma-buf.h
> > @@ -433,8 +433,8 @@ struct dma_buf {
> >         /** @poll: for userspace poll support */
> >         wait_queue_head_t poll;
> >
> > -       /** @cb_excl: for userspace poll support */
> > -       /** @cb_shared: for userspace poll support */
> > +       /** @cb_in: for userspace poll support */
> > +       /** @cb_out: for userspace poll support */
> >         struct dma_buf_poll_cb_t {
> >                 struct dma_fence_cb cb;
> >                 wait_queue_head_t *poll;
> > --
> > 2.25.1
> >
>

Best,
Sumit.

-- 
Thanks and regards,

Sumit Semwal (he / him)
Tech Lead - LCG, Vertical Technologies
Linaro.org │ Open source software for ARM SoCs

[-- Attachment #2: Type: text/html, Size: 2539 bytes --]

Re: [PATCH] dma-buf: fix kerneldoc for renamed members

[Christian König]

[-- Attachment #1: Type: text/plain, Size: 2015 bytes --]

Am 21.10.21 um 18:24 schrieb Sumit Semwal:
> Hi Christian,
>
> On Thu, 21 Oct 2021 at 19:55, Alex Deucher <alexdeucher@gmail.com 
> <mailto:alexdeucher@gmail.com>> wrote:
>
>     On Thu, Oct 21, 2021 at 10:19 AM Christian König
>     <ckoenig.leichtzumerken@gmail.com
>     <mailto:ckoenig.leichtzumerken@gmail.com>> wrote:
>     >
>     > Those members where renamed, update the kerneldoc as well.
>     >
>     > Signed-off-by: Christian König <christian.koenig@amd.com
>     <mailto:christian.koenig@amd.com>>
>
>     Reviewed-by: Alex Deucher <alexander.deucher@amd.com
>     <mailto:alexander.deucher@amd.com>>
>
> LGTM, but perhaps you want to send it from your amd.com 
> <http://amd.com> account?

Always using my gmail account instead because the AMD servers are only 
accessible through VPN.

> Acked-by: Sumit Semwal <sumit.semwal@linaro.org 
> <mailto:sumit.semwal@linaro.org>>

Thanks,
Christian.

>
>     > ---
>     >  include/linux/dma-buf.h | 4 ++--
>     >  1 file changed, 2 insertions(+), 2 deletions(-)
>     >
>     > diff --git a/include/linux/dma-buf.h b/include/linux/dma-buf.h
>     > index 02c2eb874da6..9807aef33685 100644
>     > --- a/include/linux/dma-buf.h
>     > +++ b/include/linux/dma-buf.h
>     > @@ -433,8 +433,8 @@ struct dma_buf {
>     >         /** @poll: for userspace poll support */
>     >         wait_queue_head_t poll;
>     >
>     > -       /** @cb_excl: for userspace poll support */
>     > -       /** @cb_shared: for userspace poll support */
>     > +       /** @cb_in: for userspace poll support */
>     > +       /** @cb_out: for userspace poll support */
>     >         struct dma_buf_poll_cb_t {
>     >                 struct dma_fence_cb cb;
>     >                 wait_queue_head_t *poll;
>     > --
>     > 2.25.1
>     >
>
>
> Best,
> Sumit.
>
> -- 
> Thanks and regards,
>
> Sumit Semwal (he / him)
> Tech Lead - LCG, Vertical Technologies
> Linaro.org │ Open source software for ARM SoCs


[-- Attachment #2: Type: text/html, Size: 4528 bytes --]