All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/radeon: insist on 32-bit DMA for Cedar
@ 2018-02-21 23:41 Ben Crocker
       [not found] ` <20180221234154.6877-1-bcrocker-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
  2018-02-22 21:57 ` [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE Ben Crocker
  0 siblings, 2 replies; 16+ messages in thread
From: Ben Crocker @ 2018-02-21 23:41 UTC (permalink / raw)
  To: dri-devel, amd-gfx; +Cc: Ben Crocker

In radeon_device_init, set the need_dma32 flag for Cedar chips
(e.g. FirePro 2270).  This fixes, or at least works around, a bug
on PowerPC exposed by last year's commits

8e3f1b1d8255105f31556aacf8aeb6071b00d469 (Russell Currey)

and

253fd51e2f533552ae35a0c661705da6c4842c1b (Alistair Popple)

which enabled the 64-bit DMA iommu bypass.

This caused the device to freeze, in some cases unrecoverably, and is
the subject of several bug reports internal to Red Hat.

Signed-off-by: Ben Crocker <bcrocker@redhat.com>
---
 drivers/gpu/drm/radeon/radeon_device.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/radeon/radeon_device.c b/drivers/gpu/drm/radeon/radeon_device.c
index ffc10cadcf34..02538903830d 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -1395,7 +1395,10 @@ int radeon_device_init(struct radeon_device *rdev,
 	if (rdev->flags & RADEON_IS_AGP)
 		rdev->need_dma32 = true;
 	if ((rdev->flags & RADEON_IS_PCI) &&
-	    (rdev->family <= CHIP_RS740))
+	    (rdev->family <= CHIP_RS740 || rdev->family == CHIP_CEDAR))
+		rdev->need_dma32 = true;
+	if ((rdev->flags & RADEON_IS_PCIE) &&
+	    (rdev->family == CHIP_CEDAR))
 		rdev->need_dma32 = true;
 
 	dma_bits = rdev->need_dma32 ? 32 : 40;
-- 
2.13.6

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 16+ messages in thread

end of thread, other threads:[~2018-02-23 16:37 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-21 23:41 [PATCH] drm/radeon: insist on 32-bit DMA for Cedar Ben Crocker
     [not found] ` <20180221234154.6877-1-bcrocker-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-02-22  2:05   ` Alex Deucher
     [not found]     ` <CADnq5_M8ZiV2b+LW5oKu0XSQOJvg9idvZ6eBOaHMJRPC2iMj3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-22  7:25       ` Christian König
     [not found]         ` <7d6a06dc-9e88-2427-ec6a-4f48b9aa8f6b-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2018-02-22 15:55           ` Ben Crocker
     [not found]             ` <CALk+eRcPH+g-eBMKWyO4FrPwuc_VLnp_w89WYKNE51=iV5Y=wg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-22 16:07               ` Alex Deucher
2018-02-22 16:45                 ` Ben Crocker
2018-02-22 16:48                   ` Alex Deucher
2018-02-22 21:57 ` [PATCH] drm/radeon: insist on 32-bit DMA for Cedar on PPC64/PPC64LE Ben Crocker
2018-02-22 17:04   ` Michel Dänzer
2018-02-22 17:37     ` Ben Crocker
     [not found]       ` <CALk+eRew=1nHZXRtXR430eFStOiQFUDgrp8VfsBAfcp8W9qAOA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-22 17:56         ` Michel Dänzer
     [not found]           ` <CALk+eRc+EOry_G6Ovy0Z-pvE7jQWy5gSx+1kpHA4q3A0oEZs1w@mail.gmail.com>
     [not found]             ` <CALk+eRc+EOry_G6Ovy0Z-pvE7jQWy5gSx+1kpHA4q3A0oEZs1w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-22 23:39               ` Ben Crocker
     [not found]                 ` <CALk+eReghDHuv23-62pD0PbdBt6p+g_XeE+_c2gRdkoaOQh+CQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2018-02-23  1:39                   ` Ben Crocker
     [not found]           ` <1bcf5b27-aa25-deb6-85e9-161dd038276b-otUistvHUpPR7s880joybQ@public.gmane.org>
2018-02-23  7:45             ` Christian König
2018-02-23 16:02               ` Ben Crocker
2018-02-23 16:37                 ` Christian König

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.