All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Deucher <alexdeucher@gmail.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: "open list:EFIFB FRAMEBUFFER DRIVER"
	<linux-fbdev@vger.kernel.org>,
	kexec@lists.infradead.org,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	kernel@gpiccoli.net, kasong@redhat.com,
	"Baoquan He" <bhe@redhat.com>,
	"Samuel Iglesias Gonsálvez" <siglesias@igalia.com>,
	"xinhui pan" <Xinhui.Pan@amd.com>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	pjones@redhat.com, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	"Dave Young" <dyoung@redhat.com>,
	"Christian Koenig" <christian.koenig@amd.com>,
	"Vivek Goyal" <vgoyal@redhat.com>
Subject: Re: Reuse framebuffer after a kexec (amdgpu / efifb)
Date: Thu, 9 Dec 2021 13:06:31 -0500	[thread overview]
Message-ID: <CADnq5_N9ptK4c86LO77YcrF5_M==hket+L7eYjsGCaKbORO=ug@mail.gmail.com> (raw)
In-Reply-To: <a1f4d263-b3d2-4ceb-8a89-948c8129500f@igalia.com>

On Thu, Dec 9, 2021 at 1:00 PM Guilherme G. Piccoli <gpiccoli@igalia.com> wrote:
>
> On 09/12/2021 14:31, Alex Deucher wrote:
> > [...]
> > Once the driver takes over, none of the pre-driver state is retained.
> > You'll need to load the driver in the new kernel to initialize the
> > displays.  Note the efifb doesn't actually have the ability to program
> > any hardware, it just takes over the memory region that was used for
> > the pre-OS framebuffer and whatever display timing was set up by the
> > GOP driver prior to the OS loading.  Once that OS driver has loaded
> > the area is gone and the display configuration may have changed.
> >
>
> Hi Christian and Alex, thanks for the clarifications!
>
> Is there any way to save/retain this state before amdgpu takes over?

Not really in a generic way.  It's asic and platform specific.  In
addition most modern displays require link training to bring up the
display, so you can't just save and restore registers.

> Would simpledrm be able to program the device again, to a working state?

No.  You need an asic specific driver that knows how to program the
specific hardware.  It's also platform specific in that you need to
determine platform specific details such as the number and type of
display connectors and encoders that are present on the system.

>
> Finally, do you have any example of such a GOP driver (open source) so I
> can take a look? I tried to find something like that in Tianocore
> project, but didn't find anything that seemed useful for my issue.

The drivers are asic and platform specific.  E.g., the driver for
vangogh is different from renoir is different from skylake, etc.  The
display programming interfaces are asic specific.

Alex

WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: "open list:EFIFB FRAMEBUFFER DRIVER"
	<linux-fbdev@vger.kernel.org>, "xinhui pan" <Xinhui.Pan@amd.com>,
	kasong@redhat.com, "Baoquan He" <bhe@redhat.com>,
	"Samuel Iglesias Gonsálvez" <siglesias@igalia.com>,
	kernel@gpiccoli.net, kexec@lists.infradead.org,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	pjones@redhat.com,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	"Dave Young" <dyoung@redhat.com>,
	"Christian Koenig" <christian.koenig@amd.com>,
	"Vivek Goyal" <vgoyal@redhat.com>,
	"Gerd Hoffmann" <kraxel@redhat.com>
Subject: Re: Reuse framebuffer after a kexec (amdgpu / efifb)
Date: Thu, 9 Dec 2021 13:06:31 -0500	[thread overview]
Message-ID: <CADnq5_N9ptK4c86LO77YcrF5_M==hket+L7eYjsGCaKbORO=ug@mail.gmail.com> (raw)
In-Reply-To: <a1f4d263-b3d2-4ceb-8a89-948c8129500f@igalia.com>

On Thu, Dec 9, 2021 at 1:00 PM Guilherme G. Piccoli <gpiccoli@igalia.com> wrote:
>
> On 09/12/2021 14:31, Alex Deucher wrote:
> > [...]
> > Once the driver takes over, none of the pre-driver state is retained.
> > You'll need to load the driver in the new kernel to initialize the
> > displays.  Note the efifb doesn't actually have the ability to program
> > any hardware, it just takes over the memory region that was used for
> > the pre-OS framebuffer and whatever display timing was set up by the
> > GOP driver prior to the OS loading.  Once that OS driver has loaded
> > the area is gone and the display configuration may have changed.
> >
>
> Hi Christian and Alex, thanks for the clarifications!
>
> Is there any way to save/retain this state before amdgpu takes over?

Not really in a generic way.  It's asic and platform specific.  In
addition most modern displays require link training to bring up the
display, so you can't just save and restore registers.

> Would simpledrm be able to program the device again, to a working state?

No.  You need an asic specific driver that knows how to program the
specific hardware.  It's also platform specific in that you need to
determine platform specific details such as the number and type of
display connectors and encoders that are present on the system.

>
> Finally, do you have any example of such a GOP driver (open source) so I
> can take a look? I tried to find something like that in Tianocore
> project, but didn't find anything that seemed useful for my issue.

The drivers are asic and platform specific.  E.g., the driver for
vangogh is different from renoir is different from skylake, etc.  The
display programming interfaces are asic specific.

Alex

WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: "Guilherme G. Piccoli" <gpiccoli@igalia.com>
Cc: "open list:EFIFB FRAMEBUFFER DRIVER"
	<linux-fbdev@vger.kernel.org>,
	kexec@lists.infradead.org,
	"amd-gfx list" <amd-gfx@lists.freedesktop.org>,
	kernel@gpiccoli.net, kasong@redhat.com,
	"Baoquan He" <bhe@redhat.com>,
	"Samuel Iglesias Gonsálvez" <siglesias@igalia.com>,
	"xinhui pan" <Xinhui.Pan@amd.com>,
	"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
	pjones@redhat.com, "Gerd Hoffmann" <kraxel@redhat.com>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	"Dave Young" <dyoung@redhat.com>,
	"Christian Koenig" <christian.koenig@amd.com>,
	"Vivek Goyal" <vgoyal@redhat.com>
Subject: Re: Reuse framebuffer after a kexec (amdgpu / efifb)
Date: Thu, 9 Dec 2021 13:06:31 -0500	[thread overview]
Message-ID: <CADnq5_N9ptK4c86LO77YcrF5_M==hket+L7eYjsGCaKbORO=ug@mail.gmail.com> (raw)
In-Reply-To: <a1f4d263-b3d2-4ceb-8a89-948c8129500f@igalia.com>

On Thu, Dec 9, 2021 at 1:00 PM Guilherme G. Piccoli <gpiccoli@igalia.com> wrote:
>
> On 09/12/2021 14:31, Alex Deucher wrote:
> > [...]
> > Once the driver takes over, none of the pre-driver state is retained.
> > You'll need to load the driver in the new kernel to initialize the
> > displays.  Note the efifb doesn't actually have the ability to program
> > any hardware, it just takes over the memory region that was used for
> > the pre-OS framebuffer and whatever display timing was set up by the
> > GOP driver prior to the OS loading.  Once that OS driver has loaded
> > the area is gone and the display configuration may have changed.
> >
>
> Hi Christian and Alex, thanks for the clarifications!
>
> Is there any way to save/retain this state before amdgpu takes over?

Not really in a generic way.  It's asic and platform specific.  In
addition most modern displays require link training to bring up the
display, so you can't just save and restore registers.

> Would simpledrm be able to program the device again, to a working state?

No.  You need an asic specific driver that knows how to program the
specific hardware.  It's also platform specific in that you need to
determine platform specific details such as the number and type of
display connectors and encoders that are present on the system.

>
> Finally, do you have any example of such a GOP driver (open source) so I
> can take a look? I tried to find something like that in Tianocore
> project, but didn't find anything that seemed useful for my issue.

The drivers are asic and platform specific.  E.g., the driver for
vangogh is different from renoir is different from skylake, etc.  The
display programming interfaces are asic specific.

Alex

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2021-12-09 18:06 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-09 16:00 Reuse framebuffer after a kexec (amdgpu / efifb) Guilherme G. Piccoli
2021-12-09 16:00 ` Guilherme G. Piccoli
2021-12-09 16:00 ` Guilherme G. Piccoli
2021-12-09 16:09 ` Christian König
2021-12-09 16:09   ` Christian König
2021-12-09 16:09   ` Christian König
2021-12-09 17:31 ` Alex Deucher
2021-12-09 17:31   ` Alex Deucher
2021-12-09 17:31   ` Alex Deucher
2021-12-09 17:59   ` Guilherme G. Piccoli
2021-12-09 17:59     ` Guilherme G. Piccoli
2021-12-09 17:59     ` Guilherme G. Piccoli
2021-12-09 18:06     ` Alex Deucher [this message]
2021-12-09 18:06       ` Alex Deucher
2021-12-09 18:06       ` Alex Deucher
2021-12-09 18:17       ` Guilherme G. Piccoli
2021-12-09 18:17         ` Guilherme G. Piccoli
2021-12-09 18:17         ` Guilherme G. Piccoli
2021-12-09 19:20         ` Alex Deucher
2021-12-09 19:20           ` Alex Deucher
2021-12-09 19:20           ` Alex Deucher
2021-12-10  7:19         ` Gerd Hoffmann
2021-12-10  7:19           ` Gerd Hoffmann
2021-12-10  7:19           ` Gerd Hoffmann
2021-12-10  7:19           ` Gerd Hoffmann
2021-12-10  8:24         ` Thomas Zimmermann
2021-12-10  8:24           ` Thomas Zimmermann
2021-12-10 14:08           ` Guilherme G. Piccoli
2021-12-10 14:08             ` Guilherme G. Piccoli
2021-12-10 14:08             ` Guilherme G. Piccoli
2021-12-10 14:16             ` Alex Deucher
2021-12-10 14:16               ` Alex Deucher
2021-12-10 14:16               ` Alex Deucher
2021-12-10 14:25               ` Guilherme G. Piccoli
2021-12-10 14:25                 ` Guilherme G. Piccoli
2021-12-10 14:25                 ` Guilherme G. Piccoli
2021-12-10 15:13                 ` Christian König
2021-12-10 15:13                   ` Christian König
2021-12-10 15:13                   ` Christian König
2021-12-10 15:24                   ` Guilherme G. Piccoli
2021-12-10 15:24                     ` Guilherme G. Piccoli
2021-12-10 15:24                     ` Guilherme G. Piccoli
2021-12-10 15:32                     ` Christian König
2021-12-10 15:32                       ` Christian König
2021-12-10 15:32                       ` Christian König
2021-12-10 19:11                     ` Alex Deucher
2021-12-10 19:11                       ` Alex Deucher
2021-12-10 19:11                       ` Alex Deucher
2021-12-11  0:54                   ` Felix Kuehling
2021-12-11  0:54                     ` Felix Kuehling
2021-12-11  0:54                     ` Felix Kuehling
2021-12-11  9:20                     ` Gerd Hoffmann
2021-12-11  9:20                       ` Gerd Hoffmann
2021-12-11  9:20                       ` Gerd Hoffmann
2021-12-11  9:20                       ` Gerd Hoffmann
2021-12-10 19:05                 ` Alex Deucher
2021-12-10 19:05                   ` Alex Deucher
2021-12-10 19:05                   ` Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CADnq5_N9ptK4c86LO77YcrF5_M==hket+L7eYjsGCaKbORO=ug@mail.gmail.com' \
    --to=alexdeucher@gmail.com \
    --cc=Xinhui.Pan@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=bhe@redhat.com \
    --cc=christian.koenig@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=dyoung@redhat.com \
    --cc=gpiccoli@igalia.com \
    --cc=kasong@redhat.com \
    --cc=kernel@gpiccoli.net \
    --cc=kexec@lists.infradead.org \
    --cc=kraxel@redhat.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=pjones@redhat.com \
    --cc=siglesias@igalia.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.