Re: [PATCH 03/10] drm/amdgpu: add missing function prototype for amdgpu_ras_mca_query_error_status

From: Alex Deucher <alexdeucher@gmail.com>
To: Isabella Basso <isabbasso@riseup.net>
Cc: "Kuehling, Felix" <Felix.Kuehling@amd.com>,
	"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	~lkcamp/patches@lists.sr.ht, Daniel Vetter <daniel@ffwll.ch>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	"Wentland, Harry" <harry.wentland@amd.com>,
	Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH 03/10] drm/amdgpu: add missing function prototype for amdgpu_ras_mca_query_error_status
Date: Wed, 8 Dec 2021 14:42:23 -0500	[thread overview]
Message-ID: <CADnq5_N=ArmDXnRKc1GiK-VLS82_Ku_AFxX+5yBGUU3hWAknFg@mail.gmail.com> (raw)
In-Reply-To: <20211208012529.372478-4-isabbasso@riseup.net>

On Tue, Dec 7, 2021 at 10:17 PM Isabella Basso <isabbasso@riseup.net> wrote:
>
> This commit fixes the compile-time warning below:
>
>  warning: no previous prototype for ‘amdgpu_ras_mca_query_error_status’
>  [-Wmissing-prototypes]

I think this function can just be made static.  It's not used outside
of amdgpu_ras.c.

Alex

>
> Signed-off-by: Isabella Basso <isabbasso@riseup.net>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> index 1c708122d492..34e651f39bd1 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.h
> @@ -620,6 +620,10 @@ int amdgpu_ras_sysfs_remove(struct amdgpu_device *adev,
>
>  void amdgpu_ras_debugfs_create_all(struct amdgpu_device *adev);
>
> +void amdgpu_ras_mca_query_error_status(struct amdgpu_device *adev,
> +                                      struct ras_common_if *ras_block,
> +                                      struct ras_err_data  *err_data);
> +
>  int amdgpu_ras_query_error_status(struct amdgpu_device *adev,
>                 struct ras_query_if *info);
>
> --
> 2.34.1
>