Re: [PATCH 01/10] drm/amd: Mark IP_BASE definition as __maybe_unused

From: Alex Deucher <alexdeucher@gmail.com>
To: isabbasso@riseup.net
Cc: "Kuehling, Felix" <Felix.Kuehling@amd.com>,
	"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
	amd-gfx list <amd-gfx@lists.freedesktop.org>,
	~lkcamp/patches@lists.sr.ht, Daniel Vetter <daniel@ffwll.ch>,
	"Deucher, Alexander" <alexander.deucher@amd.com>,
	"Wentland, Harry" <harry.wentland@amd.com>,
	Christian Koenig <christian.koenig@amd.com>
Subject: Re: [PATCH 01/10] drm/amd: Mark IP_BASE definition as __maybe_unused
Date: Wed, 8 Dec 2021 14:37:15 -0500	[thread overview]
Message-ID: <CADnq5_P+yvpSBVt1WeMSR8qXTN5eUTD1HQ6EDy8G-ZVSppdXPw@mail.gmail.com> (raw)
In-Reply-To: <20211208012529.372478-2-isabbasso@riseup.net>

On Tue, Dec 7, 2021 at 10:17 PM Isabella Basso <isabbasso@riseup.net> wrote:
>
> Silences 166 compile-time warnings like:
>
>  warning: 'UVD0_BASE' defined but not used [-Wunused-const-variable=]
>  129 | static const struct IP_BASE UVD0_BASE ={ { { { 0x00007800, 0x00007E00, 0, 0, 0 } },
>      |                             ^~~~~~~~~
>  warning: 'UMC0_BASE' defined but not used [-Wunused-const-variable=]
>  123 | static const struct IP_BASE UMC0_BASE ={ { { { 0x00014000, 0, 0, 0, 0 } },
>      |                             ^~~~~~~~~
>
> Signed-off-by: Isabella Basso <isabbasso@riseup.net>

Applied.  Thanks.

Alex

> ---
>  drivers/gpu/drm/amd/include/cyan_skillfish_ip_offset.h | 10 +++++-----
>  drivers/gpu/drm/amd/include/yellow_carp_offset.h       |  4 ++--
>  2 files changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/include/cyan_skillfish_ip_offset.h b/drivers/gpu/drm/amd/include/cyan_skillfish_ip_offset.h
> index 9cb5f3631c60..ce79e5de8ce3 100644
> --- a/drivers/gpu/drm/amd/include/cyan_skillfish_ip_offset.h
> +++ b/drivers/gpu/drm/amd/include/cyan_skillfish_ip_offset.h
> @@ -25,15 +25,15 @@
>  #define MAX_SEGMENT                                        5
>
>
> -struct IP_BASE_INSTANCE
> +struct IP_BASE_INSTANCE
>  {
>      unsigned int segment[MAX_SEGMENT];
> -};
> -
> -struct IP_BASE
> +} __maybe_unused;
> +
> +struct IP_BASE
>  {
>      struct IP_BASE_INSTANCE instance[MAX_INSTANCE];
> -};
> +} __maybe_unused;
>
>
>  static const struct IP_BASE ATHUB_BASE            ={ { { { 0x00000C00, 0, 0, 0, 0 } },
> diff --git a/drivers/gpu/drm/amd/include/yellow_carp_offset.h b/drivers/gpu/drm/amd/include/yellow_carp_offset.h
> index 76b9eb3f441d..28a56b56bcaf 100644
> --- a/drivers/gpu/drm/amd/include/yellow_carp_offset.h
> +++ b/drivers/gpu/drm/amd/include/yellow_carp_offset.h
> @@ -9,12 +9,12 @@
>  struct IP_BASE_INSTANCE
>  {
>      unsigned int segment[MAX_SEGMENT];
> -};
> +} __maybe_unused;
>
>  struct IP_BASE
>  {
>      struct IP_BASE_INSTANCE instance[MAX_INSTANCE];
> -};
> +} __maybe_unused;
>
>
>  static const struct IP_BASE ACP_BASE = { { { { 0x02403800, 0x00480000, 0, 0, 0, 0 } },
> --
> 2.34.1
>