From: Alex Deucher <alexdeucher@gmail.com>
To: Huang Rui <ray.huang@amd.com>
Cc: Souptick Joarder <jrdr.linux@gmail.com>,
"Su, Jinzhou (Joe)" <Jinzhou.Su@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"Lazar, Lijo" <Lijo.Lazar@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Hou, Xiaomeng (Matthew)" <Xiaomeng.Hou@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Quan, Evan" <Evan.Quan@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static
Date: Tue, 12 Jan 2021 21:13:02 -0500 [thread overview]
Message-ID: <CADnq5_NUaqHWW7A32M1BeQ+rHPS8WZ-0OnVXtD3m7pB3ZpHyYA@mail.gmail.com> (raw)
In-Reply-To: <20210113011901.GA135176@hr-amd>
On Tue, Jan 12, 2021 at 8:19 PM Huang Rui <ray.huang@amd.com> wrote:
>
> On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote:
> > kernel test robot throws below warnings ->
> >
> > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
> > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled'
> > [-Wmissing-prototypes]
> > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
> > warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled'
> > [-Wmissing-prototypes]
> >
> > Mark vangogh_clk_dpm_is_enabled() as static.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > ---
> > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> > index 75ddcad..3ffe56e 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> > @@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu,
> > return 0;
> > }
> >
> > -bool vangogh_clk_dpm_is_enabled(struct smu_context *smu,
> > +static bool vangogh_clk_dpm_is_enabled(struct smu_context *smu,
> > enum smu_clk_type clk_type)
>
> Ah, I have another patch which will use this function in another file.
>
I can drop it if you plan to land those patches soon.
Alex
> Thanks,
> Ray
>
> > {
> > enum smu_feature_mask feature_id = 0;
> > --
> > 1.9.1
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Huang Rui <ray.huang@amd.com>
Cc: "Su, Jinzhou \(Joe\)" <Jinzhou.Su@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Lazar, Lijo" <Lijo.Lazar@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Hou, Xiaomeng \(Matthew\)" <Xiaomeng.Hou@amd.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Quan, Evan" <Evan.Quan@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static
Date: Tue, 12 Jan 2021 21:13:02 -0500 [thread overview]
Message-ID: <CADnq5_NUaqHWW7A32M1BeQ+rHPS8WZ-0OnVXtD3m7pB3ZpHyYA@mail.gmail.com> (raw)
In-Reply-To: <20210113011901.GA135176@hr-amd>
On Tue, Jan 12, 2021 at 8:19 PM Huang Rui <ray.huang@amd.com> wrote:
>
> On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote:
> > kernel test robot throws below warnings ->
> >
> > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
> > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled'
> > [-Wmissing-prototypes]
> > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
> > warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled'
> > [-Wmissing-prototypes]
> >
> > Mark vangogh_clk_dpm_is_enabled() as static.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > ---
> > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> > index 75ddcad..3ffe56e 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> > @@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu,
> > return 0;
> > }
> >
> > -bool vangogh_clk_dpm_is_enabled(struct smu_context *smu,
> > +static bool vangogh_clk_dpm_is_enabled(struct smu_context *smu,
> > enum smu_clk_type clk_type)
>
> Ah, I have another patch which will use this function in another file.
>
I can drop it if you plan to land those patches soon.
Alex
> Thanks,
> Ray
>
> > {
> > enum smu_feature_mask feature_id = 0;
> > --
> > 1.9.1
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Huang Rui <ray.huang@amd.com>
Cc: "Su, Jinzhou \(Joe\)" <Jinzhou.Su@amd.com>,
"Du, Xiaojian" <Xiaojian.Du@amd.com>,
"airlied@linux.ie" <airlied@linux.ie>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"Lazar, Lijo" <Lijo.Lazar@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"Hou, Xiaomeng \(Matthew\)" <Xiaomeng.Hou@amd.com>,
Souptick Joarder <jrdr.linux@gmail.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"Deucher, Alexander" <Alexander.Deucher@amd.com>,
"Quan, Evan" <Evan.Quan@amd.com>,
"Koenig, Christian" <Christian.Koenig@amd.com>
Subject: Re: [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static
Date: Tue, 12 Jan 2021 21:13:02 -0500 [thread overview]
Message-ID: <CADnq5_NUaqHWW7A32M1BeQ+rHPS8WZ-0OnVXtD3m7pB3ZpHyYA@mail.gmail.com> (raw)
In-Reply-To: <20210113011901.GA135176@hr-amd>
On Tue, Jan 12, 2021 at 8:19 PM Huang Rui <ray.huang@amd.com> wrote:
>
> On Wed, Jan 13, 2021 at 03:57:22AM +0800, Souptick Joarder wrote:
> > kernel test robot throws below warnings ->
> >
> > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
> > warning: no previous prototype for 'vangogh_clk_dpm_is_enabled'
> > [-Wmissing-prototypes]
> > drivers/gpu/drm/amd/amdgpu/../pm/swsmu/smu11/vangogh_ppt.c:594:6:
> > warning: no previous prototype for function 'vangogh_clk_dpm_is_enabled'
> > [-Wmissing-prototypes]
> >
> > Mark vangogh_clk_dpm_is_enabled() as static.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com>
> > ---
> > drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> > index 75ddcad..3ffe56e 100644
> > --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> > +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> > @@ -610,7 +610,7 @@ static int vangogh_get_profiling_clk_mask(struct smu_context *smu,
> > return 0;
> > }
> >
> > -bool vangogh_clk_dpm_is_enabled(struct smu_context *smu,
> > +static bool vangogh_clk_dpm_is_enabled(struct smu_context *smu,
> > enum smu_clk_type clk_type)
>
> Ah, I have another patch which will use this function in another file.
>
I can drop it if you plan to land those patches soon.
Alex
> Thanks,
> Ray
>
> > {
> > enum smu_feature_mask feature_id = 0;
> > --
> > 1.9.1
> >
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2021-01-13 2:14 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 19:57 [PATCH] drm: amdgpu: pm: Mark vangogh_clk_dpm_is_enabled() as static Souptick Joarder
2021-01-12 19:57 ` Souptick Joarder
2021-01-12 19:57 ` Souptick Joarder
2021-01-12 21:55 ` Alex Deucher
2021-01-12 21:55 ` Alex Deucher
2021-01-12 21:55 ` Alex Deucher
2021-01-13 1:19 ` Huang Rui
2021-01-13 1:19 ` Huang Rui
2021-01-13 1:19 ` Huang Rui
2021-01-13 2:13 ` Alex Deucher [this message]
2021-01-13 2:13 ` Alex Deucher
2021-01-13 2:13 ` Alex Deucher
2021-01-13 2:21 ` Huang Rui
2021-01-13 2:21 ` Huang Rui
2021-01-13 2:21 ` Huang Rui
2021-01-13 2:30 ` Huang Rui
2021-01-13 2:30 ` Huang Rui
2021-01-13 2:30 ` Huang Rui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_NUaqHWW7A32M1BeQ+rHPS8WZ-0OnVXtD3m7pB3ZpHyYA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Alexander.Deucher@amd.com \
--cc=Christian.Koenig@amd.com \
--cc=Evan.Quan@amd.com \
--cc=Jinzhou.Su@amd.com \
--cc=Lijo.Lazar@amd.com \
--cc=Xiaojian.Du@amd.com \
--cc=Xiaomeng.Hou@amd.com \
--cc=airlied@linux.ie \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jrdr.linux@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ray.huang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.