* [PATCH] drm/amdgpu: avoid undefined return value
@ 2021-05-10 9:56 Leslie Shi
2021-05-10 12:57 ` Chen, Guchun
2021-05-10 20:20 ` Alex Deucher
0 siblings, 2 replies; 3+ messages in thread
From: Leslie Shi @ 2021-05-10 9:56 UTC (permalink / raw)
To: amd-gfx, alexander.deucher, guchun.chen
Fixes: a7c22df2fd07 ("drm/amdgpu: clean up non-DC suspend/resume handling")
Signed-off-by: Leslie Shi <Yuliang.Shi@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index 7d4af8fc7e97..f3b2762f6f53 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -1554,7 +1554,7 @@ int amdgpu_display_suspend_helper(struct amdgpu_device *adev)
struct drm_crtc *crtc;
struct drm_connector *connector;
struct drm_connector_list_iter iter;
- int r;
+ int r = 0;
/* turn off display hw */
drm_modeset_lock_all(dev);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [PATCH] drm/amdgpu: avoid undefined return value
2021-05-10 9:56 [PATCH] drm/amdgpu: avoid undefined return value Leslie Shi
@ 2021-05-10 12:57 ` Chen, Guchun
2021-05-10 20:20 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Chen, Guchun @ 2021-05-10 12:57 UTC (permalink / raw)
To: Shi, Leslie, amd-gfx, Deucher, Alexander
[AMD Public Use]
Reviewed-by: Guchun Chen <guchun.chen@amd.com>
Regards,
Guchun
-----Original Message-----
From: Shi, Leslie <Yuliang.Shi@amd.com>
Sent: Monday, May 10, 2021 5:56 PM
To: amd-gfx@lists.freedesktop.org; Deucher, Alexander <Alexander.Deucher@amd.com>; Chen, Guchun <Guchun.Chen@amd.com>
Subject: [PATCH] drm/amdgpu: avoid undefined return value
Fixes: a7c22df2fd07 ("drm/amdgpu: clean up non-DC suspend/resume handling")
Signed-off-by: Leslie Shi <Yuliang.Shi@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
index 7d4af8fc7e97..f3b2762f6f53 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
@@ -1554,7 +1554,7 @@ int amdgpu_display_suspend_helper(struct amdgpu_device *adev)
struct drm_crtc *crtc;
struct drm_connector *connector;
struct drm_connector_list_iter iter;
- int r;
+ int r = 0;
/* turn off display hw */
drm_modeset_lock_all(dev);
--
2.25.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/amdgpu: avoid undefined return value
2021-05-10 9:56 [PATCH] drm/amdgpu: avoid undefined return value Leslie Shi
2021-05-10 12:57 ` Chen, Guchun
@ 2021-05-10 20:20 ` Alex Deucher
1 sibling, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2021-05-10 20:20 UTC (permalink / raw)
To: Leslie Shi; +Cc: Deucher, Alexander, Chen, Guchun, amd-gfx list
On Mon, May 10, 2021 at 5:56 AM Leslie Shi <Yuliang.Shi@amd.com> wrote:
>
> Fixes: a7c22df2fd07 ("drm/amdgpu: clean up non-DC suspend/resume handling")
>
> Signed-off-by: Leslie Shi <Yuliang.Shi@amd.com>
I think this was already fixed in:
commit e64a779ad509391dcdb3d0d4014d81e6db2ac001
Author: Victor Zhao <Victor.Zhao@amd.com>
Date: Tue Apr 27 17:52:56 2021 +0800
drm/amdgpu: fix r initial values
Sriov gets suspend of IP block <dce_virtual> failed as return
value was not initialized.
v2: return 0 directly to align original code semantic before this
was broken out into a separate helper function instead of setting
initial values
Signed-off-by: Victor Zhao <Victor.Zhao@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> index 7d4af8fc7e97..f3b2762f6f53 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_display.c
> @@ -1554,7 +1554,7 @@ int amdgpu_display_suspend_helper(struct amdgpu_device *adev)
> struct drm_crtc *crtc;
> struct drm_connector *connector;
> struct drm_connector_list_iter iter;
> - int r;
> + int r = 0;
>
> /* turn off display hw */
> drm_modeset_lock_all(dev);
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-05-10 20:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-10 9:56 [PATCH] drm/amdgpu: avoid undefined return value Leslie Shi
2021-05-10 12:57 ` Chen, Guchun
2021-05-10 20:20 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.