All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] amdkfd: Remove DRM_AMDGPU dependency from Kconfig
@ 2014-11-21 20:40 ` Oded Gabbay
  0 siblings, 0 replies; 6+ messages in thread
From: Oded Gabbay @ 2014-11-21 20:40 UTC (permalink / raw)
  To: dri-devel
  Cc: bp, pebolle, linux-kernel, airlied, alexander.deucher, j.glisse,
	John.Bridgman

Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
---
 drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
index e13c67c..8dfac37 100644
--- a/drivers/gpu/drm/amd/amdkfd/Kconfig
+++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
@@ -4,6 +4,6 @@
 
 config HSA_AMD
 	tristate "HSA kernel driver for AMD GPU devices"
-	depends on (DRM_RADEON || DRM_AMDGPU) && AMD_IOMMU_V2 && X86_64
+	depends on DRM_RADEON && AMD_IOMMU_V2 && X86_64
 	help
 	  Enable this if you want to use HSA features on AMD GPU devices.
-- 
2.1.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH] amdkfd: Remove DRM_AMDGPU dependency from Kconfig
@ 2014-11-21 20:40 ` Oded Gabbay
  0 siblings, 0 replies; 6+ messages in thread
From: Oded Gabbay @ 2014-11-21 20:40 UTC (permalink / raw)
  To: dri-devel; +Cc: pebolle, linux-kernel, bp, alexander.deucher

Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>
---
 drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
index e13c67c..8dfac37 100644
--- a/drivers/gpu/drm/amd/amdkfd/Kconfig
+++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
@@ -4,6 +4,6 @@
 
 config HSA_AMD
 	tristate "HSA kernel driver for AMD GPU devices"
-	depends on (DRM_RADEON || DRM_AMDGPU) && AMD_IOMMU_V2 && X86_64
+	depends on DRM_RADEON && AMD_IOMMU_V2 && X86_64
 	help
 	  Enable this if you want to use HSA features on AMD GPU devices.
-- 
2.1.0

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] amdkfd: Remove DRM_AMDGPU dependency from Kconfig
  2014-11-21 20:40 ` Oded Gabbay
@ 2014-11-21 20:47   ` Thierry Reding
  -1 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2014-11-21 20:47 UTC (permalink / raw)
  To: Oded Gabbay; +Cc: dri-devel, pebolle, linux-kernel, bp, alexander.deucher

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

On Fri, Nov 21, 2014 at 10:40:17PM +0200, Oded Gabbay wrote:
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>

You should provide a rationale for this change in the commit message.

Thierry

[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] amdkfd: Remove DRM_AMDGPU dependency from Kconfig
@ 2014-11-21 20:47   ` Thierry Reding
  0 siblings, 0 replies; 6+ messages in thread
From: Thierry Reding @ 2014-11-21 20:47 UTC (permalink / raw)
  To: Oded Gabbay; +Cc: alexander.deucher, pebolle, bp, linux-kernel, dri-devel


[-- Attachment #1.1: Type: text/plain, Size: 192 bytes --]

On Fri, Nov 21, 2014 at 10:40:17PM +0200, Oded Gabbay wrote:
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>

You should provide a rationale for this change in the commit message.

Thierry

[-- Attachment #1.2: Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] amdkfd: Remove DRM_AMDGPU dependency from Kconfig
  2014-11-21 20:40 ` Oded Gabbay
@ 2014-11-21 20:47   ` Alex Deucher
  -1 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2014-11-21 20:47 UTC (permalink / raw)
  To: Oded Gabbay
  Cc: Maling list - DRI developers, Paul Bolle, LKML, Borislav Petkov,
	Deucher, Alexander

On Fri, Nov 21, 2014 at 3:40 PM, Oded Gabbay <oded.gabbay@amd.com> wrote:
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index e13c67c..8dfac37 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -4,6 +4,6 @@
>
>  config HSA_AMD
>         tristate "HSA kernel driver for AMD GPU devices"
> -       depends on (DRM_RADEON || DRM_AMDGPU) && AMD_IOMMU_V2 && X86_64
> +       depends on DRM_RADEON && AMD_IOMMU_V2 && X86_64
>         help
>           Enable this if you want to use HSA features on AMD GPU devices.
> --
> 2.1.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] amdkfd: Remove DRM_AMDGPU dependency from Kconfig
@ 2014-11-21 20:47   ` Alex Deucher
  0 siblings, 0 replies; 6+ messages in thread
From: Alex Deucher @ 2014-11-21 20:47 UTC (permalink / raw)
  To: Oded Gabbay
  Cc: Deucher, Alexander, Paul Bolle, Borislav Petkov, LKML,
	Maling list - DRI developers

On Fri, Nov 21, 2014 at 3:40 PM, Oded Gabbay <oded.gabbay@amd.com> wrote:
> Signed-off-by: Oded Gabbay <oded.gabbay@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/amdkfd/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/Kconfig b/drivers/gpu/drm/amd/amdkfd/Kconfig
> index e13c67c..8dfac37 100644
> --- a/drivers/gpu/drm/amd/amdkfd/Kconfig
> +++ b/drivers/gpu/drm/amd/amdkfd/Kconfig
> @@ -4,6 +4,6 @@
>
>  config HSA_AMD
>         tristate "HSA kernel driver for AMD GPU devices"
> -       depends on (DRM_RADEON || DRM_AMDGPU) && AMD_IOMMU_V2 && X86_64
> +       depends on DRM_RADEON && AMD_IOMMU_V2 && X86_64
>         help
>           Enable this if you want to use HSA features on AMD GPU devices.
> --
> 2.1.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2014-11-21 20:47 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-11-21 20:40 [PATCH] amdkfd: Remove DRM_AMDGPU dependency from Kconfig Oded Gabbay
2014-11-21 20:40 ` Oded Gabbay
2014-11-21 20:47 ` Thierry Reding
2014-11-21 20:47   ` Thierry Reding
2014-11-21 20:47 ` Alex Deucher
2014-11-21 20:47   ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.