All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd: fix potential memory leak
@ 2022-08-23  6:35 ` Bernard Zhao
  0 siblings, 0 replies; 13+ messages in thread
From: Bernard Zhao @ 2022-08-23  6:35 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
	Nicholas Kazlauskas, Eric Yang, Michael Strauss, Fangzhi Zuo,
	Melissa Wen, amd-gfx, dri-devel, linux-kernel
  Cc: zhaojunkui2008, Bernard Zhao

This patch fix potential memory leak (clk_src) when function run
into last return NULL.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
index 85f32206a766..c7bb76a2a8c2 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
@@ -1643,6 +1643,7 @@ static struct clock_source *dcn31_clock_source_create(
 	}
 
 	BREAK_TO_DEBUGGER();
+	kfree(clk_src);
 	return NULL;
 }
 
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH] drm/amd: fix potential memory leak
@ 2022-08-23  6:35 ` Bernard Zhao
  0 siblings, 0 replies; 13+ messages in thread
From: Bernard Zhao @ 2022-08-23  6:35 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
	Nicholas Kazlauskas, Eric Yang, Michael Strauss, Fangzhi Zuo,
	Melissa Wen, amd-gfx, dri-devel, linux-kernel
  Cc: Bernard Zhao, zhaojunkui2008

This patch fix potential memory leak (clk_src) when function run
into last return NULL.
Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
index 85f32206a766..c7bb76a2a8c2 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
@@ -1643,6 +1643,7 @@ static struct clock_source *dcn31_clock_source_create(
 	}
 
 	BREAK_TO_DEBUGGER();
+	kfree(clk_src);
 	return NULL;
 }
 
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/amd: fix potential memory leak
  2022-08-23  6:35 ` Bernard Zhao
  (?)
@ 2022-08-25 15:59   ` Alex Deucher
  -1 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2022-08-25 15:59 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
	Nicholas Kazlauskas, Eric Yang, Michael Strauss, Fangzhi Zuo,
	Melissa Wen, amd-gfx, dri-devel, linux-kernel, zhaojunkui2008

Applied.  Thanks!

Alex

On Tue, Aug 23, 2022 at 2:36 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> This patch fix potential memory leak (clk_src) when function run
> into last return NULL.
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 85f32206a766..c7bb76a2a8c2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -1643,6 +1643,7 @@ static struct clock_source *dcn31_clock_source_create(
>         }
>
>         BREAK_TO_DEBUGGER();
> +       kfree(clk_src);
>         return NULL;
>  }
>
> --
> 2.33.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/amd: fix potential memory leak
@ 2022-08-25 15:59   ` Alex Deucher
  0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2022-08-25 15:59 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: zhaojunkui2008, Eric Yang, Leo Li, Pan, Xinhui, Rodrigo Siqueira,
	linux-kernel, amd-gfx, Nicholas Kazlauskas, Melissa Wen,
	David Airlie, Fangzhi Zuo, Michael Strauss, dri-devel,
	Alex Deucher, Christian König

Applied.  Thanks!

Alex

On Tue, Aug 23, 2022 at 2:36 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> This patch fix potential memory leak (clk_src) when function run
> into last return NULL.
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 85f32206a766..c7bb76a2a8c2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -1643,6 +1643,7 @@ static struct clock_source *dcn31_clock_source_create(
>         }
>
>         BREAK_TO_DEBUGGER();
> +       kfree(clk_src);
>         return NULL;
>  }
>
> --
> 2.33.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/amd: fix potential memory leak
@ 2022-08-25 15:59   ` Alex Deucher
  0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2022-08-25 15:59 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: zhaojunkui2008, Eric Yang, Leo Li, Pan, Xinhui, Rodrigo Siqueira,
	linux-kernel, amd-gfx, Nicholas Kazlauskas, Melissa Wen,
	David Airlie, Fangzhi Zuo, Michael Strauss, dri-devel,
	Daniel Vetter, Alex Deucher, Harry Wentland,
	Christian König

Applied.  Thanks!

Alex

On Tue, Aug 23, 2022 at 2:36 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> This patch fix potential memory leak (clk_src) when function run
> into last return NULL.
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 85f32206a766..c7bb76a2a8c2 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -1643,6 +1643,7 @@ static struct clock_source *dcn31_clock_source_create(
>         }
>
>         BREAK_TO_DEBUGGER();
> +       kfree(clk_src);
>         return NULL;
>  }
>
> --
> 2.33.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/amd: fix potential memory leak
  2022-08-23  6:49 ` Bernard Zhao
  (?)
@ 2022-08-25 16:10   ` Alex Deucher
  -1 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2022-08-25 16:10 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
	Nicholas Kazlauskas, Eric Yang, Michael Strauss, Fangzhi Zuo,
	Melissa Wen, amd-gfx, dri-devel, linux-kernel, zhaojunkui2008

On Tue, Aug 23, 2022 at 3:29 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> This patch fix potential memory leak (clk_src) when function run
> into last return NULL.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 85f32206a766..76f263846c6b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create(
>         }
>
>         BREAK_TO_DEBUGGER();
> +       free(clk_src);

This should be kfree().  Fixed up locally.

Alex

>         return NULL;
>  }
>
> --
> 2.33.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/amd: fix potential memory leak
@ 2022-08-25 16:10   ` Alex Deucher
  0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2022-08-25 16:10 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: zhaojunkui2008, Eric Yang, Leo Li, Pan, Xinhui, Rodrigo Siqueira,
	linux-kernel, amd-gfx, Nicholas Kazlauskas, Melissa Wen,
	David Airlie, Fangzhi Zuo, Michael Strauss, dri-devel,
	Alex Deucher, Christian König

On Tue, Aug 23, 2022 at 3:29 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> This patch fix potential memory leak (clk_src) when function run
> into last return NULL.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 85f32206a766..76f263846c6b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create(
>         }
>
>         BREAK_TO_DEBUGGER();
> +       free(clk_src);

This should be kfree().  Fixed up locally.

Alex

>         return NULL;
>  }
>
> --
> 2.33.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/amd: fix potential memory leak
@ 2022-08-25 16:10   ` Alex Deucher
  0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2022-08-25 16:10 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: zhaojunkui2008, Eric Yang, Leo Li, Pan, Xinhui, Rodrigo Siqueira,
	linux-kernel, amd-gfx, Nicholas Kazlauskas, Melissa Wen,
	David Airlie, Fangzhi Zuo, Michael Strauss, dri-devel,
	Daniel Vetter, Alex Deucher, Harry Wentland,
	Christian König

On Tue, Aug 23, 2022 at 3:29 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> This patch fix potential memory leak (clk_src) when function run
> into last return NULL.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 85f32206a766..76f263846c6b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create(
>         }
>
>         BREAK_TO_DEBUGGER();
> +       free(clk_src);

This should be kfree().  Fixed up locally.

Alex

>         return NULL;
>  }
>
> --
> 2.33.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/amd: fix potential memory leak
  2022-08-23  6:49 ` Bernard Zhao
  (?)
@ 2022-08-25 15:58   ` Alex Deucher
  -1 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2022-08-25 15:58 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
	Nicholas Kazlauskas, Eric Yang, Michael Strauss, Fangzhi Zuo,
	Melissa Wen, amd-gfx, dri-devel, linux-kernel, zhaojunkui2008

Applied.  Thanks!

On Tue, Aug 23, 2022 at 3:29 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> This patch fix potential memory leak (clk_src) when function run
> into last return NULL.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 85f32206a766..76f263846c6b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create(
>         }
>
>         BREAK_TO_DEBUGGER();
> +       free(clk_src);
>         return NULL;
>  }
>
> --
> 2.33.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/amd: fix potential memory leak
@ 2022-08-25 15:58   ` Alex Deucher
  0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2022-08-25 15:58 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: zhaojunkui2008, Eric Yang, Leo Li, Pan, Xinhui, Rodrigo Siqueira,
	linux-kernel, amd-gfx, Nicholas Kazlauskas, Melissa Wen,
	David Airlie, Fangzhi Zuo, Michael Strauss, dri-devel,
	Daniel Vetter, Alex Deucher, Harry Wentland,
	Christian König

Applied.  Thanks!

On Tue, Aug 23, 2022 at 3:29 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> This patch fix potential memory leak (clk_src) when function run
> into last return NULL.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 85f32206a766..76f263846c6b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create(
>         }
>
>         BREAK_TO_DEBUGGER();
> +       free(clk_src);
>         return NULL;
>  }
>
> --
> 2.33.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* Re: [PATCH] drm/amd: fix potential memory leak
@ 2022-08-25 15:58   ` Alex Deucher
  0 siblings, 0 replies; 13+ messages in thread
From: Alex Deucher @ 2022-08-25 15:58 UTC (permalink / raw)
  To: Bernard Zhao
  Cc: zhaojunkui2008, Eric Yang, Leo Li, Pan, Xinhui, Rodrigo Siqueira,
	linux-kernel, amd-gfx, Nicholas Kazlauskas, Melissa Wen,
	David Airlie, Fangzhi Zuo, Michael Strauss, dri-devel,
	Alex Deucher, Christian König

Applied.  Thanks!

On Tue, Aug 23, 2022 at 3:29 AM Bernard Zhao <bernard@vivo.com> wrote:
>
> This patch fix potential memory leak (clk_src) when function run
> into last return NULL.
>
> Signed-off-by: Bernard Zhao <bernard@vivo.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> index 85f32206a766..76f263846c6b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
> @@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create(
>         }
>
>         BREAK_TO_DEBUGGER();
> +       free(clk_src);
>         return NULL;
>  }
>
> --
> 2.33.1
>

^ permalink raw reply	[flat|nested] 13+ messages in thread
* [PATCH] drm/amd: fix potential memory leak
@ 2022-08-23  6:49 ` Bernard Zhao
  0 siblings, 0 replies; 13+ messages in thread
From: Bernard Zhao @ 2022-08-23  6:49 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
	Nicholas Kazlauskas, Eric Yang, Michael Strauss, Fangzhi Zuo,
	Melissa Wen, amd-gfx, dri-devel, linux-kernel
  Cc: zhaojunkui2008, Bernard Zhao

This patch fix potential memory leak (clk_src) when function run
into last return NULL.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
index 85f32206a766..76f263846c6b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
@@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create(
 	}
 
 	BREAK_TO_DEBUGGER();
+	free(clk_src);
 	return NULL;
 }
 
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
* [PATCH] drm/amd: fix potential memory leak
@ 2022-08-23  6:49 ` Bernard Zhao
  0 siblings, 0 replies; 13+ messages in thread
From: Bernard Zhao @ 2022-08-23  6:49 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, Pan, Xinhui, David Airlie, Daniel Vetter,
	Nicholas Kazlauskas, Eric Yang, Michael Strauss, Fangzhi Zuo,
	Melissa Wen, amd-gfx, dri-devel, linux-kernel
  Cc: Bernard Zhao, zhaojunkui2008

This patch fix potential memory leak (clk_src) when function run
into last return NULL.

Signed-off-by: Bernard Zhao <bernard@vivo.com>
---
 drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
index 85f32206a766..76f263846c6b 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn314/dcn314_resource.c
@@ -1715,6 +1715,7 @@ static struct clock_source *dcn30_clock_source_create(
 	}
 
 	BREAK_TO_DEBUGGER();
+	free(clk_src);
 	return NULL;
 }
 
-- 
2.33.1


^ permalink raw reply related	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2022-08-25 16:10 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-08-23  6:35 [PATCH] drm/amd: fix potential memory leak Bernard Zhao
2022-08-23  6:35 ` Bernard Zhao
2022-08-25 15:59 ` Alex Deucher
2022-08-25 15:59   ` Alex Deucher
2022-08-25 15:59   ` Alex Deucher
2022-08-23  6:49 Bernard Zhao
2022-08-23  6:49 ` Bernard Zhao
2022-08-25 15:58 ` Alex Deucher
2022-08-25 15:58   ` Alex Deucher
2022-08-25 15:58   ` Alex Deucher
2022-08-25 16:10 ` Alex Deucher
2022-08-25 16:10   ` Alex Deucher
2022-08-25 16:10   ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.