* [PATCH] drm/amdkfd: Load mqd to hqd in non-HWS mode
@ 2015-01-04 19:53 Oded Gabbay
2015-01-06 14:48 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Oded Gabbay @ 2015-01-04 19:53 UTC (permalink / raw)
To: dri-devel
From: Ben Goz <ben.goz@amd.com>
This patch fixes a bug in DQM, where the MQD of a newly created compute queue
is not loaded to an HQD slot. As a result, the CP never reads packets from this
queue.
This bug happens only in non-HWS (hardware scheduling) mode. In HWS mode, the
CP is responsible of loading MQDs to HQDs slots.
Signed-off-by: Ben Goz <ben.goz@amd.com>
Reviewed-by: Oded Gabbay <oded.gabbay@amd.com>
---
drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
index f44d673..3b08ed6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
@@ -272,6 +272,18 @@ static int create_compute_queue_nocpsch(struct device_queue_manager *dqm,
return retval;
}
+ pr_debug("kfd: loading mqd to hqd on pipe (%d) queue (%d)\n",
+ q->pipe,
+ q->queue);
+
+ retval = mqd->load_mqd(mqd, q->mqd, q->pipe,
+ q->queue, q->properties.write_ptr);
+ if (retval != 0) {
+ deallocate_hqd(dqm, q);
+ mqd->uninit_mqd(mqd, q->mqd, q->mqd_mem_obj);
+ return retval;
+ }
+
return 0;
}
--
2.1.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/amdkfd: Load mqd to hqd in non-HWS mode
2015-01-04 19:53 [PATCH] drm/amdkfd: Load mqd to hqd in non-HWS mode Oded Gabbay
@ 2015-01-06 14:48 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2015-01-06 14:48 UTC (permalink / raw)
To: Oded Gabbay; +Cc: Maling list - DRI developers
On Sun, Jan 4, 2015 at 2:53 PM, Oded Gabbay <oded.gabbay@amd.com> wrote:
> From: Ben Goz <ben.goz@amd.com>
>
> This patch fixes a bug in DQM, where the MQD of a newly created compute queue
> is not loaded to an HQD slot. As a result, the CP never reads packets from this
> queue.
>
> This bug happens only in non-HWS (hardware scheduling) mode. In HWS mode, the
> CP is responsible of loading MQDs to HQDs slots.
>
> Signed-off-by: Ben Goz <ben.goz@amd.com>
> Reviewed-by: Oded Gabbay <oded.gabbay@amd.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> index f44d673..3b08ed6 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
> @@ -272,6 +272,18 @@ static int create_compute_queue_nocpsch(struct device_queue_manager *dqm,
> return retval;
> }
>
> + pr_debug("kfd: loading mqd to hqd on pipe (%d) queue (%d)\n",
> + q->pipe,
> + q->queue);
> +
> + retval = mqd->load_mqd(mqd, q->mqd, q->pipe,
> + q->queue, q->properties.write_ptr);
> + if (retval != 0) {
> + deallocate_hqd(dqm, q);
> + mqd->uninit_mqd(mqd, q->mqd, q->mqd_mem_obj);
> + return retval;
> + }
> +
> return 0;
> }
>
> --
> 2.1.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-06 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-01-04 19:53 [PATCH] drm/amdkfd: Load mqd to hqd in non-HWS mode Oded Gabbay
2015-01-06 14:48 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.