* [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time @ 2019-07-09 5:41 Evan Quan [not found] ` <20190709054111.11433-1-evan.quan-5C7GfCeVMHo@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Evan Quan @ 2019-07-09 5:41 UTC (permalink / raw) To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Alexander.Deucher-5C7GfCeVMHo, Andrey.Grodzovsky-5C7GfCeVMHo, Evan Quan, Xiaowei.Wu-5C7GfCeVMHo Increase the waiting time to 1s from 200ms. This is expected to fix some mode1 reset failures. Change-Id: I4c11996628cd40d559c6edea97d092f397122d78 Signed-off-by: Evan Quan <evan.quan@amd.com> --- drivers/gpu/drm/amd/include/amd_shared.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h index 447bc4d..779c9e7 100644 --- a/drivers/gpu/drm/amd/include/amd_shared.h +++ b/drivers/gpu/drm/amd/include/amd_shared.h @@ -28,7 +28,7 @@ #endif -#define AMD_MAX_USEC_TIMEOUT 200000 /* 200 ms */ +#define AMD_MAX_USEC_TIMEOUT 1000000 /* 1000 ms */ /* * Chip flags -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <20190709054111.11433-1-evan.quan-5C7GfCeVMHo@public.gmane.org>]
* Re: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time [not found] ` <20190709054111.11433-1-evan.quan-5C7GfCeVMHo@public.gmane.org> @ 2019-07-09 12:40 ` Deucher, Alexander [not found] ` <BN6PR12MB180934CC91BC9A2A3C393AC2F7F10-/b2+HYfkarSEx6ez0IUAagdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Deucher, Alexander @ 2019-07-09 12:40 UTC (permalink / raw) To: Quan, Evan, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Grodzovsky, Andrey, Wu, Xiaowei [-- Attachment #1.1: Type: text/plain, Size: 1580 bytes --] If this is just for the SMU, maybe it would be better to add a separate timeout for the SMU since this will increase the timeout for lots of things, unless we need an overall timeout increase for mode1 reset. Alex ________________________________ From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> on behalf of Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org> Sent: Tuesday, July 9, 2019 1:41 AM To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Deucher, Alexander; Grodzovsky, Andrey; Quan, Evan; Wu, Xiaowei Subject: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time Increase the waiting time to 1s from 200ms. This is expected to fix some mode1 reset failures. Change-Id: I4c11996628cd40d559c6edea97d092f397122d78 Signed-off-by: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org> --- drivers/gpu/drm/amd/include/amd_shared.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h index 447bc4d..779c9e7 100644 --- a/drivers/gpu/drm/amd/include/amd_shared.h +++ b/drivers/gpu/drm/amd/include/amd_shared.h @@ -28,7 +28,7 @@ #endif -#define AMD_MAX_USEC_TIMEOUT 200000 /* 200 ms */ +#define AMD_MAX_USEC_TIMEOUT 1000000 /* 1000 ms */ /* * Chip flags -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx [-- Attachment #1.2: Type: text/html, Size: 2883 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <BN6PR12MB180934CC91BC9A2A3C393AC2F7F10-/b2+HYfkarSEx6ez0IUAagdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* RE: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time [not found] ` <BN6PR12MB180934CC91BC9A2A3C393AC2F7F10-/b2+HYfkarSEx6ez0IUAagdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2019-07-10 1:16 ` Quan, Evan [not found] ` <BN8PR12MB33290CA144CF8883E42E8E0FE4F00-h6+T2+wrnx3WSNCBJ7MpiAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 0 siblings, 1 reply; 4+ messages in thread From: Quan, Evan @ 2019-07-10 1:16 UTC (permalink / raw) To: Deucher, Alexander, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW Cc: Grodzovsky, Andrey, Wu, Xiaowei [-- Attachment #1.1: Type: text/plain, Size: 2886 bytes --] Hi Alex, There are actually two MAX_USEC_TIMEOUT related macros. AMD_MAX_USEC_TIMEOUT is used for SMU and AMDGPU_MAX_USEC_TIMEOUT is used widely in other parts. Maybe you mistreated it as AMDGPU_MAX_USEC_TIMEOUT. I was confused by them too. drivers/gpu/drm/amd/include/amd_shared.h:29:#define AMD_MAX_USEC_TIMEOUT 200000 /* 200 ms */ drivers/gpu/drm/amd/amdgpu/amdgpu.h:179:#define AMDGPU_MAX_USEC_TIMEOUT 100000 /* 100 ms */ I'm considering to sort these timeout settings up later. Maybe to combine them as one or give them differentiated names. Regards, Evan From: Deucher, Alexander <Alexander.Deucher-5C7GfCeVMHo@public.gmane.org> Sent: Tuesday, July 09, 2019 8:41 PM To: Quan, Evan <Evan.Quan-5C7GfCeVMHo@public.gmane.org>; amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Cc: Grodzovsky, Andrey <Andrey.Grodzovsky-5C7GfCeVMHo@public.gmane.org>; Wu, Xiaowei <Xiaowei.Wu@amd.com> Subject: Re: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time If this is just for the SMU, maybe it would be better to add a separate timeout for the SMU since this will increase the timeout for lots of things, unless we need an overall timeout increase for mode1 reset. Alex ________________________________ From: amd-gfx <amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx-bounces@lists.freedesktop.org>> on behalf of Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org<mailto:evan.quan-5C7GfCeVMHo@public.gmane.org>> Sent: Tuesday, July 9, 2019 1:41 AM To: amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> Cc: Deucher, Alexander; Grodzovsky, Andrey; Quan, Evan; Wu, Xiaowei Subject: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time Increase the waiting time to 1s from 200ms. This is expected to fix some mode1 reset failures. Change-Id: I4c11996628cd40d559c6edea97d092f397122d78 Signed-off-by: Evan Quan <evan.quan-5C7GfCeVMHo@public.gmane.org<mailto:evan.quan-5C7GfCeVMHo@public.gmane.org>> --- drivers/gpu/drm/amd/include/amd_shared.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h index 447bc4d..779c9e7 100644 --- a/drivers/gpu/drm/amd/include/amd_shared.h +++ b/drivers/gpu/drm/amd/include/amd_shared.h @@ -28,7 +28,7 @@ #endif -#define AMD_MAX_USEC_TIMEOUT 200000 /* 200 ms */ +#define AMD_MAX_USEC_TIMEOUT 1000000 /* 1000 ms */ /* * Chip flags -- 2.7.4 _______________________________________________ amd-gfx mailing list amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org<mailto:amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org> https://lists.freedesktop.org/mailman/listinfo/amd-gfx [-- Attachment #1.2: Type: text/html, Size: 7096 bytes --] [-- Attachment #2: Type: text/plain, Size: 153 bytes --] _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply related [flat|nested] 4+ messages in thread
[parent not found: <BN8PR12MB33290CA144CF8883E42E8E0FE4F00-h6+T2+wrnx3WSNCBJ7MpiAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>]
* Re: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time [not found] ` <BN8PR12MB33290CA144CF8883E42E8E0FE4F00-h6+T2+wrnx3WSNCBJ7MpiAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> @ 2019-07-10 17:55 ` Alex Deucher 0 siblings, 0 replies; 4+ messages in thread From: Alex Deucher @ 2019-07-10 17:55 UTC (permalink / raw) To: Quan, Evan Cc: Deucher, Alexander, Grodzovsky, Andrey, amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW, Wu, Xiaowei On Tue, Jul 9, 2019 at 9:17 PM Quan, Evan <Evan.Quan@amd.com> wrote: > > Hi Alex, > > > > There are actually two MAX_USEC_TIMEOUT related macros. > > AMD_MAX_USEC_TIMEOUT is used for SMU and AMDGPU_MAX_USEC_TIMEOUT is used widely in other parts. > > Maybe you mistreated it as AMDGPU_MAX_USEC_TIMEOUT. I was confused by them too. > > > > drivers/gpu/drm/amd/include/amd_shared.h:29:#define AMD_MAX_USEC_TIMEOUT 200000 /* 200 ms */ > > drivers/gpu/drm/amd/amdgpu/amdgpu.h:179:#define AMDGPU_MAX_USEC_TIMEOUT 100000 /* 100 ms */ > > > > I’m considering to sort these timeout settings up later. Maybe to combine them as one or give them differentiated names. > > Indeed. I was mixing them up. We should clarify those. Patch is: Acked-by: Alex Deucher <alexander.deucher@amd.com> > > Regards, > > Evan > > From: Deucher, Alexander <Alexander.Deucher@amd.com> > Sent: Tuesday, July 09, 2019 8:41 PM > To: Quan, Evan <Evan.Quan@amd.com>; amd-gfx@lists.freedesktop.org > Cc: Grodzovsky, Andrey <Andrey.Grodzovsky@amd.com>; Wu, Xiaowei <Xiaowei.Wu@amd.com> > Subject: Re: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time > > > > If this is just for the SMU, maybe it would be better to add a separate timeout for the SMU since this will increase the timeout for lots of things, unless we need an overall timeout increase for mode1 reset. > > > > Alex > > ________________________________ > > From: amd-gfx <amd-gfx-bounces@lists.freedesktop.org> on behalf of Evan Quan <evan.quan@amd.com> > Sent: Tuesday, July 9, 2019 1:41 AM > To: amd-gfx@lists.freedesktop.org > Cc: Deucher, Alexander; Grodzovsky, Andrey; Quan, Evan; Wu, Xiaowei > Subject: [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time > > > > Increase the waiting time to 1s from 200ms. This is expected > to fix some mode1 reset failures. > > Change-Id: I4c11996628cd40d559c6edea97d092f397122d78 > Signed-off-by: Evan Quan <evan.quan@amd.com> > --- > drivers/gpu/drm/amd/include/amd_shared.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/include/amd_shared.h b/drivers/gpu/drm/amd/include/amd_shared.h > index 447bc4d..779c9e7 100644 > --- a/drivers/gpu/drm/amd/include/amd_shared.h > +++ b/drivers/gpu/drm/amd/include/amd_shared.h > @@ -28,7 +28,7 @@ > #endif > > > -#define AMD_MAX_USEC_TIMEOUT 200000 /* 200 ms */ > +#define AMD_MAX_USEC_TIMEOUT 1000000 /* 1000 ms */ > > /* > * Chip flags > -- > 2.7.4 > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx > > _______________________________________________ > amd-gfx mailing list > amd-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/amd-gfx _______________________________________________ amd-gfx mailing list amd-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-10 17:55 UTC | newest] Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-07-09 5:41 [PATCH] drm/amd/powerplay: increase the SMU msg response waiting time Evan Quan [not found] ` <20190709054111.11433-1-evan.quan-5C7GfCeVMHo@public.gmane.org> 2019-07-09 12:40 ` Deucher, Alexander [not found] ` <BN6PR12MB180934CC91BC9A2A3C393AC2F7F10-/b2+HYfkarSEx6ez0IUAagdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-07-10 1:16 ` Quan, Evan [not found] ` <BN8PR12MB33290CA144CF8883E42E8E0FE4F00-h6+T2+wrnx3WSNCBJ7MpiAdYzm3356FpvxpqHgZTriW3zl9H0oFU5g@public.gmane.org> 2019-07-10 17:55 ` Alex Deucher
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.