* [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable
@ 2022-09-20 6:35 ` cgel.zte
0 siblings, 0 replies; 5+ messages in thread
From: cgel.zte @ 2022-09-20 6:35 UTC (permalink / raw)
To: alexander.deucher
Cc: airlied, ye xingchen, Zeal Robot, Xinhui.Pan, linux-kernel,
amd-gfx, dri-devel, evan.quan, christian.koenig
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value append_vbios_pptable() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
.../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
index 1e79baab753e..bd54fbd393b9 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
@@ -195,7 +195,6 @@ static int init_powerplay_table_information(
struct phm_ppt_v3_information *pptable_information =
(struct phm_ppt_v3_information *)hwmgr->pptable;
uint32_t disable_power_control = 0;
- int result;
hwmgr->thermal_controller.ucType = powerplay_table->ucThermalControllerType;
pptable_information->uc_thermal_controller_type = powerplay_table->ucThermalControllerType;
@@ -257,9 +256,7 @@ static int init_powerplay_table_information(
if (pptable_information->smc_pptable == NULL)
return -ENOMEM;
- result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
-
- return result;
+ return append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
}
static int vega12_pp_tables_initialize(struct pp_hwmgr *hwmgr)
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable
@ 2022-09-20 6:35 ` cgel.zte
0 siblings, 0 replies; 5+ messages in thread
From: cgel.zte @ 2022-09-20 6:35 UTC (permalink / raw)
To: alexander.deucher
Cc: evan.quan, christian.koenig, Xinhui.Pan, airlied, daniel,
amd-gfx, dri-devel, linux-kernel, ye xingchen, Zeal Robot
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value append_vbios_pptable() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
.../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
index 1e79baab753e..bd54fbd393b9 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
@@ -195,7 +195,6 @@ static int init_powerplay_table_information(
struct phm_ppt_v3_information *pptable_information =
(struct phm_ppt_v3_information *)hwmgr->pptable;
uint32_t disable_power_control = 0;
- int result;
hwmgr->thermal_controller.ucType = powerplay_table->ucThermalControllerType;
pptable_information->uc_thermal_controller_type = powerplay_table->ucThermalControllerType;
@@ -257,9 +256,7 @@ static int init_powerplay_table_information(
if (pptable_information->smc_pptable == NULL)
return -ENOMEM;
- result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
-
- return result;
+ return append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
}
static int vega12_pp_tables_initialize(struct pp_hwmgr *hwmgr)
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable
@ 2022-09-20 6:35 ` cgel.zte
0 siblings, 0 replies; 5+ messages in thread
From: cgel.zte @ 2022-09-20 6:35 UTC (permalink / raw)
To: alexander.deucher
Cc: airlied, ye xingchen, Zeal Robot, Xinhui.Pan, linux-kernel,
amd-gfx, dri-devel, daniel, evan.quan, christian.koenig
From: ye xingchen <ye.xingchen@zte.com.cn>
Return the value append_vbios_pptable() directly instead of storing it in
another redundant variable.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
---
.../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
index 1e79baab753e..bd54fbd393b9 100644
--- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
+++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
@@ -195,7 +195,6 @@ static int init_powerplay_table_information(
struct phm_ppt_v3_information *pptable_information =
(struct phm_ppt_v3_information *)hwmgr->pptable;
uint32_t disable_power_control = 0;
- int result;
hwmgr->thermal_controller.ucType = powerplay_table->ucThermalControllerType;
pptable_information->uc_thermal_controller_type = powerplay_table->ucThermalControllerType;
@@ -257,9 +256,7 @@ static int init_powerplay_table_information(
if (pptable_information->smc_pptable == NULL)
return -ENOMEM;
- result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
-
- return result;
+ return append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
}
static int vega12_pp_tables_initialize(struct pp_hwmgr *hwmgr)
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable
2022-09-20 6:35 ` cgel.zte
@ 2022-09-20 16:10 ` Alex Deucher
-1 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-09-20 16:10 UTC (permalink / raw)
To: cgel.zte
Cc: alexander.deucher, airlied, ye xingchen, Zeal Robot, Xinhui.Pan,
linux-kernel, amd-gfx, dri-devel, evan.quan, christian.koenig
Applied. Thanks.
On Tue, Sep 20, 2022 at 2:35 AM <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value append_vbios_pptable() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> .../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> index 1e79baab753e..bd54fbd393b9 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> @@ -195,7 +195,6 @@ static int init_powerplay_table_information(
> struct phm_ppt_v3_information *pptable_information =
> (struct phm_ppt_v3_information *)hwmgr->pptable;
> uint32_t disable_power_control = 0;
> - int result;
>
> hwmgr->thermal_controller.ucType = powerplay_table->ucThermalControllerType;
> pptable_information->uc_thermal_controller_type = powerplay_table->ucThermalControllerType;
> @@ -257,9 +256,7 @@ static int init_powerplay_table_information(
> if (pptable_information->smc_pptable == NULL)
> return -ENOMEM;
>
> - result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
> -
> - return result;
> + return append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
> }
>
> static int vega12_pp_tables_initialize(struct pp_hwmgr *hwmgr)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable
@ 2022-09-20 16:10 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-09-20 16:10 UTC (permalink / raw)
To: cgel.zte
Cc: airlied, ye xingchen, Zeal Robot, Xinhui.Pan, linux-kernel,
amd-gfx, dri-devel, alexander.deucher, evan.quan,
christian.koenig
Applied. Thanks.
On Tue, Sep 20, 2022 at 2:35 AM <cgel.zte@gmail.com> wrote:
>
> From: ye xingchen <ye.xingchen@zte.com.cn>
>
> Return the value append_vbios_pptable() directly instead of storing it in
> another redundant variable.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
> ---
> .../gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> index 1e79baab753e..bd54fbd393b9 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega12_processpptables.c
> @@ -195,7 +195,6 @@ static int init_powerplay_table_information(
> struct phm_ppt_v3_information *pptable_information =
> (struct phm_ppt_v3_information *)hwmgr->pptable;
> uint32_t disable_power_control = 0;
> - int result;
>
> hwmgr->thermal_controller.ucType = powerplay_table->ucThermalControllerType;
> pptable_information->uc_thermal_controller_type = powerplay_table->ucThermalControllerType;
> @@ -257,9 +256,7 @@ static int init_powerplay_table_information(
> if (pptable_information->smc_pptable == NULL)
> return -ENOMEM;
>
> - result = append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
> -
> - return result;
> + return append_vbios_pptable(hwmgr, (pptable_information->smc_pptable));
> }
>
> static int vega12_pp_tables_initialize(struct pp_hwmgr *hwmgr)
> --
> 2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-20 16:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 6:35 [PATCH linux-next] drm/amd/pm: Remove the unneeded result variable cgel.zte
2022-09-20 6:35 ` cgel.zte
2022-09-20 6:35 ` cgel.zte
2022-09-20 16:10 ` Alex Deucher
2022-09-20 16:10 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.