All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
       [not found] <20230724073153.9003-1-xujianghui@cdjrlc.com>
@ 2023-07-24  7:32   ` sunran001
  0 siblings, 0 replies; 8+ messages in thread
From: sunran001 @ 2023-07-24  7:32 UTC (permalink / raw)
  To: alexander.deucher; +Cc: amd-gfx, dri-devel, linux-kernel

Fix the following errors reported by checkpatch:

ERROR: spaces required around that '=' (ctx:VxW)
ERROR: spaces required around that '>=' (ctx:WxV)

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
index 3bb18396d2f9..c49f770c97b3 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
@@ -598,7 +598,7 @@ static int arcturus_get_smu_metrics_data(struct 
smu_context *smu,
  					 MetricsMember_t member,
  					 uint32_t *value)
  {
-	struct smu_table_context *smu_table= &smu->smu_table;
+	struct smu_table_context *smu_table = &smu->smu_table;
  	SmuMetrics_t *metrics = (SmuMetrics_t *)smu_table->metrics_table;
  	int ret = 0;

@@ -1482,7 +1482,7 @@ static int arcturus_set_power_profile_mode(struct 
smu_context *smu,
  		return ret;

  	if ((profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) &&
-	     (smu_version >=0x360d00)) {
+	     (smu_version >= 0x360d00)) {
  		ret = smu_cmn_update_table(smu,
  				       SMU_TABLE_ACTIVITY_MONITOR_COEFF,
  				       WORKLOAD_PPLIB_CUSTOM_BIT,

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
@ 2023-07-24  7:32   ` sunran001
  0 siblings, 0 replies; 8+ messages in thread
From: sunran001 @ 2023-07-24  7:32 UTC (permalink / raw)
  To: alexander.deucher; +Cc: dri-devel, amd-gfx, linux-kernel

Fix the following errors reported by checkpatch:

ERROR: spaces required around that '=' (ctx:VxW)
ERROR: spaces required around that '>=' (ctx:WxV)

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
index 3bb18396d2f9..c49f770c97b3 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
@@ -598,7 +598,7 @@ static int arcturus_get_smu_metrics_data(struct 
smu_context *smu,
  					 MetricsMember_t member,
  					 uint32_t *value)
  {
-	struct smu_table_context *smu_table= &smu->smu_table;
+	struct smu_table_context *smu_table = &smu->smu_table;
  	SmuMetrics_t *metrics = (SmuMetrics_t *)smu_table->metrics_table;
  	int ret = 0;

@@ -1482,7 +1482,7 @@ static int arcturus_set_power_profile_mode(struct 
smu_context *smu,
  		return ret;

  	if ((profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) &&
-	     (smu_version >=0x360d00)) {
+	     (smu_version >= 0x360d00)) {
  		ret = smu_cmn_update_table(smu,
  				       SMU_TABLE_ACTIVITY_MONITOR_COEFF,
  				       WORKLOAD_PPLIB_CUSTOM_BIT,

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
  2023-07-24  7:32   ` sunran001
@ 2023-07-24 21:48     ` Alex Deucher
  -1 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2023-07-24 21:48 UTC (permalink / raw)
  To: sunran001; +Cc: alexander.deucher, dri-devel, amd-gfx, linux-kernel

Applied.  thanks!

On Mon, Jul 24, 2023 at 3:32 AM <sunran001@208suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '=' (ctx:VxW)
> ERROR: spaces required around that '>=' (ctx:WxV)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> index 3bb18396d2f9..c49f770c97b3 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> @@ -598,7 +598,7 @@ static int arcturus_get_smu_metrics_data(struct
> smu_context *smu,
>                                          MetricsMember_t member,
>                                          uint32_t *value)
>   {
> -       struct smu_table_context *smu_table= &smu->smu_table;
> +       struct smu_table_context *smu_table = &smu->smu_table;
>         SmuMetrics_t *metrics = (SmuMetrics_t *)smu_table->metrics_table;
>         int ret = 0;
>
> @@ -1482,7 +1482,7 @@ static int arcturus_set_power_profile_mode(struct
> smu_context *smu,
>                 return ret;
>
>         if ((profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) &&
> -            (smu_version >=0x360d00)) {
> +            (smu_version >= 0x360d00)) {
>                 ret = smu_cmn_update_table(smu,
>                                        SMU_TABLE_ACTIVITY_MONITOR_COEFF,
>                                        WORKLOAD_PPLIB_CUSTOM_BIT,

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
@ 2023-07-24 21:48     ` Alex Deucher
  0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2023-07-24 21:48 UTC (permalink / raw)
  To: sunran001; +Cc: alexander.deucher, amd-gfx, dri-devel, linux-kernel

Applied.  thanks!

On Mon, Jul 24, 2023 at 3:32 AM <sunran001@208suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: spaces required around that '=' (ctx:VxW)
> ERROR: spaces required around that '>=' (ctx:WxV)
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> index 3bb18396d2f9..c49f770c97b3 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/arcturus_ppt.c
> @@ -598,7 +598,7 @@ static int arcturus_get_smu_metrics_data(struct
> smu_context *smu,
>                                          MetricsMember_t member,
>                                          uint32_t *value)
>   {
> -       struct smu_table_context *smu_table= &smu->smu_table;
> +       struct smu_table_context *smu_table = &smu->smu_table;
>         SmuMetrics_t *metrics = (SmuMetrics_t *)smu_table->metrics_table;
>         int ret = 0;
>
> @@ -1482,7 +1482,7 @@ static int arcturus_set_power_profile_mode(struct
> smu_context *smu,
>                 return ret;
>
>         if ((profile_mode == PP_SMC_POWER_PROFILE_CUSTOM) &&
> -            (smu_version >=0x360d00)) {
> +            (smu_version >= 0x360d00)) {
>                 ret = smu_cmn_update_table(smu,
>                                        SMU_TABLE_ACTIVITY_MONITOR_COEFF,
>                                        WORKLOAD_PPLIB_CUSTOM_BIT,

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
  2023-07-24  7:49   ` sunran001
@ 2023-07-24 21:49     ` Alex Deucher
  -1 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2023-07-24 21:49 UTC (permalink / raw)
  To: sunran001; +Cc: alexander.deucher, dri-devel, amd-gfx, linux-kernel

Applied.  Thanks!

On Mon, Jul 24, 2023 at 3:49 AM <sunran001@208suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: "foo* bar" should be "foo *bar"
> ERROR: spaces required around that '=' (ctx:VxW)
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index 3ecb900e6ecd..b26e9ac1ac30 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -691,7 +691,7 @@ int smu_cmn_feature_set_enabled(struct smu_context
> *smu,
>
>   #undef __SMU_DUMMY_MAP
>   #define __SMU_DUMMY_MAP(fea)  #fea
> -static const char* __smu_feature_names[] = {
> +static const char *__smu_feature_names[] = {
>         SMU_FEATURE_MASKS
>   };
>
> @@ -927,7 +927,7 @@ int smu_cmn_get_metrics_table(struct smu_context
> *smu,
>                               void *metrics_table,
>                               bool bypass_cache)
>   {
> -       struct smu_table_context *smu_table= &smu->smu_table;
> +       struct smu_table_context *smu_table = &smu->smu_table;
>         uint32_t table_size =
>                 smu_table->tables[SMU_TABLE_SMU_METRICS].size;
>         int ret = 0;
> @@ -969,7 +969,7 @@ void smu_cmn_init_soft_gpu_metrics(void *table,
> uint8_t frev, uint8_t crev)
>         struct metrics_table_header *header = (struct metrics_table_header
> *)table;
>         uint16_t structure_size;
>
> -#define METRICS_VERSION(a, b)  ((a << 16) | b )
> +#define METRICS_VERSION(a, b)  ((a << 16) | b)
>
>         switch (METRICS_VERSION(frev, crev)) {
>         case METRICS_VERSION(1, 0):

^ permalink raw reply	[flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
@ 2023-07-24 21:49     ` Alex Deucher
  0 siblings, 0 replies; 8+ messages in thread
From: Alex Deucher @ 2023-07-24 21:49 UTC (permalink / raw)
  To: sunran001; +Cc: alexander.deucher, amd-gfx, dri-devel, linux-kernel

Applied.  Thanks!

On Mon, Jul 24, 2023 at 3:49 AM <sunran001@208suo.com> wrote:
>
> Fix the following errors reported by checkpatch:
>
> ERROR: "foo* bar" should be "foo *bar"
> ERROR: spaces required around that '=' (ctx:VxW)
> ERROR: space prohibited before that close parenthesis ')'
>
> Signed-off-by: Ran Sun <sunran001@208suo.com>
> ---
>   drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> index 3ecb900e6ecd..b26e9ac1ac30 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
> @@ -691,7 +691,7 @@ int smu_cmn_feature_set_enabled(struct smu_context
> *smu,
>
>   #undef __SMU_DUMMY_MAP
>   #define __SMU_DUMMY_MAP(fea)  #fea
> -static const char* __smu_feature_names[] = {
> +static const char *__smu_feature_names[] = {
>         SMU_FEATURE_MASKS
>   };
>
> @@ -927,7 +927,7 @@ int smu_cmn_get_metrics_table(struct smu_context
> *smu,
>                               void *metrics_table,
>                               bool bypass_cache)
>   {
> -       struct smu_table_context *smu_table= &smu->smu_table;
> +       struct smu_table_context *smu_table = &smu->smu_table;
>         uint32_t table_size =
>                 smu_table->tables[SMU_TABLE_SMU_METRICS].size;
>         int ret = 0;
> @@ -969,7 +969,7 @@ void smu_cmn_init_soft_gpu_metrics(void *table,
> uint8_t frev, uint8_t crev)
>         struct metrics_table_header *header = (struct metrics_table_header
> *)table;
>         uint16_t structure_size;
>
> -#define METRICS_VERSION(a, b)  ((a << 16) | b )
> +#define METRICS_VERSION(a, b)  ((a << 16) | b)
>
>         switch (METRICS_VERSION(frev, crev)) {
>         case METRICS_VERSION(1, 0):

^ permalink raw reply	[flat|nested] 8+ messages in thread
* [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
       [not found] <20230724074800.9099-1-xujianghui@cdjrlc.com>
@ 2023-07-24  7:49   ` sunran001
  0 siblings, 0 replies; 8+ messages in thread
From: sunran001 @ 2023-07-24  7:49 UTC (permalink / raw)
  To: alexander.deucher; +Cc: amd-gfx, dri-devel, linux-kernel

Fix the following errors reported by checkpatch:

ERROR: "foo* bar" should be "foo *bar"
ERROR: spaces required around that '=' (ctx:VxW)
ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index 3ecb900e6ecd..b26e9ac1ac30 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -691,7 +691,7 @@ int smu_cmn_feature_set_enabled(struct smu_context 
*smu,

  #undef __SMU_DUMMY_MAP
  #define __SMU_DUMMY_MAP(fea)	#fea
-static const char* __smu_feature_names[] = {
+static const char *__smu_feature_names[] = {
  	SMU_FEATURE_MASKS
  };

@@ -927,7 +927,7 @@ int smu_cmn_get_metrics_table(struct smu_context 
*smu,
  			      void *metrics_table,
  			      bool bypass_cache)
  {
-	struct smu_table_context *smu_table= &smu->smu_table;
+	struct smu_table_context *smu_table = &smu->smu_table;
  	uint32_t table_size =
  		smu_table->tables[SMU_TABLE_SMU_METRICS].size;
  	int ret = 0;
@@ -969,7 +969,7 @@ void smu_cmn_init_soft_gpu_metrics(void *table, 
uint8_t frev, uint8_t crev)
  	struct metrics_table_header *header = (struct metrics_table_header 
*)table;
  	uint16_t structure_size;

-#define METRICS_VERSION(a, b)	((a << 16) | b )
+#define METRICS_VERSION(a, b)	((a << 16) | b)

  	switch (METRICS_VERSION(frev, crev)) {
  	case METRICS_VERSION(1, 0):

^ permalink raw reply related	[flat|nested] 8+ messages in thread
* [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c
@ 2023-07-24  7:49   ` sunran001
  0 siblings, 0 replies; 8+ messages in thread
From: sunran001 @ 2023-07-24  7:49 UTC (permalink / raw)
  To: alexander.deucher; +Cc: dri-devel, amd-gfx, linux-kernel

Fix the following errors reported by checkpatch:

ERROR: "foo* bar" should be "foo *bar"
ERROR: spaces required around that '=' (ctx:VxW)
ERROR: space prohibited before that close parenthesis ')'

Signed-off-by: Ran Sun <sunran001@208suo.com>
---
  drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c | 6 +++---
  1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c 
b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
index 3ecb900e6ecd..b26e9ac1ac30 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu_cmn.c
@@ -691,7 +691,7 @@ int smu_cmn_feature_set_enabled(struct smu_context 
*smu,

  #undef __SMU_DUMMY_MAP
  #define __SMU_DUMMY_MAP(fea)	#fea
-static const char* __smu_feature_names[] = {
+static const char *__smu_feature_names[] = {
  	SMU_FEATURE_MASKS
  };

@@ -927,7 +927,7 @@ int smu_cmn_get_metrics_table(struct smu_context 
*smu,
  			      void *metrics_table,
  			      bool bypass_cache)
  {
-	struct smu_table_context *smu_table= &smu->smu_table;
+	struct smu_table_context *smu_table = &smu->smu_table;
  	uint32_t table_size =
  		smu_table->tables[SMU_TABLE_SMU_METRICS].size;
  	int ret = 0;
@@ -969,7 +969,7 @@ void smu_cmn_init_soft_gpu_metrics(void *table, 
uint8_t frev, uint8_t crev)
  	struct metrics_table_header *header = (struct metrics_table_header 
*)table;
  	uint16_t structure_size;

-#define METRICS_VERSION(a, b)	((a << 16) | b )
+#define METRICS_VERSION(a, b)	((a << 16) | b)

  	switch (METRICS_VERSION(frev, crev)) {
  	case METRICS_VERSION(1, 0):

^ permalink raw reply related	[flat|nested] 8+ messages in thread
end of thread, other threads:[~2023-07-24 21:49 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20230724073153.9003-1-xujianghui@cdjrlc.com>
2023-07-24  7:32 ` [PATCH] drm/amd/pm: Clean up errors in arcturus_ppt.c sunran001
2023-07-24  7:32   ` sunran001
2023-07-24 21:48   ` Alex Deucher
2023-07-24 21:48     ` Alex Deucher
     [not found] <20230724074800.9099-1-xujianghui@cdjrlc.com>
2023-07-24  7:49 ` sunran001
2023-07-24  7:49   ` sunran001
2023-07-24 21:49   ` Alex Deucher
2023-07-24 21:49     ` Alex Deucher

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.