* [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
@ 2019-01-28 17:22 ` Daniel Vetter
0 siblings, 0 replies; 14+ messages in thread
From: Daniel Vetter @ 2019-01-28 17:22 UTC (permalink / raw)
To: DRI Development, IGT development
Cc: Petri Latvala, Daniel Vetter, Daniel Vetter, Liviu Dudau,
Alex Deucher, Dave Airlie, Arkadiusz Hiler, Sean Paul
Compared to the RFC[1] no changes to the patch itself, but igt moved
forward a lot:
- gitlab CI builds with: reduced configs/libraries, arm cross build
and a sysroot build (should address all the build/cross platform
concerns raised in the RFC discussions).
- tests reorganized into subdirectories so that the i915-gem tests
don't clog the main/shared tests directory anymore
- quite a few more non-intel people contributing/reviewing/committing
igt tests patches.
I think this addresses all the concerns raised in the RFC discussions,
and assuming there's enough Acks and no new issues that pop up, we can
go ahead with this.
v2:
- Use "should" (in the usual RFC sense) to make it clear that in the
end this is all up to reviewer's discretion, as usual (Jani).
- Also in the title s/mandatory/strongly suggested/ (me)
- Make it clear we're not going to block features if a testcase is not
feasible, given hw and state of igt, both having some good gaps in
what can be tested (Harry, Eric, Sean, ...).
1: https://patchwork.kernel.org/patch/10648851/
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Eric Anholt <eric@anholt.net>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
Cc: Brian Starkey <Brian.Starkey@arm.com>
Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
Acked-by: Petri Latvala <petri.latvala@intel.com>
Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Acked-by: Sean Paul <sean@poorly.run>
Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
Documentation/gpu/drm-uapi.rst | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
index a752aa561ea4..c9fd23efd957 100644
--- a/Documentation/gpu/drm-uapi.rst
+++ b/Documentation/gpu/drm-uapi.rst
@@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
Testing and validation
======================
+Testing Requirements for userspace API
+--------------------------------------
+
+New cross-driver userspace interface extensions, like new IOCTL, new KMS
+properties, new files in sysfs or anything else that constitutes an API change
+should have driver-agnostic testcases in IGT for that feature, if such a test
+can be reasonably made using IGT for the target hardware.
+
Validating changes with IGT
---------------------------
--
2.20.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
@ 2019-01-28 17:22 ` Daniel Vetter
0 siblings, 0 replies; 14+ messages in thread
From: Daniel Vetter @ 2019-01-28 17:22 UTC (permalink / raw)
To: DRI Development, IGT development
Cc: Petri Latvala, Daniel Vetter, Liviu Dudau, Alex Deucher,
Dave Airlie, Sean Paul, Brian Starkey
Compared to the RFC[1] no changes to the patch itself, but igt moved
forward a lot:
- gitlab CI builds with: reduced configs/libraries, arm cross build
and a sysroot build (should address all the build/cross platform
concerns raised in the RFC discussions).
- tests reorganized into subdirectories so that the i915-gem tests
don't clog the main/shared tests directory anymore
- quite a few more non-intel people contributing/reviewing/committing
igt tests patches.
I think this addresses all the concerns raised in the RFC discussions,
and assuming there's enough Acks and no new issues that pop up, we can
go ahead with this.
v2:
- Use "should" (in the usual RFC sense) to make it clear that in the
end this is all up to reviewer's discretion, as usual (Jani).
- Also in the title s/mandatory/strongly suggested/ (me)
- Make it clear we're not going to block features if a testcase is not
feasible, given hw and state of igt, both having some good gaps in
what can be tested (Harry, Eric, Sean, ...).
1: https://patchwork.kernel.org/patch/10648851/
Cc: Petri Latvala <petri.latvala@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Cc: Liviu Dudau <liviu.dudau@arm.com>
Cc: Sean Paul <sean@poorly.run>
Cc: Eric Anholt <eric@anholt.net>
Cc: Alex Deucher <alexander.deucher@amd.com>
Cc: Dave Airlie <airlied@redhat.com>
Cc: Daniel Stone <daniel@fooishbar.org>
Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
Cc: Brian Starkey <Brian.Starkey@arm.com>
Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
Acked-by: Petri Latvala <petri.latvala@intel.com>
Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
Acked-by: Sean Paul <sean@poorly.run>
Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
Documentation/gpu/drm-uapi.rst | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
index a752aa561ea4..c9fd23efd957 100644
--- a/Documentation/gpu/drm-uapi.rst
+++ b/Documentation/gpu/drm-uapi.rst
@@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
Testing and validation
======================
+Testing Requirements for userspace API
+--------------------------------------
+
+New cross-driver userspace interface extensions, like new IOCTL, new KMS
+properties, new files in sysfs or anything else that constitutes an API change
+should have driver-agnostic testcases in IGT for that feature, if such a test
+can be reasonably made using IGT for the target hardware.
+
Validating changes with IGT
---------------------------
--
2.20.1
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply related [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
2019-01-28 17:22 ` [igt-dev] " Daniel Vetter
@ 2019-01-28 17:51 ` Liviu Dudau
-1 siblings, 0 replies; 14+ messages in thread
From: Liviu Dudau @ 2019-01-28 17:51 UTC (permalink / raw)
To: Daniel Vetter
Cc: Petri Latvala, DRI Development, IGT development, Daniel Vetter,
Alex Deucher, Dave Airlie, Arkadiusz Hiler, Sean Paul
On Mon, Jan 28, 2019 at 06:22:58PM +0100, Daniel Vetter wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
> Validating changes with IGT
> ---------------------------
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Thanks for the updates!
Best regards,
Liviu
>
> --
> 2.20.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
@ 2019-01-28 17:51 ` Liviu Dudau
0 siblings, 0 replies; 14+ messages in thread
From: Liviu Dudau @ 2019-01-28 17:51 UTC (permalink / raw)
To: Daniel Vetter
Cc: Petri Latvala, DRI Development, IGT development, Daniel Vetter,
Alex Deucher, Dave Airlie, Sean Paul, Brian Starkey
On Mon, Jan 28, 2019 at 06:22:58PM +0100, Daniel Vetter wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
> Validating changes with IGT
> ---------------------------
Acked-by: Liviu Dudau <liviu.dudau@arm.com>
Thanks for the updates!
Best regards,
Liviu
>
> --
> 2.20.1
>
--
====================
| I would like to |
| fix the world, |
| but they're not |
| giving me the |
\ source code! /
---------------
¯\_(ツ)_/¯
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
2019-01-28 17:22 ` [igt-dev] " Daniel Vetter
@ 2019-01-29 7:27 ` Jani Nikula
-1 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2019-01-29 7:27 UTC (permalink / raw)
To: DRI Development, IGT development
Cc: Petri Latvala, Daniel Vetter, Liviu Dudau, Dave Airlie,
Alex Deucher, Daniel Vetter, Arkadiusz Hiler, Sean Paul
On Mon, 28 Jan 2019, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
This is no longer compatible with the v2 changelog below. ;)
I'm biased so this doesn't carry so much value, but here goes anyway,
Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
> Validating changes with IGT
> ---------------------------
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
@ 2019-01-29 7:27 ` Jani Nikula
0 siblings, 0 replies; 14+ messages in thread
From: Jani Nikula @ 2019-01-29 7:27 UTC (permalink / raw)
To: Daniel Vetter, DRI Development, IGT development
Cc: Petri Latvala, Liviu Dudau, Dave Airlie, Alex Deucher,
Daniel Vetter, Sean Paul
On Mon, 28 Jan 2019, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
This is no longer compatible with the v2 changelog below. ;)
I'm biased so this doesn't carry so much value, but here goes anyway,
Acked-by: Jani Nikula <jani.nikula@intel.com>
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
> Validating changes with IGT
> ---------------------------
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
2019-01-28 17:22 ` [igt-dev] " Daniel Vetter
@ 2019-01-29 14:52 ` Brian Starkey
-1 siblings, 0 replies; 14+ messages in thread
From: Brian Starkey @ 2019-01-29 14:52 UTC (permalink / raw)
To: Daniel Vetter
Cc: Petri Latvala, Liviu Dudau, DRI Development, IGT development,
Daniel Vetter, Alex Deucher, Dave Airlie, Arkadiusz Hiler, nd,
Sean Paul
Hi Daniel,
On Mon, Jan 28, 2019 at 06:22:58PM +0100, Daniel Vetter wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
Thank you for the revision and clarification.
Acked-by: Brian Starkey <brian.starkey@arm.com>
> Validating changes with IGT
> ---------------------------
>
> --
> 2.20.1
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
@ 2019-01-29 14:52 ` Brian Starkey
0 siblings, 0 replies; 14+ messages in thread
From: Brian Starkey @ 2019-01-29 14:52 UTC (permalink / raw)
To: Daniel Vetter
Cc: Petri Latvala, Liviu Dudau, DRI Development, IGT development,
Daniel Vetter, Alex Deucher, Dave Airlie, nd, Sean Paul
Hi Daniel,
On Mon, Jan 28, 2019 at 06:22:58PM +0100, Daniel Vetter wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
Thank you for the revision and clarification.
Acked-by: Brian Starkey <brian.starkey@arm.com>
> Validating changes with IGT
> ---------------------------
>
> --
> 2.20.1
>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
2019-01-28 17:22 ` [igt-dev] " Daniel Vetter
` (3 preceding siblings ...)
(?)
@ 2019-01-30 7:00 ` Tomi Valkeinen
-1 siblings, 0 replies; 14+ messages in thread
From: Tomi Valkeinen @ 2019-01-30 7:00 UTC (permalink / raw)
To: Daniel Vetter, DRI Development, IGT development
Cc: Petri Latvala, Liviu Dudau, Dave Airlie, Alex Deucher,
Daniel Vetter, Arkadiusz Hiler, Sean Paul
On 28/01/2019 19:22, Daniel Vetter wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
Acked-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Tomi
--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
2019-01-28 17:22 ` [igt-dev] " Daniel Vetter
` (4 preceding siblings ...)
(?)
@ 2019-02-05 19:10 ` Boris Brezillon
-1 siblings, 0 replies; 14+ messages in thread
From: Boris Brezillon @ 2019-02-05 19:10 UTC (permalink / raw)
To: Daniel Vetter
Cc: Petri Latvala, Liviu Dudau, DRI Development, IGT development,
Dave Airlie, Alex Deucher, Daniel Vetter, Sean Paul
On Mon, 28 Jan 2019 18:22:58 +0100
Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
Acked-by: Boris Brezillon <boris.brezillon@collabora.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst
> b/Documentation/gpu/drm-uapi.rst index a752aa561ea4..c9fd23efd957
> 100644 --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the
> slightly unintuitive meaning of Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new
> KMS +properties, new files in sysfs or anything else that constitutes
> an API change +should have driver-agnostic testcases in IGT for that
> feature, if such a test +can be reasonably made using IGT for the
> target hardware. +
> Validating changes with IGT
> ---------------------------
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
2019-01-28 17:22 ` [igt-dev] " Daniel Vetter
@ 2019-02-05 19:45 ` Alex Deucher
-1 siblings, 0 replies; 14+ messages in thread
From: Alex Deucher @ 2019-02-05 19:45 UTC (permalink / raw)
To: Daniel Vetter
Cc: Petri Latvala, Liviu Dudau, DRI Development, IGT development,
Dave Airlie, Alex Deucher, Daniel Vetter, Arkadiusz Hiler,
Sean Paul
On Mon, Jan 28, 2019 at 12:23 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
> Validating changes with IGT
> ---------------------------
>
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
@ 2019-02-05 19:45 ` Alex Deucher
0 siblings, 0 replies; 14+ messages in thread
From: Alex Deucher @ 2019-02-05 19:45 UTC (permalink / raw)
To: Daniel Vetter
Cc: Petri Latvala, Liviu Dudau, DRI Development, IGT development,
Dave Airlie, Alex Deucher, Daniel Vetter, Sean Paul
On Mon, Jan 28, 2019 at 12:23 PM Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
>
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
Acked-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
> Validating changes with IGT
> ---------------------------
>
> --
> 2.20.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
2019-01-28 17:22 ` [igt-dev] " Daniel Vetter
@ 2019-02-07 10:13 ` Daniel Vetter
-1 siblings, 0 replies; 14+ messages in thread
From: Daniel Vetter @ 2019-02-07 10:13 UTC (permalink / raw)
To: DRI Development, IGT development
Cc: Petri Latvala, Daniel Vetter, Daniel Vetter, Liviu Dudau,
Alex Deucher, Dave Airlie, Arkadiusz Hiler, Sean Paul
On Mon, Jan 28, 2019 at 06:22:58PM +0100, Daniel Vetter wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
With all the additional ones I think we have enough acks, and Dave agreed
that this seems ready to go. Merged into drm-misc-next.
Thanks everyone for helping figuring this out, and if anything pops up,
pls raise it so we can clarify the documentation.
Cheers, Daniel
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
> Validating changes with IGT
> ---------------------------
>
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* Re: [igt-dev] [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested
@ 2019-02-07 10:13 ` Daniel Vetter
0 siblings, 0 replies; 14+ messages in thread
From: Daniel Vetter @ 2019-02-07 10:13 UTC (permalink / raw)
To: DRI Development, IGT development
Cc: Petri Latvala, Daniel Vetter, Liviu Dudau, Alex Deucher,
Dave Airlie, Sean Paul, Brian Starkey
On Mon, Jan 28, 2019 at 06:22:58PM +0100, Daniel Vetter wrote:
> Compared to the RFC[1] no changes to the patch itself, but igt moved
> forward a lot:
>
> - gitlab CI builds with: reduced configs/libraries, arm cross build
> and a sysroot build (should address all the build/cross platform
> concerns raised in the RFC discussions).
>
> - tests reorganized into subdirectories so that the i915-gem tests
> don't clog the main/shared tests directory anymore
>
> - quite a few more non-intel people contributing/reviewing/committing
> igt tests patches.
>
> I think this addresses all the concerns raised in the RFC discussions,
> and assuming there's enough Acks and no new issues that pop up, we can
> go ahead with this.
>
> v2:
> - Use "should" (in the usual RFC sense) to make it clear that in the
> end this is all up to reviewer's discretion, as usual (Jani).
> - Also in the title s/mandatory/strongly suggested/ (me)
> - Make it clear we're not going to block features if a testcase is not
> feasible, given hw and state of igt, both having some good gaps in
> what can be tested (Harry, Eric, Sean, ...).
>
> 1: https://patchwork.kernel.org/patch/10648851/
> Cc: Petri Latvala <petri.latvala@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Cc: Liviu Dudau <liviu.dudau@arm.com>
> Cc: Sean Paul <sean@poorly.run>
> Cc: Eric Anholt <eric@anholt.net>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Dave Airlie <airlied@redhat.com>
> Cc: Daniel Stone <daniel@fooishbar.org>
> Cc: "Wentland, Harry" <Harry.Wentland@amd.com>
> Cc: Brian Starkey <Brian.Starkey@arm.com>
> Reviewed-by: Eric Anholt <eric@anholt.net> (v1)
> Acked-by: Petri Latvala <petri.latvala@intel.com>
> Acked-by: Arkadiusz Hiler <arkadiusz.hiler@intel.com>
> Acked-by: Sean Paul <sean@poorly.run>
> Acked-by: "Wentland, Harry" <Harry.Wentland@amd.com>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
With all the additional ones I think we have enough acks, and Dave agreed
that this seems ready to go. Merged into drm-misc-next.
Thanks everyone for helping figuring this out, and if anything pops up,
pls raise it so we can clarify the documentation.
Cheers, Daniel
> ---
> Documentation/gpu/drm-uapi.rst | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/Documentation/gpu/drm-uapi.rst b/Documentation/gpu/drm-uapi.rst
> index a752aa561ea4..c9fd23efd957 100644
> --- a/Documentation/gpu/drm-uapi.rst
> +++ b/Documentation/gpu/drm-uapi.rst
> @@ -238,6 +238,14 @@ DRM specific patterns. Note that ENOTTY has the slightly unintuitive meaning of
> Testing and validation
> ======================
>
> +Testing Requirements for userspace API
> +--------------------------------------
> +
> +New cross-driver userspace interface extensions, like new IOCTL, new KMS
> +properties, new files in sysfs or anything else that constitutes an API change
> +should have driver-agnostic testcases in IGT for that feature, if such a test
> +can be reasonably made using IGT for the target hardware.
> +
> Validating changes with IGT
> ---------------------------
>
> --
> 2.20.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
^ permalink raw reply [flat|nested] 14+ messages in thread
end of thread, other threads:[~2019-02-07 10:13 UTC | newest]
Thread overview: 14+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-28 17:22 [PATCH] drm/doc: Make igts for cross-driver stuff strongly suggested Daniel Vetter
2019-01-28 17:22 ` [igt-dev] " Daniel Vetter
2019-01-28 17:51 ` Liviu Dudau
2019-01-28 17:51 ` [igt-dev] " Liviu Dudau
2019-01-29 7:27 ` Jani Nikula
2019-01-29 7:27 ` [igt-dev] " Jani Nikula
2019-01-29 14:52 ` Brian Starkey
2019-01-29 14:52 ` [igt-dev] " Brian Starkey
2019-01-30 7:00 ` Tomi Valkeinen
2019-02-05 19:10 ` [igt-dev] " Boris Brezillon
2019-02-05 19:45 ` Alex Deucher
2019-02-05 19:45 ` [igt-dev] " Alex Deucher
2019-02-07 10:13 ` Daniel Vetter
2019-02-07 10:13 ` [igt-dev] " Daniel Vetter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.