* [PATCH] drm/ttm: cleanup unuse ret value
@ 2017-04-17 7:38 Huang Rui
2017-04-17 15:42 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Huang Rui @ 2017-04-17 7:38 UTC (permalink / raw)
To: dri-devel; +Cc: Alex Deucher, Huang Rui
The ret must be 0 here, otherwise, the function will return after init_mem_type.
Signed-off-by: Huang Rui <ray.huang@amd.com>
---
drivers/gpu/drm/ttm/ttm_bo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index 9ee4ff4..5dcb4e1 100644
--- a/drivers/gpu/drm/ttm/ttm_bo.c
+++ b/drivers/gpu/drm/ttm/ttm_bo.c
@@ -1440,7 +1440,6 @@ int ttm_bo_init_mm(struct ttm_bo_device *bdev, unsigned type,
return ret;
man->bdev = bdev;
- ret = 0;
if (type != TTM_PL_SYSTEM) {
ret = (*man->func->init)(man, p_size);
if (ret)
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/ttm: cleanup unuse ret value
2017-04-17 7:38 [PATCH] drm/ttm: cleanup unuse ret value Huang Rui
@ 2017-04-17 15:42 ` Alex Deucher
2017-04-18 1:02 ` Huang Rui
0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2017-04-17 15:42 UTC (permalink / raw)
To: Huang Rui; +Cc: Alex Deucher, Maling list - DRI developers
On Mon, Apr 17, 2017 at 3:38 AM, Huang Rui <ray.huang@amd.com> wrote:
> The ret must be 0 here, otherwise, the function will return after init_mem_type.
>
> Signed-off-by: Huang Rui <ray.huang@amd.com>
I think you can drop the initial assignment of ret as well. Either way:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/ttm/ttm_bo.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
> index 9ee4ff4..5dcb4e1 100644
> --- a/drivers/gpu/drm/ttm/ttm_bo.c
> +++ b/drivers/gpu/drm/ttm/ttm_bo.c
> @@ -1440,7 +1440,6 @@ int ttm_bo_init_mm(struct ttm_bo_device *bdev, unsigned type,
> return ret;
> man->bdev = bdev;
>
> - ret = 0;
> if (type != TTM_PL_SYSTEM) {
> ret = (*man->func->init)(man, p_size);
> if (ret)
> --
> 2.7.4
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/ttm: cleanup unuse ret value
2017-04-17 15:42 ` Alex Deucher
@ 2017-04-18 1:02 ` Huang Rui
0 siblings, 0 replies; 3+ messages in thread
From: Huang Rui @ 2017-04-18 1:02 UTC (permalink / raw)
To: Alex Deucher; +Cc: Deucher, Alexander, Maling list - DRI developers
On Mon, Apr 17, 2017 at 11:42:18PM +0800, Alex Deucher wrote:
> On Mon, Apr 17, 2017 at 3:38 AM, Huang Rui <ray.huang@amd.com> wrote:
> > The ret must be 0 here, otherwise, the function will return after
> init_mem_type.
> >
> > Signed-off-by: Huang Rui <ray.huang@amd.com>
>
> I think you can drop the initial assignment of ret as well. Either way:
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
Yep, we needn't set ret as EINVAL at first, because it must be assigned
before return.
Thanks,
Rui
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-18 1:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-04-17 7:38 [PATCH] drm/ttm: cleanup unuse ret value Huang Rui
2017-04-17 15:42 ` Alex Deucher
2017-04-18 1:02 ` Huang Rui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.