From: Alex Deucher <alexdeucher@gmail.com> To: Lukas Fink <lukas.fink1@gmail.com> Cc: "Deucher, Alexander" <alexander.deucher@amd.com>, Christian Koenig <christian.koenig@amd.com>, xinhui pan <Xinhui.Pan@amd.com>, LKML <linux-kernel@vger.kernel.org>, amd-gfx list <amd-gfx@lists.freedesktop.org> Subject: Re: [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs Date: Fri, 14 Jan 2022 09:58:27 -0500 [thread overview] Message-ID: <CADnq5_OVB-P2dE=ZZRXC2QsL6tFTXbZoaPw3FmK6XHECvZgZZg@mail.gmail.com> (raw) In-Reply-To: <CADnq5_PBt9-x9d9TuW7_0Yrarpmp2bMTdDPXFv2ep=p89sULkg@mail.gmail.com> On Fri, Jan 14, 2022 at 9:56 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > On Fri, Jan 14, 2022 at 3:27 AM Lukas Fink <lukas.fink1@gmail.com> wrote: > > > > eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added > > generic bindings to amdgpu so that that it binds to all display class devices > > with VID 0x1002 and then rejects those in amdgpu_pci_probe. > > > > Unfortunately it reuses a driver_data value of 0 to detect those new bindings, > > which is already used to denote CHIP_TAHITI ASICs. > > > > The driver_data value given to those new bindings was changed in > > dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default") > > to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe > > was forgotten to be changed. Therefore, it still rejects Tahiti GPUs. > > > > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860 > > Fixes: eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") > > > > Signed-off-by: Lukas Fink <lukas.fink1@gmail.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > index 9ec58bf74012..224d073022ac 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > @@ -1903,7 +1903,7 @@ static int amdgpu_pci_probe(struct pci_dev *pdev, > > return -ENODEV; > > } > > > > - if (flags == 0) { > > + if (flags == CHIP_IP_DISCOVERY) { > > DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n"); > > return -ENODEV; > > } > > Thanks. Actually this entire check can be removed at this point. The > IP discovery support is in place. I'll send a patch. Actually, I'll take this patch and then send a patch to remove it on top of that. Thanks for fixing this. Alex > > Alex > > > > -- > > 2.34.1 > >
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com> To: Lukas Fink <lukas.fink1@gmail.com> Cc: "Deucher, Alexander" <alexander.deucher@amd.com>, xinhui pan <Xinhui.Pan@amd.com>, Christian Koenig <christian.koenig@amd.com>, amd-gfx list <amd-gfx@lists.freedesktop.org>, LKML <linux-kernel@vger.kernel.org> Subject: Re: [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs Date: Fri, 14 Jan 2022 09:58:27 -0500 [thread overview] Message-ID: <CADnq5_OVB-P2dE=ZZRXC2QsL6tFTXbZoaPw3FmK6XHECvZgZZg@mail.gmail.com> (raw) In-Reply-To: <CADnq5_PBt9-x9d9TuW7_0Yrarpmp2bMTdDPXFv2ep=p89sULkg@mail.gmail.com> On Fri, Jan 14, 2022 at 9:56 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > On Fri, Jan 14, 2022 at 3:27 AM Lukas Fink <lukas.fink1@gmail.com> wrote: > > > > eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") added > > generic bindings to amdgpu so that that it binds to all display class devices > > with VID 0x1002 and then rejects those in amdgpu_pci_probe. > > > > Unfortunately it reuses a driver_data value of 0 to detect those new bindings, > > which is already used to denote CHIP_TAHITI ASICs. > > > > The driver_data value given to those new bindings was changed in > > dd0761fd24ea1 ("drm/amdgpu: set CHIP_IP_DISCOVERY as the asic type by default") > > to CHIP_IP_DISCOVERY (=36), but it seems that the check in amdgpu_pci_probe > > was forgotten to be changed. Therefore, it still rejects Tahiti GPUs. > > > > Link: https://gitlab.freedesktop.org/drm/amd/-/issues/1860 > > Fixes: eb4fd29afd4a ("drm/amdgpu: bind to any 0x1002 PCI diplay class device") > > > > Signed-off-by: Lukas Fink <lukas.fink1@gmail.com> > > --- > > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > index 9ec58bf74012..224d073022ac 100644 > > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > > @@ -1903,7 +1903,7 @@ static int amdgpu_pci_probe(struct pci_dev *pdev, > > return -ENODEV; > > } > > > > - if (flags == 0) { > > + if (flags == CHIP_IP_DISCOVERY) { > > DRM_INFO("Unsupported asic. Remove me when IP discovery init is in place.\n"); > > return -ENODEV; > > } > > Thanks. Actually this entire check can be removed at this point. The > IP discovery support is in place. I'll send a patch. Actually, I'll take this patch and then send a patch to remove it on top of that. Thanks for fixing this. Alex > > Alex > > > > -- > > 2.34.1 > >
next prev parent reply other threads:[~2022-01-14 14:58 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-01-14 6:51 [PATCH] drm/amdgpu: Fix rejecting Tahiti GPUs Lukas Fink 2022-01-14 6:51 ` Lukas Fink 2022-01-14 14:56 ` Alex Deucher 2022-01-14 14:56 ` Alex Deucher 2022-01-14 14:58 ` Alex Deucher [this message] 2022-01-14 14:58 ` Alex Deucher
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADnq5_OVB-P2dE=ZZRXC2QsL6tFTXbZoaPw3FmK6XHECvZgZZg@mail.gmail.com' \ --to=alexdeucher@gmail.com \ --cc=Xinhui.Pan@amd.com \ --cc=alexander.deucher@amd.com \ --cc=amd-gfx@lists.freedesktop.org \ --cc=christian.koenig@amd.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lukas.fink1@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.