From: Alex Deucher <alexdeucher@gmail.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: "Wentland, Harry" <harry.wentland@amd.com>,
"Leo (Sunpeng) Li" <sunpeng.li@amd.com>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
Dave Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
"Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>,
"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
Stylon Wang <stylon.wang@amd.com>, Roman Li <roman.li@amd.com>,
"Lipski, Mikita" <mikita.lipski@amd.com>,
tianjia.zhang@alibaba.com,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/amd/display: Fix wrong return value in dm_update_plane_state()
Date: Tue, 4 Aug 2020 18:19:58 -0400 [thread overview]
Message-ID: <CADnq5_ObopJHTDfoLHunJGakLNgxLwwfo-g53HCDP=fis+E+iQ@mail.gmail.com> (raw)
In-Reply-To: <20200802111536.5246-1-tianjia.zhang@linux.alibaba.com>
On Mon, Aug 3, 2020 at 4:21 AM Tianjia Zhang
<tianjia.zhang@linux.alibaba.com> wrote:
>
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
>
> Fixes: 9e869063b0021 ("drm/amd/display: Move iteration out of dm_update_planes")
> Cc: Leo Li <sunpeng.li@amd.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 710edc70e37e..5810416e2ddc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -8182,8 +8182,7 @@ static int dm_update_plane_state(struct dc *dc,
> dm_old_plane_state->dc_state,
> dm_state->context)) {
>
> - ret = EINVAL;
> - return ret;
> + return -EINVAL;
> }
>
>
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: Stylon Wang <stylon.wang@amd.com>,
tianjia.zhang@alibaba.com,
"Leo \(Sunpeng\) Li" <sunpeng.li@amd.com>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
Roman Li <roman.li@amd.com>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
"Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>,
Dave Airlie <airlied@linux.ie>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
"Lipski, Mikita" <mikita.lipski@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/amd/display: Fix wrong return value in dm_update_plane_state()
Date: Tue, 4 Aug 2020 18:19:58 -0400 [thread overview]
Message-ID: <CADnq5_ObopJHTDfoLHunJGakLNgxLwwfo-g53HCDP=fis+E+iQ@mail.gmail.com> (raw)
In-Reply-To: <20200802111536.5246-1-tianjia.zhang@linux.alibaba.com>
On Mon, Aug 3, 2020 at 4:21 AM Tianjia Zhang
<tianjia.zhang@linux.alibaba.com> wrote:
>
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
>
> Fixes: 9e869063b0021 ("drm/amd/display: Move iteration out of dm_update_planes")
> Cc: Leo Li <sunpeng.li@amd.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 710edc70e37e..5810416e2ddc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -8182,8 +8182,7 @@ static int dm_update_plane_state(struct dc *dc,
> dm_old_plane_state->dc_state,
> dm_state->context)) {
>
> - ret = EINVAL;
> - return ret;
> + return -EINVAL;
> }
>
>
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Cc: Stylon Wang <stylon.wang@amd.com>,
tianjia.zhang@alibaba.com,
"Leo \(Sunpeng\) Li" <sunpeng.li@amd.com>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>,
"Siqueira, Rodrigo" <Rodrigo.Siqueira@amd.com>,
Roman Li <roman.li@amd.com>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
"Kazlauskas, Nicholas" <nicholas.kazlauskas@amd.com>,
Dave Airlie <airlied@linux.ie>,
amd-gfx list <amd-gfx@lists.freedesktop.org>,
Daniel Vetter <daniel@ffwll.ch>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
"Lipski, Mikita" <mikita.lipski@amd.com>,
"Wentland, Harry" <harry.wentland@amd.com>,
Christian Koenig <christian.koenig@amd.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/amd/display: Fix wrong return value in dm_update_plane_state()
Date: Tue, 4 Aug 2020 18:19:58 -0400 [thread overview]
Message-ID: <CADnq5_ObopJHTDfoLHunJGakLNgxLwwfo-g53HCDP=fis+E+iQ@mail.gmail.com> (raw)
In-Reply-To: <20200802111536.5246-1-tianjia.zhang@linux.alibaba.com>
On Mon, Aug 3, 2020 at 4:21 AM Tianjia Zhang
<tianjia.zhang@linux.alibaba.com> wrote:
>
> On an error exit path, a negative error code should be returned
> instead of a positive return value.
>
> Fixes: 9e869063b0021 ("drm/amd/display: Move iteration out of dm_update_planes")
> Cc: Leo Li <sunpeng.li@amd.com>
> Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Applied. Thanks!
Alex
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 710edc70e37e..5810416e2ddc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -8182,8 +8182,7 @@ static int dm_update_plane_state(struct dc *dc,
> dm_old_plane_state->dc_state,
> dm_state->context)) {
>
> - ret = EINVAL;
> - return ret;
> + return -EINVAL;
> }
>
>
> --
> 2.26.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
next prev parent reply other threads:[~2020-08-04 22:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-02 11:15 [PATCH] drm/amd/display: Fix wrong return value in dm_update_plane_state() Tianjia Zhang
2020-08-02 11:15 ` Tianjia Zhang
2020-08-02 11:15 ` Tianjia Zhang
2020-08-04 22:19 ` Alex Deucher [this message]
2020-08-04 22:19 ` Alex Deucher
2020-08-04 22:19 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_ObopJHTDfoLHunJGakLNgxLwwfo-g53HCDP=fis+E+iQ@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mikita.lipski@amd.com \
--cc=nicholas.kazlauskas@amd.com \
--cc=roman.li@amd.com \
--cc=stylon.wang@amd.com \
--cc=sunpeng.li@amd.com \
--cc=tianjia.zhang@alibaba.com \
--cc=tianjia.zhang@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.