From: Alex Deucher <alexdeucher@gmail.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: "Dave Airlie" <airlied@linux.ie>,
"Deucher, Alexander" <alexander.deucher@amd.com>,
"Christian Koenig" <christian.koenig@amd.com>,
"Zhou, Jammy" <Jammy.Zhou@amd.com>, yanyang1 <young.yang@amd.com>,
"Li, Samuel" <samuel.li@amd.com>,
"Marek Olšák" <marek.olsak@amd.com>,
"Maling list - DRI developers" <dri-devel@lists.freedesktop.org>,
LKML <linux-kernel@vger.kernel.org>,
pankaj.m@samsung.com
Subject: Re: [PATCH v2] drm/amdgpu: remove unnecessary check before kfree
Date: Fri, 26 Jun 2015 13:01:24 -0400 [thread overview]
Message-ID: <CADnq5_Of_+3qvZKnBUqexGHfNJxWGmEFJ+MXxhhpv-veLXYCbA@mail.gmail.com> (raw)
In-Reply-To: <1435305417-3276-1-git-send-email-maninder1.s@samsung.com>
On Fri, Jun 26, 2015 at 3:56 AM, Maninder Singh <maninder1.s@samsung.com> wrote:
> kfree(NULL) is safe and this check is probably not required
>
> Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
> Reviewed-by: Vaneet Narang <v.narang@samsung.com>
> Reviewed-by: Christian Konig <christian.koenig@amd.com>
Applied. thanks!
Alex
> ---
> v2: Chnged shortlog prefix - gpu/amdgpu
>
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..a85cd08 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -1575,8 +1575,7 @@ void amdgpu_device_fini(struct amdgpu_device *adev)
> amdgpu_fence_driver_fini(adev);
> amdgpu_fbdev_fini(adev);
> r = amdgpu_fini(adev);
> - if (adev->ip_block_enabled)
> - kfree(adev->ip_block_enabled);
> + kfree(adev->ip_block_enabled);
> adev->ip_block_enabled = NULL;
> adev->accel_working = false;
> /* free i2c buses */
> --
> 1.7.9.5
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2015-06-26 17:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-26 7:56 [PATCH v2] drm/amdgpu: remove unnecessary check before kfree Maninder Singh
2015-06-26 7:56 ` Maninder Singh
2015-06-26 17:01 ` Alex Deucher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CADnq5_Of_+3qvZKnBUqexGHfNJxWGmEFJ+MXxhhpv-veLXYCbA@mail.gmail.com \
--to=alexdeucher@gmail.com \
--cc=Jammy.Zhou@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maninder1.s@samsung.com \
--cc=marek.olsak@amd.com \
--cc=pankaj.m@samsung.com \
--cc=samuel.li@amd.com \
--cc=young.yang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.