* Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
2021-06-29 11:44 ` Jing Xiangfeng
(?)
@ 2021-06-29 11:42 ` Christian König
-1 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2021-06-29 11:42 UTC (permalink / raw)
To: Jing Xiangfeng, alexander.deucher, airlied, daniel
Cc: amd-gfx, dri-devel, linux-kernel
Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> an error path. Add the missed function call to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
I'm pretty sure that I already reviewed the same patch a few weeks ago,
but it looks like it never went upstream.
Reviewed-by: Christian König <christian.koenig@amd.com>
Maybe add CC: stable as well?
Regards,
Christian.
> ---
> drivers/gpu/drm/radeon/radeon_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 652af7a134bd..1d03ec763604 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
> if (obj->import_attach) {
> DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> + drm_gem_object_put(obj);
> return ERR_PTR(-EINVAL);
> }
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
@ 2021-06-29 11:42 ` Christian König
0 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2021-06-29 11:42 UTC (permalink / raw)
To: Jing Xiangfeng, alexander.deucher, airlied, daniel
Cc: dri-devel, amd-gfx, linux-kernel
Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> an error path. Add the missed function call to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
I'm pretty sure that I already reviewed the same patch a few weeks ago,
but it looks like it never went upstream.
Reviewed-by: Christian König <christian.koenig@amd.com>
Maybe add CC: stable as well?
Regards,
Christian.
> ---
> drivers/gpu/drm/radeon/radeon_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 652af7a134bd..1d03ec763604 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
> if (obj->import_attach) {
> DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> + drm_gem_object_put(obj);
> return ERR_PTR(-EINVAL);
> }
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
@ 2021-06-29 11:42 ` Christian König
0 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2021-06-29 11:42 UTC (permalink / raw)
To: Jing Xiangfeng, alexander.deucher, airlied, daniel
Cc: dri-devel, amd-gfx, linux-kernel
Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> an error path. Add the missed function call to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
I'm pretty sure that I already reviewed the same patch a few weeks ago,
but it looks like it never went upstream.
Reviewed-by: Christian König <christian.koenig@amd.com>
Maybe add CC: stable as well?
Regards,
Christian.
> ---
> drivers/gpu/drm/radeon/radeon_display.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 652af7a134bd..1d03ec763604 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
> if (obj->import_attach) {
> DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> + drm_gem_object_put(obj);
> return ERR_PTR(-EINVAL);
> }
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
@ 2021-06-29 11:44 ` Jing Xiangfeng
0 siblings, 0 replies; 9+ messages in thread
From: Jing Xiangfeng @ 2021-06-29 11:44 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel
Cc: amd-gfx, dri-devel, linux-kernel, jingxiangfeng
radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
an error path. Add the missed function call to fix it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/gpu/drm/radeon/radeon_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 652af7a134bd..1d03ec763604 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
/* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
if (obj->import_attach) {
DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
+ drm_gem_object_put(obj);
return ERR_PTR(-EINVAL);
}
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
@ 2021-06-29 11:44 ` Jing Xiangfeng
0 siblings, 0 replies; 9+ messages in thread
From: Jing Xiangfeng @ 2021-06-29 11:44 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel
Cc: jingxiangfeng, dri-devel, amd-gfx, linux-kernel
radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
an error path. Add the missed function call to fix it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/gpu/drm/radeon/radeon_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 652af7a134bd..1d03ec763604 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
/* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
if (obj->import_attach) {
DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
+ drm_gem_object_put(obj);
return ERR_PTR(-EINVAL);
}
--
2.26.0.106.g9fadedd
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
@ 2021-06-29 11:44 ` Jing Xiangfeng
0 siblings, 0 replies; 9+ messages in thread
From: Jing Xiangfeng @ 2021-06-29 11:44 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, airlied, daniel
Cc: jingxiangfeng, dri-devel, amd-gfx, linux-kernel
radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
an error path. Add the missed function call to fix it.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/gpu/drm/radeon/radeon_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
index 652af7a134bd..1d03ec763604 100644
--- a/drivers/gpu/drm/radeon/radeon_display.c
+++ b/drivers/gpu/drm/radeon/radeon_display.c
@@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
/* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
if (obj->import_attach) {
DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
+ drm_gem_object_put(obj);
return ERR_PTR(-EINVAL);
}
--
2.26.0.106.g9fadedd
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
2021-06-29 11:42 ` Christian König
(?)
@ 2021-06-29 14:17 ` Alex Deucher
-1 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-06-29 14:17 UTC (permalink / raw)
To: Christian König
Cc: Jing Xiangfeng, Deucher, Alexander, Dave Airlie, Daniel Vetter,
Maling list - DRI developers, amd-gfx list, LKML
Applied. Thanks!
Alex
On Tue, Jun 29, 2021 at 7:42 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> > radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> > an error path. Add the missed function call to fix it.
> >
> > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
>
> I'm pretty sure that I already reviewed the same patch a few weeks ago,
> but it looks like it never went upstream.
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Maybe add CC: stable as well?
>
> Regards,
> Christian.
>
> > ---
> > drivers/gpu/drm/radeon/radeon_display.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> > index 652af7a134bd..1d03ec763604 100644
> > --- a/drivers/gpu/drm/radeon/radeon_display.c
> > +++ b/drivers/gpu/drm/radeon/radeon_display.c
> > @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> > /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
> > if (obj->import_attach) {
> > DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> > + drm_gem_object_put(obj);
> > return ERR_PTR(-EINVAL);
> > }
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
@ 2021-06-29 14:17 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-06-29 14:17 UTC (permalink / raw)
To: Christian König
Cc: Dave Airlie, LKML, amd-gfx list, Jing Xiangfeng,
Maling list - DRI developers, Deucher, Alexander
Applied. Thanks!
Alex
On Tue, Jun 29, 2021 at 7:42 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> > radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> > an error path. Add the missed function call to fix it.
> >
> > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
>
> I'm pretty sure that I already reviewed the same patch a few weeks ago,
> but it looks like it never went upstream.
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Maybe add CC: stable as well?
>
> Regards,
> Christian.
>
> > ---
> > drivers/gpu/drm/radeon/radeon_display.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> > index 652af7a134bd..1d03ec763604 100644
> > --- a/drivers/gpu/drm/radeon/radeon_display.c
> > +++ b/drivers/gpu/drm/radeon/radeon_display.c
> > @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> > /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
> > if (obj->import_attach) {
> > DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> > + drm_gem_object_put(obj);
> > return ERR_PTR(-EINVAL);
> > }
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create()
@ 2021-06-29 14:17 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-06-29 14:17 UTC (permalink / raw)
To: Christian König
Cc: Dave Airlie, LKML, amd-gfx list, Jing Xiangfeng,
Maling list - DRI developers, Daniel Vetter, Deucher, Alexander
Applied. Thanks!
Alex
On Tue, Jun 29, 2021 at 7:42 AM Christian König
<christian.koenig@amd.com> wrote:
>
> Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> > radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> > an error path. Add the missed function call to fix it.
> >
> > Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
>
> I'm pretty sure that I already reviewed the same patch a few weeks ago,
> but it looks like it never went upstream.
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Maybe add CC: stable as well?
>
> Regards,
> Christian.
>
> > ---
> > drivers/gpu/drm/radeon/radeon_display.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> > index 652af7a134bd..1d03ec763604 100644
> > --- a/drivers/gpu/drm/radeon/radeon_display.c
> > +++ b/drivers/gpu/drm/radeon/radeon_display.c
> > @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
> > /* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
> > if (obj->import_attach) {
> > DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> > + drm_gem_object_put(obj);
> > return ERR_PTR(-EINVAL);
> > }
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-06-29 14:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-29 11:44 [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer_create() Jing Xiangfeng
2021-06-29 11:44 ` Jing Xiangfeng
2021-06-29 11:44 ` Jing Xiangfeng
2021-06-29 11:42 ` Christian König
2021-06-29 11:42 ` Christian König
2021-06-29 11:42 ` Christian König
2021-06-29 14:17 ` Alex Deucher
2021-06-29 14:17 ` Alex Deucher
2021-06-29 14:17 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.