[PATCH] amdgpu/powerplay: constify large struct

[PATCH] amdgpu/powerplay: constify large struct

[Dave Airlie]

From: Dave Airlie <airlied@redhat.com>

This moves this from being global data to global rodata, I'm
sure it would be easy to move it to being local data.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c | 4 ++--
 drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c
index d09f254..34fdf1a 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c
@@ -1,7 +1,7 @@
 #include "pp_overdriver.h"
 #include <linux/errno.h>
 
-struct phm_fuses_default vega10_fuses_default[] = {
+const struct phm_fuses_default vega10_fuses_default[] = {
 	{"0000001000010011111010101001010011011110000011100100100101100100",0x00003C96,0xFFFFE226,0x00000656,0x00002203,0xFFFFF201,0x000003FF,0x00002203,0xFFFFF201,0x000003FF},
 	{"0000001000010011111010101001010011011110000010100001100010000100",0x00003CC5,0xFFFFE23A,0x0000064E,0x00002258,0xFFFFF1F7,0x000003FC,0x00002258,0xFFFFF1F7,0x000003FC},
 	{"0000001000010011111010101001010011011110000011100011000110100100",0x00003CAF,0xFFFFE36E,0x00000602,0x00001E98,0xFFFFF569,0x00000357,0x00001E98,0xFFFFF569,0x00000357},
@@ -1240,7 +1240,7 @@ struct phm_fuses_default vega10_fuses_default[] = {
 };
 
 int pp_override_get_default_fuse_value(uint64_t key,
-			struct phm_fuses_default list[],
+			const struct phm_fuses_default list[],
 			struct phm_fuses_default *result)
 {
 	uint32_t i;
diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h
index 6e8f7a2..133745f 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h
@@ -40,9 +40,9 @@ struct phm_fuses_default {
 	uint32_t VFT0_b;
 };
 
-extern struct phm_fuses_default vega10_fuses_default[];
+extern const struct phm_fuses_default vega10_fuses_default[];
 extern int pp_override_get_default_fuse_value(uint64_t key,
-			struct phm_fuses_default list[],
+			const struct phm_fuses_default list[],
 			struct phm_fuses_default *result);
 
 #endif
\ No newline at end of file
-- 
2.9.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] amdgpu/powerplay: constify large struct

[Alex Deucher]

On Wed, Sep 27, 2017 at 4:45 PM, Dave Airlie <airlied@gmail.com> wrote:
> From: Dave Airlie <airlied@redhat.com>
>
> This moves this from being global data to global rodata, I'm
> sure it would be easy to move it to being local data.
>
> Signed-off-by: Dave Airlie <airlied@redhat.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c | 4 ++--
>  drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c
> index d09f254..34fdf1a 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.c
> @@ -1,7 +1,7 @@
>  #include "pp_overdriver.h"
>  #include <linux/errno.h>
>
> -struct phm_fuses_default vega10_fuses_default[] = {
> +const struct phm_fuses_default vega10_fuses_default[] = {
>         {"0000001000010011111010101001010011011110000011100100100101100100",0x00003C96,0xFFFFE226,0x00000656,0x00002203,0xFFFFF201,0x000003FF,0x00002203,0xFFFFF201,0x000003FF},
>         {"0000001000010011111010101001010011011110000010100001100010000100",0x00003CC5,0xFFFFE23A,0x0000064E,0x00002258,0xFFFFF1F7,0x000003FC,0x00002258,0xFFFFF1F7,0x000003FC},
>         {"0000001000010011111010101001010011011110000011100011000110100100",0x00003CAF,0xFFFFE36E,0x00000602,0x00001E98,0xFFFFF569,0x00000357,0x00001E98,0xFFFFF569,0x00000357},
> @@ -1240,7 +1240,7 @@ struct phm_fuses_default vega10_fuses_default[] = {
>  };
>
>  int pp_override_get_default_fuse_value(uint64_t key,
> -                       struct phm_fuses_default list[],
> +                       const struct phm_fuses_default list[],
>                         struct phm_fuses_default *result)
>  {
>         uint32_t i;
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h
> index 6e8f7a2..133745f 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_overdriver.h
> @@ -40,9 +40,9 @@ struct phm_fuses_default {
>         uint32_t VFT0_b;
>  };
>
> -extern struct phm_fuses_default vega10_fuses_default[];
> +extern const struct phm_fuses_default vega10_fuses_default[];
>  extern int pp_override_get_default_fuse_value(uint64_t key,
> -                       struct phm_fuses_default list[],
> +                       const struct phm_fuses_default list[],
>                         struct phm_fuses_default *result);
>
>  #endif
> \ No newline at end of file
> --
> 2.9.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx