* [PATCH 1/1] drm/powerplay: fix compilation warning
@ 2020-06-22 19:56 Nirmoy Das
2020-06-22 20:09 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Nirmoy Das @ 2020-06-22 19:56 UTC (permalink / raw)
To: amd-gfx; +Cc: nirmoy.das
If (smu)->ppt_funcs->intf is not initialized then
smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumBottom32, &bottom32) and
smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumTop32, &top32) will not
touch bottom32 and top32.
Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
---
drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
index b27d0b18eafa..d93f8a43a96f 100644
--- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
@@ -2371,7 +2371,7 @@ static void arcturus_i2c_eeprom_control_fini(struct smu_context *smu, struct i2c
static void arcturus_get_unique_id(struct smu_context *smu)
{
struct amdgpu_device *adev = smu->adev;
- uint32_t top32, bottom32, smu_version;
+ uint32_t top32 = 0, bottom32 = 0, smu_version;
uint64_t id;
if (smu_get_smc_version(smu, NULL, &smu_version)) {
--
2.27.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] drm/powerplay: fix compilation warning
2020-06-22 19:56 [PATCH 1/1] drm/powerplay: fix compilation warning Nirmoy Das
@ 2020-06-22 20:09 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2020-06-22 20:09 UTC (permalink / raw)
To: Nirmoy Das; +Cc: Nirmoy Das, amd-gfx list
On Mon, Jun 22, 2020 at 3:55 PM Nirmoy Das <nirmoy.aiemd@gmail.com> wrote:
>
> If (smu)->ppt_funcs->intf is not initialized then
> smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumBottom32, &bottom32) and
> smu_send_smc_msg(smu, SMU_MSG_ReadSerialNumTop32, &top32) will not
> touch bottom32 and top32.
>
> Signed-off-by: Nirmoy Das <nirmoy.das@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> index b27d0b18eafa..d93f8a43a96f 100644
> --- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> +++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
> @@ -2371,7 +2371,7 @@ static void arcturus_i2c_eeprom_control_fini(struct smu_context *smu, struct i2c
> static void arcturus_get_unique_id(struct smu_context *smu)
> {
> struct amdgpu_device *adev = smu->adev;
> - uint32_t top32, bottom32, smu_version;
> + uint32_t top32 = 0, bottom32 = 0, smu_version;
> uint64_t id;
>
> if (smu_get_smc_version(smu, NULL, &smu_version)) {
> --
> 2.27.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-22 20:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-22 19:56 [PATCH 1/1] drm/powerplay: fix compilation warning Nirmoy Das
2020-06-22 20:09 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.