* [PATCH] Revert "drm/amdgpu/vpe: don't emit cond exec command under collaborate mode"
@ 2024-03-18 10:38 Lang Yu
2024-03-18 13:43 ` Alex Deucher
0 siblings, 1 reply; 2+ messages in thread
From: Lang Yu @ 2024-03-18 10:38 UTC (permalink / raw)
To: amd-gfx; +Cc: Alex Deucher, Lee Peyton, Alan Liu, Yifan Zhang, Lang Yu
Ready now. Remove this workaround.
This reverts commit 1a2bb3bb2a84f8364f0a8b338afa9b9025e1bcc0.
Signed-off-by: Lang Yu <Lang.Yu@amd.com>
Tested-by: Alan Liu <haoping.liu@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
index 70c5cc80ecdc..7a65a2b128ec 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
@@ -575,9 +575,6 @@ static unsigned int vpe_ring_init_cond_exec(struct amdgpu_ring *ring,
{
unsigned int ret;
- if (ring->adev->vpe.collaborate_mode)
- return ~0;
-
amdgpu_ring_write(ring, VPE_CMD_HEADER(VPE_CMD_OPCODE_COND_EXE, 0));
amdgpu_ring_write(ring, lower_32_bits(addr));
amdgpu_ring_write(ring, upper_32_bits(addr));
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] Revert "drm/amdgpu/vpe: don't emit cond exec command under collaborate mode"
2024-03-18 10:38 [PATCH] Revert "drm/amdgpu/vpe: don't emit cond exec command under collaborate mode" Lang Yu
@ 2024-03-18 13:43 ` Alex Deucher
0 siblings, 0 replies; 2+ messages in thread
From: Alex Deucher @ 2024-03-18 13:43 UTC (permalink / raw)
To: Lang Yu; +Cc: amd-gfx, Alex Deucher, Lee Peyton, Alan Liu, Yifan Zhang
Acked-by: Alex Deucher <alexander.deucher@amd.com>
On Mon, Mar 18, 2024 at 6:38 AM Lang Yu <Lang.Yu@amd.com> wrote:
>
> Ready now. Remove this workaround.
> This reverts commit 1a2bb3bb2a84f8364f0a8b338afa9b9025e1bcc0.
>
> Signed-off-by: Lang Yu <Lang.Yu@amd.com>
> Tested-by: Alan Liu <haoping.liu@amd.com>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> index 70c5cc80ecdc..7a65a2b128ec 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vpe.c
> @@ -575,9 +575,6 @@ static unsigned int vpe_ring_init_cond_exec(struct amdgpu_ring *ring,
> {
> unsigned int ret;
>
> - if (ring->adev->vpe.collaborate_mode)
> - return ~0;
> -
> amdgpu_ring_write(ring, VPE_CMD_HEADER(VPE_CMD_OPCODE_COND_EXE, 0));
> amdgpu_ring_write(ring, lower_32_bits(addr));
> amdgpu_ring_write(ring, upper_32_bits(addr));
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-18 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-18 10:38 [PATCH] Revert "drm/amdgpu/vpe: don't emit cond exec command under collaborate mode" Lang Yu
2024-03-18 13:43 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.