* [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer()
@ 2021-09-30 16:23 Nathan Chancellor
2021-09-30 17:09 ` Alex Deucher
0 siblings, 1 reply; 8+ messages in thread
From: Nathan Chancellor @ 2021-09-30 16:23 UTC (permalink / raw)
To: Harry Wentland, Leo Li, Alex Deucher, Christian König, Pan, Xinhui
Cc: Nick Desaulniers, amd-gfx, dri-devel, linux-kernel, llvm,
Nathan Chancellor
Clang warns:
drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_resource.c:1017:10: error: expression which evaluates to zero treated as a null pointer constant of type 'struct pipe_ctx *' [-Werror,-Wnon-literal-null-conversion]
return false;
^~~~~
1 error generated.
Use NULL instead of false since the function is returning a pointer
rather than a boolean.
Fixes: ff7e396f822f ("drm/amd/display: add cyan_skillfish display support")
Link: https://github.com/ClangBuiltLinux/linux/issues/1470
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
---
drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c
index aec276e1db65..8523a048e6f6 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c
@@ -1014,7 +1014,7 @@ static struct pipe_ctx *dcn201_acquire_idle_pipe_for_layer(
ASSERT(0);
if (!idle_pipe)
- return false;
+ return NULL;
idle_pipe->stream = head_pipe->stream;
idle_pipe->stream_res.tg = head_pipe->stream_res.tg;
base-commit: b47b99e30cca8906753c83205e8c6179045dd725
--
2.33.0.591.gddb1055343
^ permalink raw reply related [flat|nested] 8+ messages in thread* Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer() 2021-09-30 16:23 [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer() Nathan Chancellor @ 2021-09-30 17:09 ` Alex Deucher 2021-09-30 17:22 ` Nick Desaulniers 0 siblings, 1 reply; 8+ messages in thread From: Alex Deucher @ 2021-09-30 17:09 UTC (permalink / raw) To: Nathan Chancellor Cc: Harry Wentland, Leo Li, Alex Deucher, Christian König, Pan, Xinhui, Nick Desaulniers, amd-gfx list, Maling list - DRI developers, LKML, llvm Applied. Thanks! Alex On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor <nathan@kernel.org> wrote: > > Clang warns: > > drivers/gpu/drm/amd/amdgpu/../display/dc/dcn201/dcn201_resource.c:1017:10: error: expression which evaluates to zero treated as a null pointer constant of type 'struct pipe_ctx *' [-Werror,-Wnon-literal-null-conversion] > return false; > ^~~~~ > 1 error generated. > > Use NULL instead of false since the function is returning a pointer > rather than a boolean. > > Fixes: ff7e396f822f ("drm/amd/display: add cyan_skillfish display support") > Link: https://github.com/ClangBuiltLinux/linux/issues/1470 > Signed-off-by: Nathan Chancellor <nathan@kernel.org> > --- > drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c > index aec276e1db65..8523a048e6f6 100644 > --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c > +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c > @@ -1014,7 +1014,7 @@ static struct pipe_ctx *dcn201_acquire_idle_pipe_for_layer( > ASSERT(0); > > if (!idle_pipe) > - return false; > + return NULL; > > idle_pipe->stream = head_pipe->stream; > idle_pipe->stream_res.tg = head_pipe->stream_res.tg; > > base-commit: b47b99e30cca8906753c83205e8c6179045dd725 > -- > 2.33.0.591.gddb1055343 > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer() 2021-09-30 17:09 ` Alex Deucher 2021-09-30 17:22 ` Nick Desaulniers @ 2021-09-30 17:22 ` Nick Desaulniers 0 siblings, 0 replies; 8+ messages in thread From: Nick Desaulniers @ 2021-09-30 17:22 UTC (permalink / raw) To: Alex Deucher, Deucher, Alexander, Koenig, Christian, Pan, Xinhui Cc: Nathan Chancellor, Harry Wentland, Leo Li, amd-gfx list, Maling list - DRI developers, LKML, llvm On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > Applied. Thanks! > > Alex > > On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor <nathan@kernel.org> wrote: > > > > Clang warns: Any chance AMDGPU folks can look into adding clang to the CI roster? -- Thanks, ~Nick Desaulniers ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer() @ 2021-09-30 17:22 ` Nick Desaulniers 0 siblings, 0 replies; 8+ messages in thread From: Nick Desaulniers @ 2021-09-30 17:22 UTC (permalink / raw) To: Alex Deucher, Deucher, Alexander, Koenig, Christian, Pan, Xinhui Cc: Nathan Chancellor, Harry Wentland, Leo Li, amd-gfx list, Maling list - DRI developers, LKML, llvm On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > Applied. Thanks! > > Alex > > On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor <nathan@kernel.org> wrote: > > > > Clang warns: Any chance AMDGPU folks can look into adding clang to the CI roster? -- Thanks, ~Nick Desaulniers ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer() @ 2021-09-30 17:22 ` Nick Desaulniers 0 siblings, 0 replies; 8+ messages in thread From: Nick Desaulniers @ 2021-09-30 17:22 UTC (permalink / raw) To: Alex Deucher, Deucher, Alexander, Koenig, Christian, Pan, Xinhui Cc: Nathan Chancellor, Harry Wentland, Leo Li, amd-gfx list, Maling list - DRI developers, LKML, llvm On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > Applied. Thanks! > > Alex > > On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor <nathan@kernel.org> wrote: > > > > Clang warns: Any chance AMDGPU folks can look into adding clang to the CI roster? -- Thanks, ~Nick Desaulniers ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer() 2021-09-30 17:22 ` Nick Desaulniers (?) @ 2021-09-30 17:59 ` Alex Deucher -1 siblings, 0 replies; 8+ messages in thread From: Alex Deucher @ 2021-09-30 17:59 UTC (permalink / raw) To: Nick Desaulniers Cc: Deucher, Alexander, Koenig, Christian, Pan, Xinhui, Nathan Chancellor, Harry Wentland, Leo Li, amd-gfx list, Maling list - DRI developers, LKML, llvm On Thu, Sep 30, 2021 at 1:23 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > > > Applied. Thanks! > > > > Alex > > > > On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor <nathan@kernel.org> wrote: > > > > > > Clang warns: > > Any chance AMDGPU folks can look into adding clang to the CI roster? We can look into it. We may already be doing it for some groups. Alex > -- > Thanks, > ~Nick Desaulniers ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer() @ 2021-09-30 17:59 ` Alex Deucher 0 siblings, 0 replies; 8+ messages in thread From: Alex Deucher @ 2021-09-30 17:59 UTC (permalink / raw) To: Nick Desaulniers Cc: Deucher, Alexander, Koenig, Christian, Pan, Xinhui, Nathan Chancellor, Harry Wentland, Leo Li, amd-gfx list, Maling list - DRI developers, LKML, llvm On Thu, Sep 30, 2021 at 1:23 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > > > Applied. Thanks! > > > > Alex > > > > On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor <nathan@kernel.org> wrote: > > > > > > Clang warns: > > Any chance AMDGPU folks can look into adding clang to the CI roster? We can look into it. We may already be doing it for some groups. Alex > -- > Thanks, > ~Nick Desaulniers ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer() @ 2021-09-30 17:59 ` Alex Deucher 0 siblings, 0 replies; 8+ messages in thread From: Alex Deucher @ 2021-09-30 17:59 UTC (permalink / raw) To: Nick Desaulniers Cc: Deucher, Alexander, Koenig, Christian, Pan, Xinhui, Nathan Chancellor, Harry Wentland, Leo Li, amd-gfx list, Maling list - DRI developers, LKML, llvm On Thu, Sep 30, 2021 at 1:23 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Thu, Sep 30, 2021 at 10:10 AM Alex Deucher <alexdeucher@gmail.com> wrote: > > > > Applied. Thanks! > > > > Alex > > > > On Thu, Sep 30, 2021 at 12:23 PM Nathan Chancellor <nathan@kernel.org> wrote: > > > > > > Clang warns: > > Any chance AMDGPU folks can look into adding clang to the CI roster? We can look into it. We may already be doing it for some groups. Alex > -- > Thanks, > ~Nick Desaulniers ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-09-30 18:00 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-09-30 16:23 [PATCH] drm/amd: Return NULL instead of false in dcn201_acquire_idle_pipe_for_layer() Nathan Chancellor 2021-09-30 17:09 ` Alex Deucher 2021-09-30 17:22 ` Nick Desaulniers 2021-09-30 17:22 ` Nick Desaulniers 2021-09-30 17:22 ` Nick Desaulniers 2021-09-30 17:59 ` Alex Deucher 2021-09-30 17:59 ` Alex Deucher 2021-09-30 17:59 ` Alex Deucher
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.