linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c: 3 bugs

linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c: 3 bugs

[David Binderman]

Hello there,
1

[linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1041] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1037]: (style) Same expression on both sides of '|'.

Maybe the macro AMD_CG_SUPPORT_GFX_MGLS is used twice ?

2.

[linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1070] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1066]: (style) Same expression on both sides of '|'.

Duplicate.

In the same file:

linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:792]: (style) Variable 'r' is assigned a value that is never used.

Source code is

    r = vi_set_uvd_clock(adev, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS);

    return 0;

Regards

David Binderman
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c: 3 bugs

[Alex Deucher]

On Mon, Mar 6, 2017 at 4:40 AM, David Binderman <dcb314@hotmail.com> wrote:
>
> Hello there,
> 1
>
> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1041] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1037]: (style) Same expression on both sides of '|'.
>
> Maybe the macro AMD_CG_SUPPORT_GFX_MGLS is used twice ?
>
> 2.
>
> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1070] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1066]: (style) Same expression on both sides of '|'.
>
> Duplicate.
>
> In the same file:
>
> linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:792]: (style) Variable 'r' is assigned a value that is never used.
>
> Source code is
>
>     r = vi_set_uvd_clock(adev, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS);
>
>     return 0;

Thanks, patches sent.

Alex

>
> Regards
>
> David Binderman
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c: 3 bugs

[Alex Deucher]

On Mon, Mar 6, 2017 at 4:40 AM, David Binderman <dcb314@hotmail.com> wrote:
>
> Hello there,
> 1
>
> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1041] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1037]: (style) Same expression on both sides of '|'.
>
> Maybe the macro AMD_CG_SUPPORT_GFX_MGLS is used twice ?
>
> 2.
>
> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1070] -> [linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:1066]: (style) Same expression on both sides of '|'.
>
> Duplicate.
>
> In the same file:
>
> linux-4.11-rc1/drivers/gpu/drm/amd/amdgpu/vi.c:792]: (style) Variable 'r' is assigned a value that is never used.
>
> Source code is
>
>     r = vi_set_uvd_clock(adev, dclk, ixCG_DCLK_CNTL, ixCG_DCLK_STATUS);
>
>     return 0;

Thanks, patches sent.

Alex

>
> Regards
>
> David Binderman
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel