From: Alex Deucher <alexdeucher@gmail.com>
To: Lyude Paul <lyude@redhat.com>
Cc: Pankaj Bharadiya <pankaj.laxminarayan.bharadiya@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [PATCH 0/5] Cleanup drm_dp_mst_topology_cbs hooks
Date: Mon, 9 Mar 2020 16:37:27 -0400 [thread overview]
Message-ID: <CADnq5_PM5guD=LgyKo613PJkgEO=5Kwc_B1Gkwev1pPKEbsSSQ@mail.gmail.com> (raw)
In-Reply-To: <9e5fcbcd3f7a4d74b9941a21e0407c6eef79e920.camel@redhat.com>
On Mon, Mar 9, 2020 at 4:27 PM Lyude Paul <lyude@redhat.com> wrote:
>
> On Sat, 2020-03-07 at 14:00 +0530, Pankaj Bharadiya wrote:
> > drm_dp_mst_topology_mgr_cbs.register_connector callbacks are identical
> > amongst every driver and don't do anything other than calling
> > drm_connector_register().
> > drm_dp_mst_topology_mgr_cbs.destroy_connector callbacks are identical
> > amongst every driver and don't do anything other than cleaning up the
> > connector((drm_connector_unregister()/drm_connector_put())) except for
> > amdgpu_dm driver where some amdgpu_dm specific code in there.
>
> Yeah that amdgpu destruction code kinda stinks a little bit :\. I think we can
> just drop some of it and move the rest into their connector destruction
> callbacks.
>
> For the whole series:
> Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> I'm going to go ahead and let the maintainers know I'm going to push this
> (since there's some minor changes here outside of drm-misc), and push this to
> drm-misc-next. Then I'll go and write some patches to remove the leftover amd
> bits and drop the callback for good (I'll cc it to you as well).
Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> >
> > This series aims to cleaup these drm_dp_mst_topology_mgr_cbs hooks.
> >
> > Pankaj Bharadiya (5):
> > drm: Register connector instead of calling register_connector callback
> > drm: Remove dp mst register connector callbacks
> > drm/dp_mst: Remove register_connector callback
> > drm: Add drm_dp_destroy_connector helper and use it
> > drm: Remove drm dp mst destroy_connector callbacks
> >
> > .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 ------
> > drivers/gpu/drm/drm_dp_mst_topology.c | 18 +++++++++++++++---
> > drivers/gpu/drm/i915/display/intel_dp_mst.c | 16 ----------------
> > drivers/gpu/drm/nouveau/dispnv50/disp.c | 19 -------------------
> > drivers/gpu/drm/radeon/radeon_dp_mst.c | 17 -----------------
> > include/drm/drm_dp_mst_helper.h | 1 -
> > 6 files changed, 15 insertions(+), 62 deletions(-)
> >
> --
> Cheers,
> Lyude Paul (she/her)
> Associate Software Engineer at Red Hat
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com>
To: Lyude Paul <lyude@redhat.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>,
Emil Velikov <emil.velikov@collabora.com>
Subject: Re: [Intel-gfx] [PATCH 0/5] Cleanup drm_dp_mst_topology_cbs hooks
Date: Mon, 9 Mar 2020 16:37:27 -0400 [thread overview]
Message-ID: <CADnq5_PM5guD=LgyKo613PJkgEO=5Kwc_B1Gkwev1pPKEbsSSQ@mail.gmail.com> (raw)
In-Reply-To: <9e5fcbcd3f7a4d74b9941a21e0407c6eef79e920.camel@redhat.com>
On Mon, Mar 9, 2020 at 4:27 PM Lyude Paul <lyude@redhat.com> wrote:
>
> On Sat, 2020-03-07 at 14:00 +0530, Pankaj Bharadiya wrote:
> > drm_dp_mst_topology_mgr_cbs.register_connector callbacks are identical
> > amongst every driver and don't do anything other than calling
> > drm_connector_register().
> > drm_dp_mst_topology_mgr_cbs.destroy_connector callbacks are identical
> > amongst every driver and don't do anything other than cleaning up the
> > connector((drm_connector_unregister()/drm_connector_put())) except for
> > amdgpu_dm driver where some amdgpu_dm specific code in there.
>
> Yeah that amdgpu destruction code kinda stinks a little bit :\. I think we can
> just drop some of it and move the rest into their connector destruction
> callbacks.
>
> For the whole series:
> Reviewed-by: Lyude Paul <lyude@redhat.com>
>
> I'm going to go ahead and let the maintainers know I'm going to push this
> (since there's some minor changes here outside of drm-misc), and push this to
> drm-misc-next. Then I'll go and write some patches to remove the leftover amd
> bits and drop the callback for good (I'll cc it to you as well).
Series is:
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> >
> > This series aims to cleaup these drm_dp_mst_topology_mgr_cbs hooks.
> >
> > Pankaj Bharadiya (5):
> > drm: Register connector instead of calling register_connector callback
> > drm: Remove dp mst register connector callbacks
> > drm/dp_mst: Remove register_connector callback
> > drm: Add drm_dp_destroy_connector helper and use it
> > drm: Remove drm dp mst destroy_connector callbacks
> >
> > .../display/amdgpu_dm/amdgpu_dm_mst_types.c | 6 ------
> > drivers/gpu/drm/drm_dp_mst_topology.c | 18 +++++++++++++++---
> > drivers/gpu/drm/i915/display/intel_dp_mst.c | 16 ----------------
> > drivers/gpu/drm/nouveau/dispnv50/disp.c | 19 -------------------
> > drivers/gpu/drm/radeon/radeon_dp_mst.c | 17 -----------------
> > include/drm/drm_dp_mst_helper.h | 1 -
> > 6 files changed, 15 insertions(+), 62 deletions(-)
> >
> --
> Cheers,
> Lyude Paul (she/her)
> Associate Software Engineer at Red Hat
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2020-03-09 20:37 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-07 8:30 [PATCH 0/5] Cleanup drm_dp_mst_topology_cbs hooks Pankaj Bharadiya
2020-03-07 8:30 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-07 8:30 ` [PATCH 1/5] drm: Register connector instead of calling register_connector callback Pankaj Bharadiya
2020-03-07 8:30 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-07 8:30 ` [PATCH 2/5] drm: Remove dp mst register connector callbacks Pankaj Bharadiya
2020-03-07 8:30 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-07 8:30 ` [PATCH 3/5] drm/dp_mst: Remove register_connector callback Pankaj Bharadiya
2020-03-07 8:30 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-07 8:30 ` [PATCH 4/5] drm: Add drm_dp_destroy_connector helper and use it Pankaj Bharadiya
2020-03-07 8:30 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-07 8:30 ` [PATCH 5/5] drm: Remove drm dp mst destroy_connector callbacks Pankaj Bharadiya
2020-03-07 8:30 ` [Intel-gfx] " Pankaj Bharadiya
2020-03-07 9:12 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for Cleanup drm_dp_mst_topology_cbs hooks Patchwork
2020-03-07 9:34 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2020-03-09 20:27 ` [PATCH 0/5] " Lyude Paul
2020-03-09 20:27 ` [Intel-gfx] " Lyude Paul
2020-03-09 20:37 ` Alex Deucher [this message]
2020-03-09 20:37 ` Alex Deucher
2020-03-11 17:45 ` Emil Velikov
2020-03-11 17:45 ` [Intel-gfx] " Emil Velikov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_PM5guD=LgyKo613PJkgEO=5Kwc_B1Gkwev1pPKEbsSSQ@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.velikov@collabora.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=lyude@redhat.com \
--cc=pankaj.laxminarayan.bharadiya@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.