* [PATCH] drm/amdgpu: Wrong order for config and counter_id parameters
@ 2022-01-26 9:16 ` jinsdb
0 siblings, 0 replies; 5+ messages in thread
From: jinsdb @ 2022-01-26 9:16 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel
Cc: amd-gfx, dri-devel, linux-kernel, jinsdb
From: huangqu <jinsdb@126.com>
Wrong order for config and counter_id parameters was passed, when calling df_v3_6_pmc_set_deferred and df_v3_6_pmc_is_deferred functions.
Signed-off-by: huangqu <jinsdb@126.com>
---
drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
index 43c5e3ec9..f4dfca013 100644
--- a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
+++ b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
@@ -458,7 +458,7 @@ static int df_v3_6_pmc_add_cntr(struct amdgpu_device *adev,
#define DEFERRED_ARM_MASK (1 << 31)
static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
- int counter_idx, uint64_t config,
+ uint64_t config, int counter_idx,
bool is_deferred)
{
@@ -476,8 +476,8 @@ static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
}
static bool df_v3_6_pmc_is_deferred(struct amdgpu_device *adev,
- int counter_idx,
- uint64_t config)
+ uint64_t config,
+ int counter_idx)
{
return (df_v3_6_pmc_has_counter(adev, config, counter_idx) &&
(adev->df_perfmon_config_assign_mask[counter_idx]
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [PATCH] drm/amdgpu: Wrong order for config and counter_id parameters
@ 2022-01-26 9:16 ` jinsdb
0 siblings, 0 replies; 5+ messages in thread
From: jinsdb @ 2022-01-26 9:16 UTC (permalink / raw)
To: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel
Cc: jinsdb, dri-devel, amd-gfx, linux-kernel
From: huangqu <jinsdb@126.com>
Wrong order for config and counter_id parameters was passed, when calling df_v3_6_pmc_set_deferred and df_v3_6_pmc_is_deferred functions.
Signed-off-by: huangqu <jinsdb@126.com>
---
drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
index 43c5e3ec9..f4dfca013 100644
--- a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
+++ b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
@@ -458,7 +458,7 @@ static int df_v3_6_pmc_add_cntr(struct amdgpu_device *adev,
#define DEFERRED_ARM_MASK (1 << 31)
static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
- int counter_idx, uint64_t config,
+ uint64_t config, int counter_idx,
bool is_deferred)
{
@@ -476,8 +476,8 @@ static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
}
static bool df_v3_6_pmc_is_deferred(struct amdgpu_device *adev,
- int counter_idx,
- uint64_t config)
+ uint64_t config,
+ int counter_idx)
{
return (df_v3_6_pmc_has_counter(adev, config, counter_idx) &&
(adev->df_perfmon_config_assign_mask[counter_idx]
--
2.31.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] drm/amdgpu: Wrong order for config and counter_id parameters
2022-01-26 9:16 ` jinsdb
(?)
@ 2022-01-27 20:16 ` Alex Deucher
-1 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-01-27 20:16 UTC (permalink / raw)
To: Qu Huang
Cc: Deucher, Alexander, Christian Koenig, xinhui pan, Dave Airlie,
Daniel Vetter, Maling list - DRI developers, amd-gfx list, LKML
Applied. Thanks!
Alex
On Wed, Jan 26, 2022 at 4:48 AM <jinsdb@126.com> wrote:
>
> From: huangqu <jinsdb@126.com>
>
> Wrong order for config and counter_id parameters was passed, when calling df_v3_6_pmc_set_deferred and df_v3_6_pmc_is_deferred functions.
>
> Signed-off-by: huangqu <jinsdb@126.com>
> ---
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> index 43c5e3ec9..f4dfca013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> +++ b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> @@ -458,7 +458,7 @@ static int df_v3_6_pmc_add_cntr(struct amdgpu_device *adev,
>
> #define DEFERRED_ARM_MASK (1 << 31)
> static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
> - int counter_idx, uint64_t config,
> + uint64_t config, int counter_idx,
> bool is_deferred)
> {
>
> @@ -476,8 +476,8 @@ static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
> }
>
> static bool df_v3_6_pmc_is_deferred(struct amdgpu_device *adev,
> - int counter_idx,
> - uint64_t config)
> + uint64_t config,
> + int counter_idx)
> {
> return (df_v3_6_pmc_has_counter(adev, config, counter_idx) &&
> (adev->df_perfmon_config_assign_mask[counter_idx]
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/amdgpu: Wrong order for config and counter_id parameters
@ 2022-01-27 20:16 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-01-27 20:16 UTC (permalink / raw)
To: Qu Huang
Cc: Dave Airlie, xinhui pan, LKML, Maling list - DRI developers,
amd-gfx list, Daniel Vetter, Deucher, Alexander,
Christian Koenig
Applied. Thanks!
Alex
On Wed, Jan 26, 2022 at 4:48 AM <jinsdb@126.com> wrote:
>
> From: huangqu <jinsdb@126.com>
>
> Wrong order for config and counter_id parameters was passed, when calling df_v3_6_pmc_set_deferred and df_v3_6_pmc_is_deferred functions.
>
> Signed-off-by: huangqu <jinsdb@126.com>
> ---
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> index 43c5e3ec9..f4dfca013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> +++ b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> @@ -458,7 +458,7 @@ static int df_v3_6_pmc_add_cntr(struct amdgpu_device *adev,
>
> #define DEFERRED_ARM_MASK (1 << 31)
> static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
> - int counter_idx, uint64_t config,
> + uint64_t config, int counter_idx,
> bool is_deferred)
> {
>
> @@ -476,8 +476,8 @@ static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
> }
>
> static bool df_v3_6_pmc_is_deferred(struct amdgpu_device *adev,
> - int counter_idx,
> - uint64_t config)
> + uint64_t config,
> + int counter_idx)
> {
> return (df_v3_6_pmc_has_counter(adev, config, counter_idx) &&
> (adev->df_perfmon_config_assign_mask[counter_idx]
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] drm/amdgpu: Wrong order for config and counter_id parameters
@ 2022-01-27 20:16 ` Alex Deucher
0 siblings, 0 replies; 5+ messages in thread
From: Alex Deucher @ 2022-01-27 20:16 UTC (permalink / raw)
To: Qu Huang
Cc: Dave Airlie, xinhui pan, LKML, Maling list - DRI developers,
amd-gfx list, Deucher, Alexander, Christian Koenig
Applied. Thanks!
Alex
On Wed, Jan 26, 2022 at 4:48 AM <jinsdb@126.com> wrote:
>
> From: huangqu <jinsdb@126.com>
>
> Wrong order for config and counter_id parameters was passed, when calling df_v3_6_pmc_set_deferred and df_v3_6_pmc_is_deferred functions.
>
> Signed-off-by: huangqu <jinsdb@126.com>
> ---
> drivers/gpu/drm/amd/amdgpu/df_v3_6.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> index 43c5e3ec9..f4dfca013 100644
> --- a/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> +++ b/drivers/gpu/drm/amd/amdgpu/df_v3_6.c
> @@ -458,7 +458,7 @@ static int df_v3_6_pmc_add_cntr(struct amdgpu_device *adev,
>
> #define DEFERRED_ARM_MASK (1 << 31)
> static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
> - int counter_idx, uint64_t config,
> + uint64_t config, int counter_idx,
> bool is_deferred)
> {
>
> @@ -476,8 +476,8 @@ static int df_v3_6_pmc_set_deferred(struct amdgpu_device *adev,
> }
>
> static bool df_v3_6_pmc_is_deferred(struct amdgpu_device *adev,
> - int counter_idx,
> - uint64_t config)
> + uint64_t config,
> + int counter_idx)
> {
> return (df_v3_6_pmc_has_counter(adev, config, counter_idx) &&
> (adev->df_perfmon_config_assign_mask[counter_idx]
> --
> 2.31.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-01-27 20:17 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-26 9:16 [PATCH] drm/amdgpu: Wrong order for config and counter_id parameters jinsdb
2022-01-26 9:16 ` jinsdb
2022-01-27 20:16 ` Alex Deucher
2022-01-27 20:16 ` Alex Deucher
2022-01-27 20:16 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.