Re: [PATCH] drm/i915: support address only i2c-over-aux transactions

[Alex Deucher <alexdeucher@gmail.com>]

On Mon, Apr 7, 2014 at 5:37 AM, Jani Nikula <jani.nikula@intel.com> wrote:
> To support bare address requests used by the drm dp helpers.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> ---
>
> Hi Alex, similar to Thierry's patch for i915.
>

Looks good to me.

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

Do you want me to add this to the patch set?

Alex

> BR,
> Jani.
> ---
>  drivers/gpu/drm/i915/intel_dp.c |    7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
> index e48d47ced57b..b435d07fbc08 100644
> --- a/drivers/gpu/drm/i915/intel_dp.c
> +++ b/drivers/gpu/drm/i915/intel_dp.c
> @@ -575,7 +575,8 @@ out:
>         return ret;
>  }
>
> -#define HEADER_SIZE    4
> +#define BARE_ADDRESS_SIZE      3
> +#define HEADER_SIZE            (BARE_ADDRESS_SIZE + 1)
>  static ssize_t
>  intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
>  {
> @@ -592,7 +593,7 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
>         switch (msg->request & ~DP_AUX_I2C_MOT) {
>         case DP_AUX_NATIVE_WRITE:
>         case DP_AUX_I2C_WRITE:
> -               txsize = HEADER_SIZE + msg->size;
> +               txsize = msg->size ? HEADER_SIZE + msg->size : BARE_ADDRESS_SIZE;
>                 rxsize = 1;
>
>                 if (WARN_ON(txsize > 20))
> @@ -611,7 +612,7 @@ intel_dp_aux_transfer(struct drm_dp_aux *aux, struct drm_dp_aux_msg *msg)
>
>         case DP_AUX_NATIVE_READ:
>         case DP_AUX_I2C_READ:
> -               txsize = HEADER_SIZE;
> +               txsize = msg->size ? HEADER_SIZE : BARE_ADDRESS_SIZE;
>                 rxsize = msg->size + 1;
>
>                 if (WARN_ON(rxsize > 20))
> --
> 1.7.9.5
>