From: Daniel Vetter <daniel@ffwll.ch>
To: Alex Deucher <alexdeucher@gmail.com>
Cc: Jani Nikula <jani.nikula@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
Thierry Reding <thierry.reding@gmail.com>,
Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915: support address only i2c-over-aux transactions
Date: Mon, 7 Apr 2014 22:00:48 +0200 [thread overview]
Message-ID: <CAKMK7uE8cNoCvzvD-Hy-QnVk2u0uftrqXeQG3-KRT-vHA2ypAA@mail.gmail.com> (raw)
In-Reply-To: <CADnq5_PapteT1y+4qiNZLhcjVViNJ-W9DJd0OmyoSF5MM6Z-=A@mail.gmail.com>
On Mon, Apr 7, 2014 at 4:35 PM, Alex Deucher <alexdeucher@gmail.com> wrote:
> On Mon, Apr 7, 2014 at 5:37 AM, Jani Nikula <jani.nikula@intel.com> wrote:
>> To support bare address requests used by the drm dp helpers.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>> ---
>>
>> Hi Alex, similar to Thierry's patch for i915.
>>
>
> Looks good to me.
>
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> Do you want me to add this to the patch set?
Afaict we've done an unconditional msg_bytes = send_bytes + 4; in the
i915 driver before the conversion to the dp aux helper, which is why
I've slapped an r-b onto your patch without asking for a i915
adjustement. Otoh we have a pile of bugs for dp dongles still. Imo my
preferred approach would be to get the helper + radeon stuff in and
then hawk the i915 patch to a bunch of bug reporter and see whether it
sticks. Ofc if we already know that we need it it would be best to
merge it in one pull together with all your other patches.
Jani?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2014-04-07 20:00 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-07 8:37 [PATCH] drm/tegra: dp: Support address-only I2C-over-AUX transactions Thierry Reding
2014-04-07 9:37 ` [PATCH] drm/i915: support address only i2c-over-aux transactions Jani Nikula
2014-04-07 14:35 ` Alex Deucher
2014-04-07 20:00 ` Daniel Vetter [this message]
2014-04-08 6:58 ` Jani Nikula
2014-04-08 8:03 ` Daniel Vetter
2014-04-08 13:04 ` [Intel-gfx] " Alex Deucher
2014-04-08 13:09 ` Christian König
2014-04-08 13:11 ` Alex Deucher
2014-04-08 14:06 ` [PATCH] drm/tegra: dp: Support address-only I2C-over-AUX transactions Christian König
2014-04-08 20:47 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKMK7uE8cNoCvzvD-Hy-QnVk2u0uftrqXeQG3-KRT-vHA2ypAA@mail.gmail.com \
--to=daniel@ffwll.ch \
--cc=alexdeucher@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.