From: Alex Deucher <alexdeucher@gmail.com> To: Lyude Paul <lyude@redhat.com> Cc: Maling list - DRI developers <dri-devel@lists.freedesktop.org>, Sean Paul <seanpaul@google.com>, David Airlie <airlied@linux.ie>, LKML <linux-kernel@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>, Thomas Zimmermann <tzimmermann@suse.de>, Mikita Lipski <mikita.lipski@amd.com> Subject: Re: [PATCH v2 1/4] drm/dp_mst: Rename drm_dp_mst_is_dp_mst_end_device() to be less redundant Date: Mon, 9 Mar 2020 17:04:46 -0400 [thread overview] Message-ID: <CADnq5_PfLg=Pvcb6SQtaEphxfj9G=Ad2t+oAFBK03rPQTn3vdg@mail.gmail.com> (raw) In-Reply-To: <20200306234623.547525-2-lyude@redhat.com> On Fri, Mar 6, 2020 at 6:46 PM Lyude Paul <lyude@redhat.com> wrote: > > It's already prefixed by dp_mst, so we don't really need to repeat > ourselves here. One of the changes I should have picked up originally > when reviewing MST DSC support. > > There should be no functional changes here > > Cc: Mikita Lipski <mikita.lipski@amd.com> > Cc: Sean Paul <seanpaul@google.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Lyude Paul <lyude@redhat.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 6c62ad8f4414..6714d8a5c558 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -1937,7 +1937,7 @@ static u8 drm_dp_calculate_rad(struct drm_dp_mst_port *port, > return parent_lct + 1; > } > > -static bool drm_dp_mst_is_dp_mst_end_device(u8 pdt, bool mcs) > +static bool drm_dp_mst_is_end_device(u8 pdt, bool mcs) > { > switch (pdt) { > case DP_PEER_DEVICE_DP_LEGACY_CONV: > @@ -1967,13 +1967,13 @@ drm_dp_port_set_pdt(struct drm_dp_mst_port *port, u8 new_pdt, > > /* Teardown the old pdt, if there is one */ > if (port->pdt != DP_PEER_DEVICE_NONE) { > - if (drm_dp_mst_is_dp_mst_end_device(port->pdt, port->mcs)) { > + if (drm_dp_mst_is_end_device(port->pdt, port->mcs)) { > /* > * If the new PDT would also have an i2c bus, > * don't bother with reregistering it > */ > if (new_pdt != DP_PEER_DEVICE_NONE && > - drm_dp_mst_is_dp_mst_end_device(new_pdt, new_mcs)) { > + drm_dp_mst_is_end_device(new_pdt, new_mcs)) { > port->pdt = new_pdt; > port->mcs = new_mcs; > return 0; > @@ -1993,7 +1993,7 @@ drm_dp_port_set_pdt(struct drm_dp_mst_port *port, u8 new_pdt, > port->mcs = new_mcs; > > if (port->pdt != DP_PEER_DEVICE_NONE) { > - if (drm_dp_mst_is_dp_mst_end_device(port->pdt, port->mcs)) { > + if (drm_dp_mst_is_end_device(port->pdt, port->mcs)) { > /* add i2c over sideband */ > ret = drm_dp_mst_register_i2c_bus(&port->aux); > } else { > @@ -2169,7 +2169,7 @@ drm_dp_mst_port_add_connector(struct drm_dp_mst_branch *mstb, > } > > if (port->pdt != DP_PEER_DEVICE_NONE && > - drm_dp_mst_is_dp_mst_end_device(port->pdt, port->mcs)) { > + drm_dp_mst_is_end_device(port->pdt, port->mcs)) { > port->cached_edid = drm_get_edid(port->connector, > &port->aux.ddc); > drm_connector_set_tile_property(port->connector); > -- > 2.24.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: Alex Deucher <alexdeucher@gmail.com> To: Lyude Paul <lyude@redhat.com> Cc: Sean Paul <seanpaul@google.com>, David Airlie <airlied@linux.ie>, LKML <linux-kernel@vger.kernel.org>, Maling list - DRI developers <dri-devel@lists.freedesktop.org>, Hans de Goede <hdegoede@redhat.com>, Thomas Zimmermann <tzimmermann@suse.de>, Mikita Lipski <mikita.lipski@amd.com> Subject: Re: [PATCH v2 1/4] drm/dp_mst: Rename drm_dp_mst_is_dp_mst_end_device() to be less redundant Date: Mon, 9 Mar 2020 17:04:46 -0400 [thread overview] Message-ID: <CADnq5_PfLg=Pvcb6SQtaEphxfj9G=Ad2t+oAFBK03rPQTn3vdg@mail.gmail.com> (raw) In-Reply-To: <20200306234623.547525-2-lyude@redhat.com> On Fri, Mar 6, 2020 at 6:46 PM Lyude Paul <lyude@redhat.com> wrote: > > It's already prefixed by dp_mst, so we don't really need to repeat > ourselves here. One of the changes I should have picked up originally > when reviewing MST DSC support. > > There should be no functional changes here > > Cc: Mikita Lipski <mikita.lipski@amd.com> > Cc: Sean Paul <seanpaul@google.com> > Cc: Hans de Goede <hdegoede@redhat.com> > Signed-off-by: Lyude Paul <lyude@redhat.com> Reviewed-by: Alex Deucher <alexander.deucher@amd.com> > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c b/drivers/gpu/drm/drm_dp_mst_topology.c > index 6c62ad8f4414..6714d8a5c558 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -1937,7 +1937,7 @@ static u8 drm_dp_calculate_rad(struct drm_dp_mst_port *port, > return parent_lct + 1; > } > > -static bool drm_dp_mst_is_dp_mst_end_device(u8 pdt, bool mcs) > +static bool drm_dp_mst_is_end_device(u8 pdt, bool mcs) > { > switch (pdt) { > case DP_PEER_DEVICE_DP_LEGACY_CONV: > @@ -1967,13 +1967,13 @@ drm_dp_port_set_pdt(struct drm_dp_mst_port *port, u8 new_pdt, > > /* Teardown the old pdt, if there is one */ > if (port->pdt != DP_PEER_DEVICE_NONE) { > - if (drm_dp_mst_is_dp_mst_end_device(port->pdt, port->mcs)) { > + if (drm_dp_mst_is_end_device(port->pdt, port->mcs)) { > /* > * If the new PDT would also have an i2c bus, > * don't bother with reregistering it > */ > if (new_pdt != DP_PEER_DEVICE_NONE && > - drm_dp_mst_is_dp_mst_end_device(new_pdt, new_mcs)) { > + drm_dp_mst_is_end_device(new_pdt, new_mcs)) { > port->pdt = new_pdt; > port->mcs = new_mcs; > return 0; > @@ -1993,7 +1993,7 @@ drm_dp_port_set_pdt(struct drm_dp_mst_port *port, u8 new_pdt, > port->mcs = new_mcs; > > if (port->pdt != DP_PEER_DEVICE_NONE) { > - if (drm_dp_mst_is_dp_mst_end_device(port->pdt, port->mcs)) { > + if (drm_dp_mst_is_end_device(port->pdt, port->mcs)) { > /* add i2c over sideband */ > ret = drm_dp_mst_register_i2c_bus(&port->aux); > } else { > @@ -2169,7 +2169,7 @@ drm_dp_mst_port_add_connector(struct drm_dp_mst_branch *mstb, > } > > if (port->pdt != DP_PEER_DEVICE_NONE && > - drm_dp_mst_is_dp_mst_end_device(port->pdt, port->mcs)) { > + drm_dp_mst_is_end_device(port->pdt, port->mcs)) { > port->cached_edid = drm_get_edid(port->connector, > &port->aux.ddc); > drm_connector_set_tile_property(port->connector); > -- > 2.24.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-09 21:05 UTC|newest] Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-03-06 23:46 [PATCH v2 0/4] drm/dp_mst: Fix bandwidth checking regressions from DSC patches Lyude Paul 2020-03-06 23:46 ` Lyude Paul 2020-03-06 23:46 ` [PATCH v2 1/4] drm/dp_mst: Rename drm_dp_mst_is_dp_mst_end_device() to be less redundant Lyude Paul 2020-03-06 23:46 ` Lyude Paul 2020-03-09 21:04 ` Alex Deucher [this message] 2020-03-09 21:04 ` Alex Deucher 2020-03-06 23:46 ` [PATCH v2 2/4] drm/dp_mst: Use full_pbn instead of available_pbn for bandwidth checks Lyude Paul 2020-03-06 23:46 ` Lyude Paul 2020-03-10 15:35 ` Mikita Lipski 2020-03-10 15:35 ` Mikita Lipski 2020-03-06 23:46 ` [PATCH v2 3/4] drm/dp_mst: Reprobe path resources in CSN handler Lyude Paul 2020-03-06 23:46 ` Lyude Paul 2020-03-06 23:46 ` [PATCH v2 4/4] drm/dp_mst: Rewrite and fix bandwidth limit checks Lyude Paul 2020-03-06 23:46 ` Lyude Paul 2020-03-09 21:01 ` [PATCH v3] " Lyude Paul 2020-03-09 21:01 ` Lyude Paul 2020-03-09 21:15 ` Alex Deucher 2020-03-09 21:15 ` Alex Deucher 2020-03-10 17:51 ` Mikita Lipski 2020-03-10 17:51 ` Mikita Lipski 2020-03-07 12:05 ` [PATCH v2 0/4] drm/dp_mst: Fix bandwidth checking regressions from DSC patches Hans de Goede 2020-03-07 12:05 ` Hans de Goede 2020-03-10 13:01 ` Mikita Lipski 2020-03-10 13:01 ` Mikita Lipski
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADnq5_PfLg=Pvcb6SQtaEphxfj9G=Ad2t+oAFBK03rPQTn3vdg@mail.gmail.com' \ --to=alexdeucher@gmail.com \ --cc=airlied@linux.ie \ --cc=dri-devel@lists.freedesktop.org \ --cc=hdegoede@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=mikita.lipski@amd.com \ --cc=seanpaul@google.com \ --cc=tzimmermann@suse.de \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.