* [PATCH] Handling of amdgpu_device_resume return value for graceful teardown
@ 2021-04-27 4:51 pavan.ramayanam
2021-04-27 17:46 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: pavan.ramayanam @ 2021-04-27 4:51 UTC (permalink / raw)
To: amd-gfx; +Cc: Alexander.Deucher, Pavan Kumar Ramayanam
From: Pavan Kumar Ramayanam <pavan.ramayanam@amd.com>
The runtime resume PM op disregards the return value from
amdgpu_device_resume(), masking errors for failed resumes at the PM
layer.
Signed-off-by: Pavan Kumar Ramayanam <pavan.ramayanam@amd.com>
---
drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
index 0369d3532bf0..03f3cf194300 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
@@ -1574,6 +1574,9 @@ static int amdgpu_pmops_runtime_resume(struct device *dev)
amdgpu_device_baco_exit(drm_dev);
}
ret = amdgpu_device_resume(drm_dev, false);
+ if (ret)
+ return ret;
+
if (amdgpu_device_supports_px(drm_dev))
drm_dev->switch_power_state = DRM_SWITCH_POWER_ON;
adev->in_runpm = false;
--
2.17.1
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Handling of amdgpu_device_resume return value for graceful teardown
2021-04-27 4:51 [PATCH] Handling of amdgpu_device_resume return value for graceful teardown pavan.ramayanam
@ 2021-04-27 17:46 ` Alex Deucher
2021-04-28 20:52 ` Alex Deucher
0 siblings, 1 reply; 3+ messages in thread
From: Alex Deucher @ 2021-04-27 17:46 UTC (permalink / raw)
To: pavan.ramayanam; +Cc: Deucher, Alexander, amd-gfx list
On Tue, Apr 27, 2021 at 12:51 AM <pavan.ramayanam@amd.com> wrote:
>
> From: Pavan Kumar Ramayanam <pavan.ramayanam@amd.com>
>
> The runtime resume PM op disregards the return value from
> amdgpu_device_resume(), masking errors for failed resumes at the PM
> layer.
>
> Signed-off-by: Pavan Kumar Ramayanam <pavan.ramayanam@amd.com>
Subject should be prefixed with drm/amdgpu:, with that fixed,
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Do you need me to commit this for you?
Alex
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> index 0369d3532bf0..03f3cf194300 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> @@ -1574,6 +1574,9 @@ static int amdgpu_pmops_runtime_resume(struct device *dev)
> amdgpu_device_baco_exit(drm_dev);
> }
> ret = amdgpu_device_resume(drm_dev, false);
> + if (ret)
> + return ret;
> +
> if (amdgpu_device_supports_px(drm_dev))
> drm_dev->switch_power_state = DRM_SWITCH_POWER_ON;
> adev->in_runpm = false;
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Handling of amdgpu_device_resume return value for graceful teardown
2021-04-27 17:46 ` Alex Deucher
@ 2021-04-28 20:52 ` Alex Deucher
0 siblings, 0 replies; 3+ messages in thread
From: Alex Deucher @ 2021-04-28 20:52 UTC (permalink / raw)
To: pavan.ramayanam; +Cc: Deucher, Alexander, amd-gfx list
Applied. Thanks!
Alex
On Tue, Apr 27, 2021 at 1:46 PM Alex Deucher <alexdeucher@gmail.com> wrote:
>
> On Tue, Apr 27, 2021 at 12:51 AM <pavan.ramayanam@amd.com> wrote:
> >
> > From: Pavan Kumar Ramayanam <pavan.ramayanam@amd.com>
> >
> > The runtime resume PM op disregards the return value from
> > amdgpu_device_resume(), masking errors for failed resumes at the PM
> > layer.
> >
> > Signed-off-by: Pavan Kumar Ramayanam <pavan.ramayanam@amd.com>
>
> Subject should be prefixed with drm/amdgpu:, with that fixed,
> Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
>
> Do you need me to commit this for you?
>
> Alex
>
>
> > ---
> > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > index 0369d3532bf0..03f3cf194300 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > @@ -1574,6 +1574,9 @@ static int amdgpu_pmops_runtime_resume(struct device *dev)
> > amdgpu_device_baco_exit(drm_dev);
> > }
> > ret = amdgpu_device_resume(drm_dev, false);
> > + if (ret)
> > + return ret;
> > +
> > if (amdgpu_device_supports_px(drm_dev))
> > drm_dev->switch_power_state = DRM_SWITCH_POWER_ON;
> > adev->in_runpm = false;
> > --
> > 2.17.1
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-04-28 20:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-27 4:51 [PATCH] Handling of amdgpu_device_resume return value for graceful teardown pavan.ramayanam
2021-04-27 17:46 ` Alex Deucher
2021-04-28 20:52 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.