[PATCH xf86-video-ati] Hardcode "non-desktop" RandR property name

[PATCH xf86-video-ati] Hardcode "non-desktop" RandR property name

[Michel Dänzer]

From: Michel Dänzer <michel.daenzer@amd.com>

It's a bit silly to require current randrproto just for this definition,
which can't really change anyway.

Suggested-by: Qiang Yu <qiang.yu@amd.com>
(Ported from amdgpu commit ae8e02c6fc4ef5d5340b8cd4739e66b19b9e3386)

Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
---
 configure.ac          | 2 +-
 src/drmmode_display.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/configure.ac b/configure.ac
index 15c7b2128..bea205c34 100644
--- a/configure.ac
+++ b/configure.ac
@@ -64,7 +64,7 @@ AC_ARG_WITH(xorg-module-dir,
             [moduledir="$libdir/xorg/modules"])
 
 # Store the list of server defined optional extensions in REQUIRED_MODULES
-XORG_DRIVER_CHECK_EXT(RANDR, [randrproto >= 1.6.0])
+XORG_DRIVER_CHECK_EXT(RANDR, randrproto)
 XORG_DRIVER_CHECK_EXT(RENDER, renderproto)
 XORG_DRIVER_CHECK_EXT(XV, videoproto)
 XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
diff --git a/src/drmmode_display.c b/src/drmmode_display.c
index 000c7fc62..ff098975f 100644
--- a/src/drmmode_display.c
+++ b/src/drmmode_display.c
@@ -2012,7 +2012,7 @@ drmmode_output_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, drmModeResPtr mode_r
 
 #if XF86_CRTC_VERSION >= 8
 	i = koutput_get_prop_idx(pRADEONEnt->fd, koutput, DRM_MODE_PROP_RANGE,
-				 RR_PROPERTY_NON_DESKTOP);
+				 "non-desktop");
 	if (i >= 0)
 		nonDesktop = koutput->prop_values[i] != 0;
 #endif
-- 
2.18.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH xf86-video-ati] Hardcode "non-desktop" RandR property name

[Alex Deucher]

On Mon, Jul 23, 2018 at 5:04 AM, Michel Dänzer <michel@daenzer.net> wrote:
> From: Michel Dänzer <michel.daenzer@amd.com>
>
> It's a bit silly to require current randrproto just for this definition,
> which can't really change anyway.
>
> Suggested-by: Qiang Yu <qiang.yu@amd.com>
> (Ported from amdgpu commit ae8e02c6fc4ef5d5340b8cd4739e66b19b9e3386)
>
> Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  configure.ac          | 2 +-
>  src/drmmode_display.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index 15c7b2128..bea205c34 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -64,7 +64,7 @@ AC_ARG_WITH(xorg-module-dir,
>              [moduledir="$libdir/xorg/modules"])
>
>  # Store the list of server defined optional extensions in REQUIRED_MODULES
> -XORG_DRIVER_CHECK_EXT(RANDR, [randrproto >= 1.6.0])
> +XORG_DRIVER_CHECK_EXT(RANDR, randrproto)
>  XORG_DRIVER_CHECK_EXT(RENDER, renderproto)
>  XORG_DRIVER_CHECK_EXT(XV, videoproto)
>  XORG_DRIVER_CHECK_EXT(DPMSExtension, xextproto)
> diff --git a/src/drmmode_display.c b/src/drmmode_display.c
> index 000c7fc62..ff098975f 100644
> --- a/src/drmmode_display.c
> +++ b/src/drmmode_display.c
> @@ -2012,7 +2012,7 @@ drmmode_output_init(ScrnInfoPtr pScrn, drmmode_ptr drmmode, drmModeResPtr mode_r
>
>  #if XF86_CRTC_VERSION >= 8
>         i = koutput_get_prop_idx(pRADEONEnt->fd, koutput, DRM_MODE_PROP_RANGE,
> -                                RR_PROPERTY_NON_DESKTOP);
> +                                "non-desktop");
>         if (i >= 0)
>                 nonDesktop = koutput->prop_values[i] != 0;
>  #endif
> --
> 2.18.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx