[PATCH] drm/amdgpu: Remove check which is not valid for certain VBIOS

[PATCH] drm/amdgpu: Remove check which is not valid for certain VBIOS

[Ken.Wang-5C7GfCeVMHo]

From: Ken Wang <Ken.Wang@amd.com>

Signed-off-by: Ken Wang <Ken.Wang@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
index c21adf6..057e1ec 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
@@ -59,12 +59,6 @@ static bool check_atom_bios(uint8_t *bios, size_t size)
 		return false;
 	}
 
-	tmp = bios[0x18] | (bios[0x19] << 8);
-	if (bios[tmp + 0x14] != 0x0) {
-		DRM_INFO("Not an x86 BIOS ROM\n");
-		return false;
-	}
-
 	bios_header_start = bios[0x48] | (bios[0x49] << 8);
 	if (!bios_header_start) {
 		DRM_INFO("Can't locate bios header\n");
-- 
2.7.4

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: Remove check which is not valid for certain VBIOS

[Alex Deucher]

On Wed, Nov 8, 2017 at 1:49 AM,  <Ken.Wang@amd.com> wrote:
> From: Ken Wang <Ken.Wang@amd.com>

What cases does this fix?  I'm guessing VFCT or some other platform
method for getting the vbios?

Acked-by: Alex Deucher <alexander.deucher@amd.com>

>
> Signed-off-by: Ken Wang <Ken.Wang@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> index c21adf6..057e1ec 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> @@ -59,12 +59,6 @@ static bool check_atom_bios(uint8_t *bios, size_t size)
>                 return false;
>         }
>
> -       tmp = bios[0x18] | (bios[0x19] << 8);
> -       if (bios[tmp + 0x14] != 0x0) {
> -               DRM_INFO("Not an x86 BIOS ROM\n");
> -               return false;
> -       }
> -
>         bios_header_start = bios[0x48] | (bios[0x49] << 8);
>         if (!bios_header_start) {
>                 DRM_INFO("Can't locate bios header\n");
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Re: [PATCH] drm/amdgpu: Remove check which is not valid for certain VBIOS

[Wang, Ken]

[-- Attachment #1.1: Type: text/plain, Size: 1758 bytes --]

It fixes some headless board VBIOS which will be failed to load.

________________________________
From: Alex Deucher <alexdeucher-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Sent: Wednesday, November 8, 2017 10:38:37 PM
To: Wang, Ken
Cc: amd-gfx list
Subject: Re: [PATCH] drm/amdgpu: Remove check which is not valid for certain VBIOS

On Wed, Nov 8, 2017 at 1:49 AM,  <Ken.Wang-5C7GfCeVMHo@public.gmane.org> wrote:
> From: Ken Wang <Ken.Wang-5C7GfCeVMHo@public.gmane.org>

What cases does this fix?  I'm guessing VFCT or some other platform
method for getting the vbios?

Acked-by: Alex Deucher <alexander.deucher-5C7GfCeVMHo@public.gmane.org>

>
> Signed-off-by: Ken Wang <Ken.Wang-5C7GfCeVMHo@public.gmane.org>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> index c21adf6..057e1ec 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_bios.c
> @@ -59,12 +59,6 @@ static bool check_atom_bios(uint8_t *bios, size_t size)
>                 return false;
>         }
>
> -       tmp = bios[0x18] | (bios[0x19] << 8);
> -       if (bios[tmp + 0x14] != 0x0) {
> -               DRM_INFO("Not an x86 BIOS ROM\n");
> -               return false;
> -       }
> -
>         bios_header_start = bios[0x48] | (bios[0x49] << 8);
>         if (!bios_header_start) {
>                 DRM_INFO("Can't locate bios header\n");
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx

[-- Attachment #1.2: Type: text/html, Size: 3374 bytes --]

[-- Attachment #2: Type: text/plain, Size: 154 bytes --]

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx