From: Jaya Kumar <jayakumar.lkml@gmail.com> To: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, archit@ti.com Subject: Re: [PATCH 1/4] OMAP: OMAPFB: make omapfb start even when a display Date: Sat, 27 Aug 2011 10:28:46 +0000 [thread overview] Message-ID: <CADqH6VybU7=rSAobaOKbvGwHouLeWuGwbUrc70xKgusE_+rqzQ@mail.gmail.com> (raw) In-Reply-To: <1314001636-18036-2-git-send-email-tomi.valkeinen@ti.com> On Mon, Aug 22, 2011 at 4:27 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > Currently omapfb wants that all the display devices have a driver, > otherwise omapfb refuses to start. There's no real requirement to act > like that, and this patch will make omapfb give a warning and skip that > device. Hi Tomi, Just a question, I am working with an out-of-tree hdmi driver for the NXP TDA9984 with dm3730. This worked fine in 2.6.32 as a runtime loaded dss display driver. That is: +static struct omap_dss_device wiser2_hdmi_device = { + .type = OMAP_DISPLAY_TYPE_DPI, + .name = "hdmi", + .driver_name = "hdmi_panel", + .phy.dpi.data_lines = 24, + .platform_enable = wiser2_enable_hdmi, + .platform_disable = wiser2_disable_hdmi, +}; + +static struct omap_dss_device wiser2_tv_device = { + .name = "tv", + .driver_name = "venc", + .type = OMAP_DISPLAY_TYPE_VENC, + .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO, + .platform_enable = wiser2_panel_enable_tv, + .platform_disable = wiser2_panel_disable_tv, +}; + +static struct omap_dss_device *wiser2_dss_devices[] = { + &wiser2_dvi_device, + &wiser2_tv_device, + &wiser2_hdmi_device, +}; so this hdmi_panel omap_dss_driver was being insmoded after init at bootup and it worked fine, no problems with omaplfb so pvr stuff worked fine. I then switched to 2.6.37 (from TI devkit 2.1 gingerbread) and this kernel wasn't so happy (panic at boot). I applied your patch below. I also figured out that omap_vout had a similar problem as the one you've fixed which was what was causing the panic (omap_vout tries to call display->driver->update without checking if driver exists): diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c index 2aee372..36d69db 100644 --- a/drivers/media/video/omap/omap_vout.c +++ b/drivers/media/video/omap/omap_vout.c @@ -2574,24 +2591,32 @@ static int __init omap_vout_probe(struct platform_device *pdev) + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); for (i = 0; i < vid_dev->num_displays; i++) { struct omap_dss_device *display = vid_dev->displays[i]; - if (display->driver->update) + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); + if ((display->driver) && (display->driver->update)) { + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); display->driver->update(display, 0, 0, display->panel.timings.x_res, display->panel.timings.y_res); + } + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); } + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); return 0; After that change, it boots up cleanly but I don't get any display output. I noticed that: echo 1 > /sys/devices/omapdss/display2/enabled no longer works. display2 stays enabled=0 rather than coming on. I'm planning on debugging this some more when I have some free time. But I figured I should ask first if this is a known problem, whether anyone else is testing runtime loaded omap_dss_driver stuff and if anyone has gotten it to work with kernels 2.6.37 and above. Thanks, jaya > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- > drivers/video/omap2/omapfb/omapfb-main.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c > index e5a64b3..cd2cae8e 100644 > --- a/drivers/video/omap2/omapfb/omapfb-main.c > +++ b/drivers/video/omap2/omapfb/omapfb-main.c > @@ -2373,9 +2373,10 @@ static int omapfb_probe(struct platform_device *pdev) > omap_dss_get_device(dssdev); > > if (!dssdev->driver) { > - dev_err(&pdev->dev, "no driver for display: %s\n", > + dev_warn(&pdev->dev, "no driver for display: %s\n", > dssdev->name); > - r = -ENODEV; > + omap_dss_put_device(dssdev); > + continue; > } > > d = &fbdev->displays[fbdev->num_displays++]; > -- > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
WARNING: multiple messages have this Message-ID (diff)
From: Jaya Kumar <jayakumar.lkml@gmail.com> To: Tomi Valkeinen <tomi.valkeinen@ti.com> Cc: linux-omap@vger.kernel.org, linux-fbdev@vger.kernel.org, archit@ti.com Subject: Re: [PATCH 1/4] OMAP: OMAPFB: make omapfb start even when a display is missing a driver Date: Sat, 27 Aug 2011 18:28:46 +0800 [thread overview] Message-ID: <CADqH6VybU7=rSAobaOKbvGwHouLeWuGwbUrc70xKgusE_+rqzQ@mail.gmail.com> (raw) In-Reply-To: <1314001636-18036-2-git-send-email-tomi.valkeinen@ti.com> On Mon, Aug 22, 2011 at 4:27 PM, Tomi Valkeinen <tomi.valkeinen@ti.com> wrote: > Currently omapfb wants that all the display devices have a driver, > otherwise omapfb refuses to start. There's no real requirement to act > like that, and this patch will make omapfb give a warning and skip that > device. Hi Tomi, Just a question, I am working with an out-of-tree hdmi driver for the NXP TDA9984 with dm3730. This worked fine in 2.6.32 as a runtime loaded dss display driver. That is: +static struct omap_dss_device wiser2_hdmi_device = { + .type = OMAP_DISPLAY_TYPE_DPI, + .name = "hdmi", + .driver_name = "hdmi_panel", + .phy.dpi.data_lines = 24, + .platform_enable = wiser2_enable_hdmi, + .platform_disable = wiser2_disable_hdmi, +}; + +static struct omap_dss_device wiser2_tv_device = { + .name = "tv", + .driver_name = "venc", + .type = OMAP_DISPLAY_TYPE_VENC, + .phy.venc.type = OMAP_DSS_VENC_TYPE_SVIDEO, + .platform_enable = wiser2_panel_enable_tv, + .platform_disable = wiser2_panel_disable_tv, +}; + +static struct omap_dss_device *wiser2_dss_devices[] = { + &wiser2_dvi_device, + &wiser2_tv_device, + &wiser2_hdmi_device, +}; so this hdmi_panel omap_dss_driver was being insmoded after init at bootup and it worked fine, no problems with omaplfb so pvr stuff worked fine. I then switched to 2.6.37 (from TI devkit 2.1 gingerbread) and this kernel wasn't so happy (panic at boot). I applied your patch below. I also figured out that omap_vout had a similar problem as the one you've fixed which was what was causing the panic (omap_vout tries to call display->driver->update without checking if driver exists): diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c index 2aee372..36d69db 100644 --- a/drivers/media/video/omap/omap_vout.c +++ b/drivers/media/video/omap/omap_vout.c @@ -2574,24 +2591,32 @@ static int __init omap_vout_probe(struct platform_device *pdev) + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); for (i = 0; i < vid_dev->num_displays; i++) { struct omap_dss_device *display = vid_dev->displays[i]; - if (display->driver->update) + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); + if ((display->driver) && (display->driver->update)) { + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); display->driver->update(display, 0, 0, display->panel.timings.x_res, display->panel.timings.y_res); + } + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); } + printk(KERN_INFO "%s:%d\n", __func__, __LINE__); return 0; After that change, it boots up cleanly but I don't get any display output. I noticed that: echo 1 > /sys/devices/omapdss/display2/enabled no longer works. display2 stays enabled=0 rather than coming on. I'm planning on debugging this some more when I have some free time. But I figured I should ask first if this is a known problem, whether anyone else is testing runtime loaded omap_dss_driver stuff and if anyone has gotten it to work with kernels 2.6.37 and above. Thanks, jaya > > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com> > --- > drivers/video/omap2/omapfb/omapfb-main.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/omap2/omapfb/omapfb-main.c b/drivers/video/omap2/omapfb/omapfb-main.c > index e5a64b3..cd2cae8e 100644 > --- a/drivers/video/omap2/omapfb/omapfb-main.c > +++ b/drivers/video/omap2/omapfb/omapfb-main.c > @@ -2373,9 +2373,10 @@ static int omapfb_probe(struct platform_device *pdev) > omap_dss_get_device(dssdev); > > if (!dssdev->driver) { > - dev_err(&pdev->dev, "no driver for display: %s\n", > + dev_warn(&pdev->dev, "no driver for display: %s\n", > dssdev->name); > - r = -ENODEV; > + omap_dss_put_device(dssdev); > + continue; > } > > d = &fbdev->displays[fbdev->num_displays++]; > -- > 1.7.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-27 10:28 UTC|newest] Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-22 8:27 [PATCH 0/4] OMAPDSS: misc minor fixes Tomi Valkeinen 2011-08-22 8:27 ` Tomi Valkeinen 2011-08-22 8:27 ` [PATCH 1/4] OMAP: OMAPFB: make omapfb start even when a display is missing a driver Tomi Valkeinen 2011-08-22 8:27 ` Tomi Valkeinen 2011-08-27 10:28 ` Jaya Kumar [this message] 2011-08-27 10:28 ` Jaya Kumar 2011-08-22 8:27 ` [PATCH 2/4] OMAP: DSS2: fix clock sources on error and uninit Tomi Valkeinen 2011-08-22 8:27 ` Tomi Valkeinen 2011-08-22 8:27 ` [PATCH 3/4] OMAP: DSS2: Handle manager change in apply Tomi Valkeinen 2011-08-22 8:27 ` Tomi Valkeinen 2011-09-02 6:50 ` Archit Taneja 2011-09-02 6:51 ` Archit Taneja 2011-09-02 7:25 ` Tomi Valkeinen 2011-09-02 7:25 ` Tomi Valkeinen 2011-09-02 7:32 ` Archit Taneja 2011-09-02 7:44 ` Archit Taneja 2011-08-22 8:27 ` [PATCH 4/4] OMAP: DSS2: Remove "EXPERIMENTAL" from Kconfig Tomi Valkeinen 2011-08-22 8:27 ` Tomi Valkeinen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CADqH6VybU7=rSAobaOKbvGwHouLeWuGwbUrc70xKgusE_+rqzQ@mail.gmail.com' \ --to=jayakumar.lkml@gmail.com \ --cc=archit@ti.com \ --cc=linux-fbdev@vger.kernel.org \ --cc=linux-omap@vger.kernel.org \ --cc=tomi.valkeinen@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.