[Buildroot] [PATCH 1/5] package/libsoup: add optional dependency for gobject-introspection

[Buildroot] [PATCH 1/5] package/libsoup: add optional dependency for gobject-introspection

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

If gobject-introspection is selected, explicitly set --with-introspection in
the configure options and add a dependency for gobject-introspection.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/libsoup/libsoup.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/libsoup/libsoup.mk b/package/libsoup/libsoup.mk
index 95bd682010..07c9d787bd 100644
--- a/package/libsoup/libsoup.mk
+++ b/package/libsoup/libsoup.mk
@@ -16,6 +16,13 @@ LIBSOUP_CONF_OPTS = --disable-glibtest --enable-vala=no --with-gssapi=no
 LIBSOUP_DEPENDENCIES = host-pkgconf host-libglib2 \
 	libglib2 libxml2 sqlite host-intltool
 
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+LIBSOUP_CONF_OPTS += --with-introspection
+LIBSOUP_DEPENDENCIES += gobject-introspection
+else
+LIBSOUP_CONF_OPTS += --without-introspection
+endif
+
 ifeq ($(BR2_PACKAGE_LIBSOUP_GNOME),y)
 LIBSOUP_CONF_OPTS += --with-gnome
 else
-- 
2.24.1

[Buildroot] [PATCH 2/5] package/gssdp: add optional dependency for gobject-introspection

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

If gobject-introspection is selected, explicitly set -Dintrospection=true in
the configure options and add a dependency for gobject-introspection.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/gssdp/gssdp.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/gssdp/gssdp.mk b/package/gssdp/gssdp.mk
index 071ad00109..bab3cbe0f7 100644
--- a/package/gssdp/gssdp.mk
+++ b/package/gssdp/gssdp.mk
@@ -14,9 +14,15 @@ GSSDP_INSTALL_STAGING = YES
 GSSDP_DEPENDENCIES = host-pkgconf libglib2 libsoup
 GSSDP_CONF_OPTS = \
 	-Dexamples=false \
-	-Dintrospection=false \
 	-Dvapi=false
 
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+GSSDP_CONF_OPTS += -Dintrospection=true
+GSSDP_DEPENDENCIES += gobject-introspection
+else
+GSSDP_CONF_OPTS += -Dintrospection=false
+endif
+
 ifeq ($(BR2_PACKAGE_LIBGTK3),y)
 GSSDP_DEPENDENCIES += libgtk3
 GSSDP_CONF_OPTS += -Dsniffer=true
-- 
2.24.1

[Buildroot] [PATCH 3/5] package/gupnp: add optional dependency for gobject-introspection

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

If gobject-introspection is selected, explicitly set --enable-introspection in
the configure options and add a dependency for gobject-introspection.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/gupnp/gupnp.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/gupnp/gupnp.mk b/package/gupnp/gupnp.mk
index 27486b09fa..75bbfa8d1d 100644
--- a/package/gupnp/gupnp.mk
+++ b/package/gupnp/gupnp.mk
@@ -12,6 +12,12 @@ GUPNP_LICENSE = LGPL-2.0+
 GUPNP_LICENSE_FILES = COPYING
 GUPNP_INSTALL_STAGING = YES
 GUPNP_DEPENDENCIES = host-pkgconf libglib2 libxml2 gssdp util-linux
-GUPNP_CONF_OPTS = --disable-introspection
+
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+GUPNP_CONF_OPTS += --enable-introspection
+GUPNP_DEPENDENCIES += gobject-introspection
+else
+GUPNP_CONF_OPTS += --disable-introspection
+endif
 
 $(eval $(autotools-package))
-- 
2.24.1

[Buildroot] [PATCH 4/5] package/gupnp-dlna: add optional dependency for gobject-introspection

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

If gobject-introspection is selected, explicitly set --enable-introspection in
the configure options and add a dependency for gobject-introspection.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/gupnp-dlna/gupnp-dlna.mk | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/package/gupnp-dlna/gupnp-dlna.mk b/package/gupnp-dlna/gupnp-dlna.mk
index 85d30b7cd2..6ce20c15fd 100644
--- a/package/gupnp-dlna/gupnp-dlna.mk
+++ b/package/gupnp-dlna/gupnp-dlna.mk
@@ -16,9 +16,15 @@ GUPNP_DLNA_INSTALL_STAGING = YES
 GUPNP_DLNA_DEPENDENCIES = host-pkgconf libglib2 libxml2
 
 GUPNP_DLNA_CONF_OPTS = \
-	--disable-introspection \
 	--disable-legacy-gstreamer-metadata-backend
 
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+GUPNP_DLNA_CONF_OPTS += --enable-introspection
+GUPNP_DLNA_DEPENDENCIES += gobject-introspection
+else
+GUPNP_DLNA_CONF_OPTS += --disable-introspection
+endif
+
 ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE),y)
 GUPNP_DLNA_CONF_OPTS += --enable-gstreamer-metadata-backend
 GUPNP_DLNA_DEPENDENCIES += gstreamer1 gst1-plugins-base
-- 
2.24.1

[Buildroot] [PATCH 5/5] package/gupnp-av: add optional dependency for gobject-introspection

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

If gobject-introspection is selected, explicitly set --enable-introspection in
the configure options and add a dependency for gobject-introspection.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 package/gupnp-av/gupnp-av.mk | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/package/gupnp-av/gupnp-av.mk b/package/gupnp-av/gupnp-av.mk
index c670ab6d43..55436d0e53 100644
--- a/package/gupnp-av/gupnp-av.mk
+++ b/package/gupnp-av/gupnp-av.mk
@@ -13,4 +13,11 @@ GUPNP_AV_LICENSE_FILES = COPYING
 GUPNP_AV_INSTALL_STAGING = YES
 GUPNP_AV_DEPENDENCIES = host-pkgconf libglib2 libxml2 gupnp
 
+ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
+GUPNP_AV_CONF_OPTS += --enable-introspection
+GUPNP_AV_DEPENDENCIES += gobject-introspection
+else
+GUPNP_AV_CONF_OPTS += --disable-introspection
+endif
+
 $(eval $(autotools-package))
-- 
2.24.1

[Buildroot] [PATCH 4/5] package/gupnp-dlna: add optional dependency for gobject-introspection

[Fabrice Fontaine]

Dear Adam,

Le dim. 15 mars 2020 ? 18:25, <aduskett@gmail.com> a ?crit :
>
> From: Adam Duskett <Aduskett@gmail.com>
>
> If gobject-introspection is selected, explicitly set --enable-introspection in
> the configure options and add a dependency for gobject-introspection.
>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
>  package/gupnp-dlna/gupnp-dlna.mk | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/package/gupnp-dlna/gupnp-dlna.mk b/package/gupnp-dlna/gupnp-dlna.mk
> index 85d30b7cd2..6ce20c15fd 100644
> --- a/package/gupnp-dlna/gupnp-dlna.mk
> +++ b/package/gupnp-dlna/gupnp-dlna.mk
> @@ -16,9 +16,15 @@ GUPNP_DLNA_INSTALL_STAGING = YES
>  GUPNP_DLNA_DEPENDENCIES = host-pkgconf libglib2 libxml2
>
>  GUPNP_DLNA_CONF_OPTS = \
> -       --disable-introspection \
>         --disable-legacy-gstreamer-metadata-backend
>
> +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> +GUPNP_DLNA_CONF_OPTS += --enable-introspection
> +GUPNP_DLNA_DEPENDENCIES += gobject-introspection
> +else
> +GUPNP_DLNA_CONF_OPTS += --disable-introspection
> +endif
I tried to enable introspection on gupnp-dlna and it fails due to
missing Gst-1.0.gir which is provided by gstreamer1 under the
following condition:
build_gir = gir.found() and not meson.is_cross_build()

So, before enabling introspection on gupnp-dlna, gstreamer1's
meson.build will have to be patched .
I tried to do that but I got a build failure.
> +
>  ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE),y)
>  GUPNP_DLNA_CONF_OPTS += --enable-gstreamer-metadata-backend
>  GUPNP_DLNA_DEPENDENCIES += gstreamer1 gst1-plugins-base
> --
> 2.24.1
>
Best Regards,

Fabrice

[Buildroot] [PATCH 4/5] package/gupnp-dlna: add optional dependency for gobject-introspection

[Adam Duskett]

Fabrice;

That's quite odd! I must have had gstreamer1 built when I tested this.
I will issue a fix shortly.

On Sun, Mar 15, 2020 at 10:38 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Dear Adam,
>
> Le dim. 15 mars 2020 ? 18:25, <aduskett@gmail.com> a ?crit :
> >
> > From: Adam Duskett <Aduskett@gmail.com>
> >
> > If gobject-introspection is selected, explicitly set --enable-introspection in
> > the configure options and add a dependency for gobject-introspection.
> >
> > Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> > ---
> >  package/gupnp-dlna/gupnp-dlna.mk | 8 +++++++-
> >  1 file changed, 7 insertions(+), 1 deletion(-)
> >
> > diff --git a/package/gupnp-dlna/gupnp-dlna.mk b/package/gupnp-dlna/gupnp-dlna.mk
> > index 85d30b7cd2..6ce20c15fd 100644
> > --- a/package/gupnp-dlna/gupnp-dlna.mk
> > +++ b/package/gupnp-dlna/gupnp-dlna.mk
> > @@ -16,9 +16,15 @@ GUPNP_DLNA_INSTALL_STAGING = YES
> >  GUPNP_DLNA_DEPENDENCIES = host-pkgconf libglib2 libxml2
> >
> >  GUPNP_DLNA_CONF_OPTS = \
> > -       --disable-introspection \
> >         --disable-legacy-gstreamer-metadata-backend
> >
> > +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> > +GUPNP_DLNA_CONF_OPTS += --enable-introspection
> > +GUPNP_DLNA_DEPENDENCIES += gobject-introspection
> > +else
> > +GUPNP_DLNA_CONF_OPTS += --disable-introspection
> > +endif
> I tried to enable introspection on gupnp-dlna and it fails due to
> missing Gst-1.0.gir which is provided by gstreamer1 under the
> following condition:
> build_gir = gir.found() and not meson.is_cross_build()
>
> So, before enabling introspection on gupnp-dlna, gstreamer1's
> meson.build will have to be patched .
> I tried to do that but I got a build failure.
> > +
> >  ifeq ($(BR2_PACKAGE_GST1_PLUGINS_BASE),y)
> >  GUPNP_DLNA_CONF_OPTS += --enable-gstreamer-metadata-backend
> >  GUPNP_DLNA_DEPENDENCIES += gstreamer1 gst1-plugins-base
> > --
> > 2.24.1
> >
> Best Regards,
>
> Fabrice

[Buildroot] [PATCH 1/5] package/libsoup: add optional dependency for gobject-introspection

[Yann E. MORIN]

Adam, All,

On 2020-03-15 10:24 -0700, aduskett at gmail.com spake thusly:
> From: Adam Duskett <Aduskett@gmail.com>
> 
> If gobject-introspection is selected, explicitly set --with-introspection in
> the configure options and add a dependency for gobject-introspection.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>

Series applied to master, except for path 4 which had a review by
Fabrice and thus needs some more work. Thanks! :-)

Regards,
Yann E. MORIN.

> ---
>  package/libsoup/libsoup.mk | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/package/libsoup/libsoup.mk b/package/libsoup/libsoup.mk
> index 95bd682010..07c9d787bd 100644
> --- a/package/libsoup/libsoup.mk
> +++ b/package/libsoup/libsoup.mk
> @@ -16,6 +16,13 @@ LIBSOUP_CONF_OPTS = --disable-glibtest --enable-vala=no --with-gssapi=no
>  LIBSOUP_DEPENDENCIES = host-pkgconf host-libglib2 \
>  	libglib2 libxml2 sqlite host-intltool
>  
> +ifeq ($(BR2_PACKAGE_GOBJECT_INTROSPECTION),y)
> +LIBSOUP_CONF_OPTS += --with-introspection
> +LIBSOUP_DEPENDENCIES += gobject-introspection
> +else
> +LIBSOUP_CONF_OPTS += --without-introspection
> +endif
> +
>  ifeq ($(BR2_PACKAGE_LIBSOUP_GNOME),y)
>  LIBSOUP_CONF_OPTS += --with-gnome
>  else
> -- 
> 2.24.1
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH 2/5] package/gssdp: add optional dependency for gobject-introspection

[Thomas Petazzoni]

Hello,

On Sun, 15 Mar 2020 10:24:55 -0700
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> If gobject-introspection is selected, explicitly set -Dintrospection=true in
> the configure options and add a dependency for gobject-introspection.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>

The build of gssdp is broken with introspection support:

  /bin/sh: 1: /home/buildroot/autobuild/instance-2/output-1/host/bin/../nios2-buildroot-linux-gnu/sysroot/home/buildroot/autobuild/instance-2/output-1/host/bin/g-ir-scanner: not found

Could you have a look ?

I am wondering if this couldn't be a fallout of the recent changes in
the pkg-config Meson logic.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 2/5] package/gssdp: add optional dependency for gobject-introspection

[Fabrice Fontaine]

Hi Thomas,

Le lun. 11 mai 2020 ? 07:19, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> Hello,
>
> On Sun, 15 Mar 2020 10:24:55 -0700
> aduskett at gmail.com wrote:
>
> > From: Adam Duskett <Aduskett@gmail.com>
> >
> > If gobject-introspection is selected, explicitly set -Dintrospection=true in
> > the configure options and add a dependency for gobject-introspection.
> >
> > Signed-off-by: Adam Duskett <Aduskett@gmail.com>
>
> The build of gssdp is broken with introspection support:
>
>   /bin/sh: 1: /home/buildroot/autobuild/instance-2/output-1/host/bin/../nios2-buildroot-linux-gnu/sysroot/home/buildroot/autobuild/instance-2/output-1/host/bin/g-ir-scanner: not found
>
> Could you have a look ?
>
> I am wondering if this couldn't be a fallout of the recent changes in
> the pkg-config Meson logic.
James sent a patch that fix this build failure:
https://patchwork.ozlabs.org/project/buildroot/patch/20200502060435.23004-1-james.hilliard1 at gmail.com.
The patch sent by James is fixing atk as well as many other meson
packages such as gssdp. However, it seems there was some debate on
this patch.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice

[Buildroot] [PATCH 2/5] package/gssdp: add optional dependency for gobject-introspection

[Fabrice Fontaine]

Hi all,

Le lun. 11 mai 2020 ? 09:02, Fabrice Fontaine
<fontaine.fabrice@gmail.com> a ?crit :
>
> Hi Thomas,
>
> Le lun. 11 mai 2020 ? 07:19, Thomas Petazzoni
> <thomas.petazzoni@bootlin.com> a ?crit :
> >
> > Hello,
> >
> > On Sun, 15 Mar 2020 10:24:55 -0700
> > aduskett at gmail.com wrote:
> >
> > > From: Adam Duskett <Aduskett@gmail.com>
> > >
> > > If gobject-introspection is selected, explicitly set -Dintrospection=true in
> > > the configure options and add a dependency for gobject-introspection.
> > >
> > > Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> >
> > The build of gssdp is broken with introspection support:
> >
> >   /bin/sh: 1: /home/buildroot/autobuild/instance-2/output-1/host/bin/../nios2-buildroot-linux-gnu/sysroot/home/buildroot/autobuild/instance-2/output-1/host/bin/g-ir-scanner: not found
> >
> > Could you have a look ?
> >
> > I am wondering if this couldn't be a fallout of the recent changes in
> > the pkg-config Meson logic.
> James sent a patch that fix this build failure:
> https://patchwork.ozlabs.org/project/buildroot/patch/20200502060435.23004-1-james.hilliard1 at gmail.com.
> The patch sent by James is fixing atk as well as many other meson
> packages such as gssdp. However, it seems there was some debate on
> this patch.It seems that James suggested that a better solution would be to patch meson. This proposal was merged by meson a few days ago:
https://github.com/mesonbuild/meson/pull/7072/commits/0aa52b538fa678e2da1d0dedff800408e5e7afbb
James, could you provide a v2 of your patch?
> >
> > Thomas
> > --
> > Thomas Petazzoni, CTO, Bootlin
> > Embedded Linux and Kernel engineering
> > https://bootlin.com
> Best Regards,
>
> Fabrice
Best Regards,

Fabrice

[Buildroot] [PATCH 2/5] package/gssdp: add optional dependency for gobject-introspection

[James Hilliard]

On Mon, May 11, 2020 at 1:18 AM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Hi all,
>
> Le lun. 11 mai 2020 ? 09:02, Fabrice Fontaine
> <fontaine.fabrice@gmail.com> a ?crit :
> >
> > Hi Thomas,
> >
> > Le lun. 11 mai 2020 ? 07:19, Thomas Petazzoni
> > <thomas.petazzoni@bootlin.com> a ?crit :
> > >
> > > Hello,
> > >
> > > On Sun, 15 Mar 2020 10:24:55 -0700
> > > aduskett at gmail.com wrote:
> > >
> > > > From: Adam Duskett <Aduskett@gmail.com>
> > > >
> > > > If gobject-introspection is selected, explicitly set -Dintrospection=true in
> > > > the configure options and add a dependency for gobject-introspection.
> > > >
> > > > Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> > >
> > > The build of gssdp is broken with introspection support:
> > >
> > >   /bin/sh: 1: /home/buildroot/autobuild/instance-2/output-1/host/bin/../nios2-buildroot-linux-gnu/sysroot/home/buildroot/autobuild/instance-2/output-1/host/bin/g-ir-scanner: not found
> > >
> > > Could you have a look ?
> > >
> > > I am wondering if this couldn't be a fallout of the recent changes in
> > > the pkg-config Meson logic.
> > James sent a patch that fix this build failure:
> > https://patchwork.ozlabs.org/project/buildroot/patch/20200502060435.23004-1-james.hilliard1 at gmail.com.
> > The patch sent by James is fixing atk as well as many other meson
> > packages such as gssdp. However, it seems there was some debate on
> > this patch.It seems that James suggested that a better solution would be to patch meson. This proposal was merged by meson a few days ago:
> https://github.com/mesonbuild/meson/pull/7072/commits/0aa52b538fa678e2da1d0dedff800408e5e7afbb
> James, could you provide a v2 of your patch?
I was waiting on it to get included in a meson release since it doesn't apply
to the latest release, seems the gnome module has been refactored quite
a bit since 0.54.1.
> > >
> > > Thomas
> > > --
> > > Thomas Petazzoni, CTO, Bootlin
> > > Embedded Linux and Kernel engineering
> > > https://bootlin.com
> > Best Regards,
> >
> > Fabrice
> Best Regards,
>
> Fabrice