All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/ca-certificates: add missing host-python3-six dependency
@ 2021-11-01 13:33 Romain Naour
  2021-11-02  3:20 ` James Hilliard
  0 siblings, 1 reply; 4+ messages in thread
From: Romain Naour @ 2021-11-01 13:33 UTC (permalink / raw)
  To: buildroot; +Cc: Romain Naour, Martin Bark

ca-certificates use some python scripts during the build step that
requires python-six for host-python3.

python3 certdata2pem.py
Traceback (most recent call last):
  File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/build/ca-certificates-20211016/mozilla/certdata2pem.py", line 31, in <module>
    from cryptography import x509
  File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/host/lib/python3.9/site-packages/cryptography/x509/__init__.py", line 7, in <module>
    from cryptography.x509 import certificate_transparency
  File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/host/lib/python3.9/site-packages/cryptography/x509/certificate_transparency.py", line 10, in <module>
    import six
ModuleNotFoundError: No module named 'six'

Fixes:
https://gitlab.com/buildroot.org/buildroot/-/jobs/1734417711
http://autobuild.buildroot.net/results/d14/d145f997cc6db17a8eab14d9ced8fa35332c4969/build-end.log

Signed-off-by: Romain Naour <romain.naour@gmail.com>
Cc: Martin Bark <martin@barkynet.com>
---
 package/ca-certificates/ca-certificates.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/package/ca-certificates/ca-certificates.mk b/package/ca-certificates/ca-certificates.mk
index eb75d23f44..e21ac5d907 100644
--- a/package/ca-certificates/ca-certificates.mk
+++ b/package/ca-certificates/ca-certificates.mk
@@ -7,7 +7,7 @@
 CA_CERTIFICATES_VERSION = 20211016
 CA_CERTIFICATES_SOURCE = ca-certificates_$(CA_CERTIFICATES_VERSION).tar.xz
 CA_CERTIFICATES_SITE = https://snapshot.debian.org/archive/debian/20211022T144903Z/pool/main/c/ca-certificates
-CA_CERTIFICATES_DEPENDENCIES = host-openssl host-python3 host-python-cryptography
+CA_CERTIFICATES_DEPENDENCIES = host-openssl host-python3 host-python3-six host-python-cryptography
 CA_CERTIFICATES_LICENSE = GPL-2.0+ (script), MPL-2.0 (data)
 CA_CERTIFICATES_LICENSE_FILES = debian/copyright
 
-- 
2.31.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/ca-certificates: add missing host-python3-six dependency
  2021-11-01 13:33 [Buildroot] [PATCH] package/ca-certificates: add missing host-python3-six dependency Romain Naour
@ 2021-11-02  3:20 ` James Hilliard
  2021-11-03 19:36   ` Peter Seiderer
  0 siblings, 1 reply; 4+ messages in thread
From: James Hilliard @ 2021-11-02  3:20 UTC (permalink / raw)
  To: Romain Naour; +Cc: Martin Bark, buildroot

On Mon, Nov 1, 2021 at 7:34 AM Romain Naour <romain.naour@gmail.com> wrote:
>
> ca-certificates use some python scripts during the build step that
> requires python-six for host-python3.
>
> python3 certdata2pem.py
> Traceback (most recent call last):
>   File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/build/ca-certificates-20211016/mozilla/certdata2pem.py", line 31, in <module>
>     from cryptography import x509
>   File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/host/lib/python3.9/site-packages/cryptography/x509/__init__.py", line 7, in <module>
>     from cryptography.x509 import certificate_transparency
>   File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/host/lib/python3.9/site-packages/cryptography/x509/certificate_transparency.py", line 10, in <module>
>     import six
> ModuleNotFoundError: No module named 'six'

The failure appears to come from a missing cryptography dependency
so I think my fix in python-cryptography may be better:
https://patchwork.ozlabs.org/project/buildroot/patch/20211029065957.3084528-1-james.hilliard1@gmail.com/

>
> Fixes:
> https://gitlab.com/buildroot.org/buildroot/-/jobs/1734417711
> http://autobuild.buildroot.net/results/d14/d145f997cc6db17a8eab14d9ced8fa35332c4969/build-end.log
>
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
> Cc: Martin Bark <martin@barkynet.com>
> ---
>  package/ca-certificates/ca-certificates.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/ca-certificates/ca-certificates.mk b/package/ca-certificates/ca-certificates.mk
> index eb75d23f44..e21ac5d907 100644
> --- a/package/ca-certificates/ca-certificates.mk
> +++ b/package/ca-certificates/ca-certificates.mk
> @@ -7,7 +7,7 @@
>  CA_CERTIFICATES_VERSION = 20211016
>  CA_CERTIFICATES_SOURCE = ca-certificates_$(CA_CERTIFICATES_VERSION).tar.xz
>  CA_CERTIFICATES_SITE = https://snapshot.debian.org/archive/debian/20211022T144903Z/pool/main/c/ca-certificates
> -CA_CERTIFICATES_DEPENDENCIES = host-openssl host-python3 host-python-cryptography
> +CA_CERTIFICATES_DEPENDENCIES = host-openssl host-python3 host-python3-six host-python-cryptography
>  CA_CERTIFICATES_LICENSE = GPL-2.0+ (script), MPL-2.0 (data)
>  CA_CERTIFICATES_LICENSE_FILES = debian/copyright
>
> --
> 2.31.1
>
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/ca-certificates: add missing host-python3-six dependency
  2021-11-02  3:20 ` James Hilliard
@ 2021-11-03 19:36   ` Peter Seiderer
  2021-11-03 21:01     ` Romain Naour
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Seiderer @ 2021-11-03 19:36 UTC (permalink / raw)
  To: James Hilliard; +Cc: Romain Naour, Martin Bark, buildroot

Hello James, Hilliard,

On Mon, 1 Nov 2021 21:20:10 -0600, James Hilliard <james.hilliard1@gmail.com> wrote:

> On Mon, Nov 1, 2021 at 7:34 AM Romain Naour <romain.naour@gmail.com> wrote:
> >
> > ca-certificates use some python scripts during the build step that
> > requires python-six for host-python3.
> >
> > python3 certdata2pem.py
> > Traceback (most recent call last):
> >   File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/build/ca-certificates-20211016/mozilla/certdata2pem.py", line 31, in <module>
> >     from cryptography import x509
> >   File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/host/lib/python3.9/site-packages/cryptography/x509/__init__.py", line 7, in <module>
> >     from cryptography.x509 import certificate_transparency
> >   File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/host/lib/python3.9/site-packages/cryptography/x509/certificate_transparency.py", line 10, in <module>
> >     import six
> > ModuleNotFoundError: No module named 'six'
>
> The failure appears to come from a missing cryptography dependency
> so I think my fix in python-cryptography may be better:
> https://patchwork.ozlabs.org/project/buildroot/patch/20211029065957.3084528-1-james.hilliard1@gmail.com/

Accord with James as the backtrace shows the 'import six' from the cryptography
package...

Regards,
Peter

>
> >
> > Fixes:
> > https://gitlab.com/buildroot.org/buildroot/-/jobs/1734417711
> > http://autobuild.buildroot.net/results/d14/d145f997cc6db17a8eab14d9ced8fa35332c4969/build-end.log
> >
> > Signed-off-by: Romain Naour <romain.naour@gmail.com>
> > Cc: Martin Bark <martin@barkynet.com>
> > ---
> >  package/ca-certificates/ca-certificates.mk | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/ca-certificates/ca-certificates.mk b/package/ca-certificates/ca-certificates.mk
> > index eb75d23f44..e21ac5d907 100644
> > --- a/package/ca-certificates/ca-certificates.mk
> > +++ b/package/ca-certificates/ca-certificates.mk
> > @@ -7,7 +7,7 @@
> >  CA_CERTIFICATES_VERSION = 20211016
> >  CA_CERTIFICATES_SOURCE = ca-certificates_$(CA_CERTIFICATES_VERSION).tar.xz
> >  CA_CERTIFICATES_SITE = https://snapshot.debian.org/archive/debian/20211022T144903Z/pool/main/c/ca-certificates
> > -CA_CERTIFICATES_DEPENDENCIES = host-openssl host-python3 host-python-cryptography
> > +CA_CERTIFICATES_DEPENDENCIES = host-openssl host-python3 host-python3-six host-python-cryptography
> >  CA_CERTIFICATES_LICENSE = GPL-2.0+ (script), MPL-2.0 (data)
> >  CA_CERTIFICATES_LICENSE_FILES = debian/copyright
> >
> > --
> > 2.31.1
> >
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [Buildroot] [PATCH] package/ca-certificates: add missing host-python3-six dependency
  2021-11-03 19:36   ` Peter Seiderer
@ 2021-11-03 21:01     ` Romain Naour
  0 siblings, 0 replies; 4+ messages in thread
From: Romain Naour @ 2021-11-03 21:01 UTC (permalink / raw)
  To: Peter Seiderer, James Hilliard; +Cc: Martin Bark, buildroot

Hello James, Peter,

Le 03/11/2021 à 20:36, Peter Seiderer a écrit :
> Hello James, Hilliard,
> 
> On Mon, 1 Nov 2021 21:20:10 -0600, James Hilliard <james.hilliard1@gmail.com> wrote:
> 
>> On Mon, Nov 1, 2021 at 7:34 AM Romain Naour <romain.naour@gmail.com> wrote:
>>>
>>> ca-certificates use some python scripts during the build step that
>>> requires python-six for host-python3.
>>>
>>> python3 certdata2pem.py
>>> Traceback (most recent call last):
>>>   File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/build/ca-certificates-20211016/mozilla/certdata2pem.py", line 31, in <module>
>>>     from cryptography import x509
>>>   File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/host/lib/python3.9/site-packages/cryptography/x509/__init__.py", line 7, in <module>
>>>     from cryptography.x509 import certificate_transparency
>>>   File "/builds/buildroot.org/buildroot/test-output/TestDockerCompose/host/lib/python3.9/site-packages/cryptography/x509/certificate_transparency.py", line 10, in <module>
>>>     import six
>>> ModuleNotFoundError: No module named 'six'
>>
>> The failure appears to come from a missing cryptography dependency
>> so I think my fix in python-cryptography may be better:
>> https://patchwork.ozlabs.org/project/buildroot/patch/20211029065957.3084528-1-james.hilliard1@gmail.com/
> 
> Accord with James as the backtrace shows the 'import six' from the cryptography
> package...

Thanks for the feedback, I'm marking this patch rejected.

Best regards,
Romain


> 
> Regards,
> Peter
> 
>>
>>>
>>> Fixes:
>>> https://gitlab.com/buildroot.org/buildroot/-/jobs/1734417711
>>> http://autobuild.buildroot.net/results/d14/d145f997cc6db17a8eab14d9ced8fa35332c4969/build-end.log
>>>
>>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>>> Cc: Martin Bark <martin@barkynet.com>
>>> ---
>>>  package/ca-certificates/ca-certificates.mk | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/package/ca-certificates/ca-certificates.mk b/package/ca-certificates/ca-certificates.mk
>>> index eb75d23f44..e21ac5d907 100644
>>> --- a/package/ca-certificates/ca-certificates.mk
>>> +++ b/package/ca-certificates/ca-certificates.mk
>>> @@ -7,7 +7,7 @@
>>>  CA_CERTIFICATES_VERSION = 20211016
>>>  CA_CERTIFICATES_SOURCE = ca-certificates_$(CA_CERTIFICATES_VERSION).tar.xz
>>>  CA_CERTIFICATES_SITE = https://snapshot.debian.org/archive/debian/20211022T144903Z/pool/main/c/ca-certificates
>>> -CA_CERTIFICATES_DEPENDENCIES = host-openssl host-python3 host-python-cryptography
>>> +CA_CERTIFICATES_DEPENDENCIES = host-openssl host-python3 host-python3-six host-python-cryptography
>>>  CA_CERTIFICATES_LICENSE = GPL-2.0+ (script), MPL-2.0 (data)
>>>  CA_CERTIFICATES_LICENSE_FILES = debian/copyright
>>>
>>> --
>>> 2.31.1
>>>
>>> _______________________________________________
>>> buildroot mailing list
>>> buildroot@buildroot.org
>>> https://lists.buildroot.org/mailman/listinfo/buildroot
>> _______________________________________________
>> buildroot mailing list
>> buildroot@buildroot.org
>> https://lists.buildroot.org/mailman/listinfo/buildroot
> 

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-11-03 21:02 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-01 13:33 [Buildroot] [PATCH] package/ca-certificates: add missing host-python3-six dependency Romain Naour
2021-11-02  3:20 ` James Hilliard
2021-11-03 19:36   ` Peter Seiderer
2021-11-03 21:01     ` Romain Naour

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.