Re: [Buildroot] [PATCH 1/1] package/bearssl: disable parallel build

From: James Hilliard <james.hilliard1@gmail.com>
To: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] package/bearssl: disable parallel build
Date: Sat, 15 Oct 2022 19:21:15 -0400	[thread overview]
Message-ID: <CADvTj4p15dWwuUN0rz4D5_tQi+UzuTdoFq76ewYh00xaULhp8A@mail.gmail.com> (raw)
In-Reply-To: <CAPi7W828RqJOB3wUx3y68PFHE+M+pt5Ohck+-E-YzPim-C54eQ@mail.gmail.com>

On Sat, Oct 15, 2022 at 6:14 PM Fabrice Fontaine
<fontaine.fabrice@gmail.com> wrote:
>
> Hi James,
>
> Le sam. 15 oct. 2022 à 02:58, James Hilliard <james.hilliard1@gmail.com> a écrit :
>>
>> The bearssl package is not compatible with parallel builds.
>
>
> bearssl was building perfectly fine up until now and it seems there are a lot of packages that are affected by parallel build issues (e.g. dmraid, musepack, slang, etc).

Some parallel build bugs don't reproduce reliably due to timing, I made a change
to my autobuilders which massively increases the chance of triggering
build failures
in packages which have dependency graph bugs. This triggers build build failures
in -j1 builds which would otherwise only appear when running parallel builds(my
autobuilders are generally running with -j1 to make the logs more readable).

> Did we change something recently on the autobuilders?

Yes, all my autobuilders were recently changed to use make master(will be
make version 4.4 once released) with top level --shuffle=random.

Details:
https://github.com/mirror/make/blob/3e20e376b7aa26fa43f81f23323c717c4cae1bfb/NEWS#L123-L128
https://trofi.github.io/posts/238-new-make-shuffle-mode.html
http://trofi.github.io/posts/249-an-update-on-make-shuffle.html

Note that MAKE1 is currently broken itself without this when using shuffle mode:
https://patchwork.ozlabs.org/project/buildroot/patch/20221015005611.4054933-1-james.hilliard1@gmail.com/

>
>>
>>
>> Fixes:
>>  - http://autobuild.buildroot.net/results/5e1/5e1b72db206b2d17fa5ce378a70fdc2f3f5bf773
>>
>> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
>> ---
>>  package/bearssl/bearssl.mk | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/package/bearssl/bearssl.mk b/package/bearssl/bearssl.mk
>> index ff5f4e87b7..c2a5760af5 100644
>> --- a/package/bearssl/bearssl.mk
>> +++ b/package/bearssl/bearssl.mk
>> @@ -24,7 +24,7 @@ BEARSSL_TARGETS += lib
>>  endif
>>
>>  define BEARSSL_BUILD_CMDS
>> -       $(TARGET_MAKE_ENV) $(MAKE) $(BEARSSL_MAKE_OPTS) -C $(@D) \
>> +       $(TARGET_MAKE_ENV) $(MAKE1) $(BEARSSL_MAKE_OPTS) -C $(@D) \
>>                 $(BEARSSL_TARGETS)
>>  endef
>>
>> --
>> 2.34.1
>>
> Best Regards,
>
> Fabrice
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot