Re: [Buildroot] [PATCH 1/1] package/bearssl: disable parallel build

[James Hilliard <james.hilliard1@gmail.com>]

On Sun, Oct 16, 2022 at 3:51 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote:
>
> James, All,
>
> On 2022-10-15 19:21 -0400, James Hilliard spake thusly:
> > On Sat, Oct 15, 2022 at 6:14 PM Fabrice Fontaine
> > <fontaine.fabrice@gmail.com> wrote:
> > > Le sam. 15 oct. 2022 à 02:58, James Hilliard <james.hilliard1@gmail.com> a écrit :
> > >> The bearssl package is not compatible with parallel builds.
> > > bearssl was building perfectly fine up until now and it seems there
> > > are a lot of packages that are affected by parallel build issues
> > > (e.g. dmraid, musepack, slang, etc).
> >
> > Some parallel build bugs don't reproduce reliably due to timing, I made a change
> > to my autobuilders which massively increases the chance of triggering
> > build failures
> > in packages which have dependency graph bugs. This triggers build build failures
> > in -j1 builds which would otherwise only appear when running parallel builds(my
> > autobuilders are generally running with -j1 to make the logs more readable).
> >
> > > Did we change something recently on the autobuilders?
> >
> > Yes, all my autobuilders were recently changed to use make master(will be
> > make version 4.4 once released) with top level --shuffle=random.
>
> By disabling parallel build because you are using ana as yet unreleased
> version, we remove the parallel build for everyone, which is not very
> nice at all.

Failures with shuffle mode indicate that the package is not parallel compatible
on existing make releases as well, it just makes those bugs more visible.

I'm running shuffle with -j1 because that way it's obvious in the logs where the
failure is getting hit, otherwise these bugs tend to be transient and
difficult to
trace as they otherwise are timing dependent.

>
> Instead, we should really try and fix the packages rather than papering
> over the issue.
>
> Notes:
>   - it *is* interesting to find those bugs;
>   - it is sad that the default mode for --shuffle will be random, not
>     none.

Default is equivalent to none, I modified my autobuilder runner to pass
--shuffle=random.

>
> Regards,
> Yann E. MORIN.
>
> > Details:
> > https://github.com/mirror/make/blob/3e20e376b7aa26fa43f81f23323c717c4cae1bfb/NEWS#L123-L128
> > https://trofi.github.io/posts/238-new-make-shuffle-mode.html
> > http://trofi.github.io/posts/249-an-update-on-make-shuffle.html
> >
> > Note that MAKE1 is currently broken itself without this when using shuffle mode:
> > https://patchwork.ozlabs.org/project/buildroot/patch/20221015005611.4054933-1-james.hilliard1@gmail.com/
> >
> > >
> > >>
> > >>
> > >> Fixes:
> > >>  - http://autobuild.buildroot.net/results/5e1/5e1b72db206b2d17fa5ce378a70fdc2f3f5bf773
> > >>
> > >> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > >> ---
> > >>  package/bearssl/bearssl.mk | 2 +-
> > >>  1 file changed, 1 insertion(+), 1 deletion(-)
> > >>
> > >> diff --git a/package/bearssl/bearssl.mk b/package/bearssl/bearssl.mk
> > >> index ff5f4e87b7..c2a5760af5 100644
> > >> --- a/package/bearssl/bearssl.mk
> > >> +++ b/package/bearssl/bearssl.mk
> > >> @@ -24,7 +24,7 @@ BEARSSL_TARGETS += lib
> > >>  endif
> > >>
> > >>  define BEARSSL_BUILD_CMDS
> > >> -       $(TARGET_MAKE_ENV) $(MAKE) $(BEARSSL_MAKE_OPTS) -C $(@D) \
> > >> +       $(TARGET_MAKE_ENV) $(MAKE1) $(BEARSSL_MAKE_OPTS) -C $(@D) \
> > >>                 $(BEARSSL_TARGETS)
> > >>  endef
> > >>
> > >> --
> > >> 2.34.1
> > >>
> > > Best Regards,
> > >
> > > Fabrice
> > _______________________________________________
> > buildroot mailing list
> > buildroot@buildroot.org
> > https://lists.buildroot.org/mailman/listinfo/buildroot
>
> --
> .-----------------.--------------------.------------------.--------------------.
> |  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
> | +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
> | +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
> | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
> '------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot