[Buildroot] [PATCH 1/1] package/swupdate: add optional systemd dependency

[Buildroot] [PATCH 1/1] package/swupdate: add optional systemd dependency

[James Hilliard]

Fixes:
core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
   27 | #include <systemd/sd-daemon.h>
      |          ^~~~~~~~~~~~~~~~~~~~~

Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
---
 package/swupdate/swupdate.mk | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/swupdate/swupdate.mk b/package/swupdate/swupdate.mk
index 237a44e233..2b51edb66d 100644
--- a/package/swupdate/swupdate.mk
+++ b/package/swupdate/swupdate.mk
@@ -110,6 +110,10 @@ SWUPDATE_MAKE_ENV += HAVE_MBEDTLS=n
 endif
 endif
 
+ifeq ($(BR2_PACKAGE_SYSTEMD),y)
+SWUPDATE_DEPENDENCIES += systemd
+endif
+
 ifeq ($(BR2_PACKAGE_UBOOT_TOOLS),y)
 SWUPDATE_DEPENDENCIES += uboot-tools
 SWUPDATE_MAKE_ENV += HAVE_LIBUBOOTENV=y
-- 
2.20.1

[Buildroot] [PATCH 1/1] package/swupdate: add optional systemd dependency

[Thomas Petazzoni]

On Sun, 29 Mar 2020 18:26:49 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Fixes:
> core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
>    27 | #include <systemd/sd-daemon.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~

Under what situations/configurations to you have this build failure.
Because I don't immediately see how adding an optional dependency can
fix such a build failure.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/swupdate: add optional systemd dependency

[James Hilliard]

On Sun, Mar 29, 2020 at 11:26 PM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Sun, 29 Mar 2020 18:26:49 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > Fixes:
> > core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
> >    27 | #include <systemd/sd-daemon.h>
> >       |          ^~~~~~~~~~~~~~~~~~~~~
>
> Under what situations/configurations to you have this build failure.
> Because I don't immediately see how adding an optional dependency can
> fix such a build failure.
It happens when this is enabled:
https://github.com/sbabic/swupdate/blob/2019.11/Kconfig#L104-L110
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

[Buildroot] [PATCH 1/1] package/swupdate: add optional systemd dependency

[Thomas Petazzoni]

On Sun, 29 Mar 2020 18:26:49 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:

> Fixes:
> core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
>    27 | #include <systemd/sd-daemon.h>
>       |          ^~~~~~~~~~~~~~~~~~~~~
> 
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
>  package/swupdate/swupdate.mk | 4 ++++
>  1 file changed, 4 insertions(+)

Applied to master with an extended commit log. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/swupdate: add optional systemd dependency

[Peter Korsgaard]

>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:

 > Fixes:
 > core/notifier.c:27:10: fatal error: systemd/sd-daemon.h: No such file or directory
 >    27 | #include <systemd/sd-daemon.h>
 >       |          ^~~~~~~~~~~~~~~~~~~~~

 > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>

Committed to 2020.02.x, thanks.

-- 
Bye, Peter Korsgaard