All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xin Long <lucien.xin@gmail.com>
To: Aaron Lu <aaron.lu@intel.com>
Cc: kernel test robot <xiaolong.ye@intel.com>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	lkp@01.org, "David S. Miller" <davem@davemloft.net>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [LKP] [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression
Date: Wed, 17 Aug 2016 02:34:46 +0800	[thread overview]
Message-ID: <CADvbK_cEo59Num286+7BoOkNgiScq7wjHvKM_FAx6qsQjACTXA@mail.gmail.com> (raw)
In-Reply-To: <6e529b10-117d-8af0-66b3-2ccfb71acf2a@intel.com>

>
> And I think we should be doing test on:
> commit a6c2f79287 ("sctp: implement prsctp TTL policy") (the bisected one)
> and
> commit 826d253d57 ("sctp: add SCTP_PR_ASSOC_STATUS on sctp sockopt") (its immediate parent)
> instead of Linus' master HEAD to avoid other factors.
>
The test result shows they are almost same:

826d253d57
=========================
[root@localhost lxin]# sysctl -w net.sctp.prsctp_enable=1
net.sctp.prsctp_enable = 1
15484.93
15557.69
15395.61

[root@localhost lxin]# sysctl -w net.sctp.prsctp_enable=0
net.sctp.prsctp_enable = 0
15369.83
14419.81
15202.59


a6c2f79287
===========
[root@localhost lxin]# sysctl -w net.sctp.prsctp_enable=1
net.sctp.prsctp_enable = 1
15198.00
15567.87
16092.55

[root@localhost lxin]# sysctl -w net.sctp.prsctp_enable=0
net.sctp.prsctp_enable = 0
15624.70
15021.85
15390.62

You can also review the commit a6c2f79287 if you have time:

It just added some 'if()' in the sending path if we don't use
any policy . In our test, no policy was used, I even added
log in kernel to check if some unexpected policy is enabled.

But still no.

If you can reproduce this issue stably, I suggest you can reverse
some code of that patch (it's a really a small patch)  and re-build
the kernel, then try.
With that, you can locate which line exactly triggered this issue.

Thanks.

WARNING: multiple messages have this Message-ID (diff)
From: Xin Long <lucien.xin@gmail.com>
To: lkp@lists.01.org
Subject: Re: [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression
Date: Wed, 17 Aug 2016 02:34:46 +0800	[thread overview]
Message-ID: <CADvbK_cEo59Num286+7BoOkNgiScq7wjHvKM_FAx6qsQjACTXA@mail.gmail.com> (raw)
In-Reply-To: <6e529b10-117d-8af0-66b3-2ccfb71acf2a@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1388 bytes --]

>
> And I think we should be doing test on:
> commit a6c2f79287 ("sctp: implement prsctp TTL policy") (the bisected one)
> and
> commit 826d253d57 ("sctp: add SCTP_PR_ASSOC_STATUS on sctp sockopt") (its immediate parent)
> instead of Linus' master HEAD to avoid other factors.
>
The test result shows they are almost same:

826d253d57
=========================
[root(a)localhost lxin]# sysctl -w net.sctp.prsctp_enable=1
net.sctp.prsctp_enable = 1
15484.93
15557.69
15395.61

[root(a)localhost lxin]# sysctl -w net.sctp.prsctp_enable=0
net.sctp.prsctp_enable = 0
15369.83
14419.81
15202.59


a6c2f79287
===========
[root(a)localhost lxin]# sysctl -w net.sctp.prsctp_enable=1
net.sctp.prsctp_enable = 1
15198.00
15567.87
16092.55

[root(a)localhost lxin]# sysctl -w net.sctp.prsctp_enable=0
net.sctp.prsctp_enable = 0
15624.70
15021.85
15390.62

You can also review the commit a6c2f79287 if you have time:

It just added some 'if()' in the sending path if we don't use
any policy . In our test, no policy was used, I even added
log in kernel to check if some unexpected policy is enabled.

But still no.

If you can reproduce this issue stably, I suggest you can reverse
some code of that patch (it's a really a small patch)  and re-build
the kernel, then try.
With that, you can locate which line exactly triggered this issue.

Thanks.

  parent reply	other threads:[~2016-08-16 18:34 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27  1:54 [lkp] [sctp] a6c2f79287: netperf.Throughput_Mbps -37.2% regression kernel test robot
2016-07-27  1:54 ` kernel test robot
2016-07-28  7:01 ` [lkp] " Xin Long
2016-07-28  7:01   ` Xin Long
2016-08-05  3:31   ` [LKP] [lkp] " Aaron Lu
2016-08-05  3:31     ` Aaron Lu
2016-08-05 11:53     ` [LKP] [lkp] " Xin Long
2016-08-05 11:53       ` Xin Long
2016-08-08  2:10       ` [LKP] [lkp] " Aaron Lu
2016-08-08  2:10         ` Aaron Lu
2016-08-16  2:38         ` [LKP] [lkp] " Aaron Lu
2016-08-16  2:38           ` Aaron Lu
2016-08-16  8:02         ` [LKP] [lkp] " Xin Long
2016-08-16  8:02           ` Xin Long
2016-08-16  8:30           ` [LKP] [lkp] " Aaron Lu
2016-08-16  8:30             ` Aaron Lu
2016-08-16  8:51           ` [LKP] [lkp] " Aaron Lu
2016-08-16  8:51             ` Aaron Lu
2016-08-16  9:56             ` [LKP] [lkp] " Xin Long
2016-08-16  9:56               ` Xin Long
2016-08-17  5:04               ` [LKP] [lkp] " Aaron Lu
2016-08-17  5:04                 ` Aaron Lu
2016-08-17  5:34                 ` [LKP] [lkp] " Xin Long
2016-08-17  5:34                   ` Xin Long
2016-08-17  5:34                 ` [LKP] [lkp] " Aaron Lu
2016-08-17  5:34                   ` Aaron Lu
2016-08-17  5:41                   ` [LKP] [lkp] " Xin Long
2016-08-17  5:41                     ` Xin Long
2016-08-17  6:14                     ` [LKP] [lkp] " Aaron Lu
2016-08-17  6:14                       ` Aaron Lu
2016-08-17  6:37                       ` [LKP] [lkp] " Aaron Lu
2016-08-17  6:37                         ` Aaron Lu
2016-08-17  6:42                         ` [LKP] [lkp] " Aaron Lu
2016-08-17  6:42                           ` Aaron Lu
2016-08-17  7:35                         ` [LKP] [lkp] " Xin Long
2016-08-17  7:35                           ` Xin Long
2016-08-17  7:42                           ` [LKP] [lkp] " Aaron Lu
2016-08-17  7:42                             ` Aaron Lu
2016-08-17  7:53                             ` [LKP] [lkp] " Aaron Lu
2016-08-17  7:53                               ` Aaron Lu
2016-08-17  8:02                             ` [LKP] [lkp] " Xin Long
2016-08-17  8:02                               ` Xin Long
2016-08-17  8:48                               ` [LKP] [lkp] " Aaron Lu
2016-08-17  8:48                                 ` Aaron Lu
2016-08-17  8:58                                 ` [LKP] [lkp] " Xin Long
2016-08-17  8:58                                   ` Xin Long
2016-08-17  9:20                                   ` [LKP] [lkp] " Aaron Lu
2016-08-17  9:20                                     ` Aaron Lu
2016-08-17 18:06                                     ` [LKP] [lkp] " Xin Long
2016-08-17 18:06                                       ` Xin Long
2016-08-18  3:21                                       ` [LKP] [lkp] " Aaron Lu
2016-08-18  3:21                                         ` Aaron Lu
2016-08-18 12:45                                         ` [LKP] [lkp] " Xin Long
2016-08-18 12:45                                           ` Xin Long
2016-08-19  5:29                                           ` [LKP] [lkp] " Aaron Lu
2016-08-19  5:29                                             ` Aaron Lu
2016-08-19  7:19                                             ` [LKP] [lkp] " Marcelo Ricardo Leitner
2016-08-19  7:19                                               ` Marcelo Ricardo Leitner
2016-08-19  7:24                                               ` [LKP] [lkp] " Aaron Lu
2016-08-19  7:24                                                 ` Aaron Lu
2016-08-22 21:44                                                 ` [LKP] [lkp] " Marcelo Ricardo Leitner
2016-08-22 21:44                                                   ` Marcelo Ricardo Leitner
2016-08-23  9:19                                                   ` [LKP] [lkp] " Aaron Lu
2016-08-23  9:19                                                     ` Aaron Lu
2016-09-30  7:05                                                   ` [LKP] [lkp] " Aaron Lu
2016-09-30  7:05                                                     ` Aaron Lu
2016-10-03  2:32                                                     ` [LKP] [lkp] " Xin Long
2016-10-03  2:32                                                       ` Xin Long
2016-10-09  7:41                                                       ` [LKP] [lkp] " Aaron Lu
2016-10-09  7:41                                                         ` Aaron Lu
2016-08-16 18:34             ` Xin Long [this message]
2016-08-16 18:34               ` Xin Long

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CADvbK_cEo59Num286+7BoOkNgiScq7wjHvKM_FAx6qsQjACTXA@mail.gmail.com \
    --to=lucien.xin@gmail.com \
    --cc=aaron.lu@intel.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@01.org \
    --cc=sfr@canb.auug.org.au \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.