[rocko][sumo][master][PATCH 1/2] bitbake.conf: add PERSISTENT_LOG_DIR variable

[rocko][sumo][master][PATCH 1/2] bitbake.conf: add PERSISTENT_LOG_DIR variable

[Ankur Tyagi]

This variable is only respected when VOLATILE_LOG_DIR is "no".

The default value is "" which results in the /var/log being log directory.

The user could override this value to a path e.g "/home/root/log" which
results /var/log being a link pointing to /home/root/log directory on
persistent storage.

Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
---
 meta/conf/bitbake.conf | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index e5dc1ac..9db22c8 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -88,6 +88,8 @@ ROOT_HOME ??= "/home/root"
 # If set to boolean true ('yes', 'y', 'true', 't', '1'), /var/log links to /var/volatile/log.
 # If set to boolean false ('no', 'n', 'false', 'f', '0'), /var/log is on persistent storage.
 VOLATILE_LOG_DIR ?= "yes"
+# If VOLATILE_LOG_DIR is false and PERSISTENT_LOG_DIR is set, /var/log links to PERSISTENT_LOG_DIR
+PERSISTENT_LOG_DIR ??= ""
 
 ##################################################################
 # Architecture-dependent build variables.
-- 
2.7.4

[rocko][sumo][master][PATCH 2/2] base-files: respect PERSISTENT_LOG_DIR

[Ankur Tyagi]

Respect PERSISTENT_LOG_DIR variable. In this way, if the user overrides
this variable to be e.g "/home/root/log", /var/log on the final image would
be a link pointing to /home/root/log on persistent storage.

Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
---
 meta/recipes-core/base-files/base-files_3.0.14.bb | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
index 1c0863b..597fdaa 100644
--- a/meta/recipes-core/base-files/base-files_3.0.14.bb
+++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
@@ -42,7 +42,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
            ${localstatedir}/backups ${localstatedir}/lib \
            /sys ${localstatedir}/lib/misc ${localstatedir}/spool \
            ${localstatedir}/volatile \
-           ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
+           ${@'${localstatedir}/volatile/log' if oe.types.boolean('${VOLATILE_LOG_DIR}') else '${PERSISTENT_LOG_DIR}' if d.getVar('PERSISTENT_LOG_DIR') else '${localstatedir}/log' } \
            /home ${prefix}/src ${localstatedir}/local \
            /media"
 
@@ -106,6 +106,10 @@ do_install () {
 		ln -sf volatile/$d ${D}${localstatedir}/$d
 	done
 
+	if [ ${@ oe.types.boolean('${VOLATILE_LOG_DIR}') } = False -a ! -z ${PERSISTENT_LOG_DIR} ]; then
+		ln -sf ${PERSISTENT_LOG_DIR} ${D}/${localstatedir}/log
+	fi
+
 	ln -snf ../run ${D}${localstatedir}/run
 	ln -snf ../run/lock ${D}${localstatedir}/lock
 
-- 
2.7.4

Re: [rocko][sumo][master][PATCH 1/2] bitbake.conf: add PERSISTENT_LOG_DIR variable

[ChenQi]

The requirement is to put logs into directories other than /var/log.
Could it be achieved by modifying the syslog daemon configuration file 
(e.g. /etc/syslog.conf) to replace /var/log with the specified 
directory. Maybe the corresponding logrotate configuration file also 
needs to be modified.

Best Regards,
Chen Qi

On 08/18/2018 08:59 AM, Ankur Tyagi wrote:
> This variable is only respected when VOLATILE_LOG_DIR is "no".
>
> The default value is "" which results in the /var/log being log directory.
>
> The user could override this value to a path e.g "/home/root/log" which
> results /var/log being a link pointing to /home/root/log directory on
> persistent storage.
>
> Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> ---
>   meta/conf/bitbake.conf | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index e5dc1ac..9db22c8 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -88,6 +88,8 @@ ROOT_HOME ??= "/home/root"
>   # If set to boolean true ('yes', 'y', 'true', 't', '1'), /var/log links to /var/volatile/log.
>   # If set to boolean false ('no', 'n', 'false', 'f', '0'), /var/log is on persistent storage.
>   VOLATILE_LOG_DIR ?= "yes"
> +# If VOLATILE_LOG_DIR is false and PERSISTENT_LOG_DIR is set, /var/log links to PERSISTENT_LOG_DIR
> +PERSISTENT_LOG_DIR ??= ""
>   
>   ##################################################################
>   # Architecture-dependent build variables.

Re: [rocko][sumo][master][PATCH 1/2] bitbake.conf: add PERSISTENT_LOG_DIR variable

[Ankur Tyagi]

[-- Attachment #1: Type: text/plain, Size: 2050 bytes --]

Initially I thought of doing that but then dropped it because it would
create a dependency on syslog configuration file.
If in future syslog configuration parameter (LOGFILE) gets renamed, then we
need to make corresponding change as well.

I think creating /var/log as a link is a less dependent change.

Let me know your thoughts.

Regards
Ankur

On Mon, Aug 20, 2018 at 1:49 PM ChenQi <Qi.Chen@windriver.com> wrote:

> The requirement is to put logs into directories other than /var/log.
> Could it be achieved by modifying the syslog daemon configuration file
> (e.g. /etc/syslog.conf) to replace /var/log with the specified
> directory. Maybe the corresponding logrotate configuration file also
> needs to be modified.
>
> Best Regards,
> Chen Qi
>
> On 08/18/2018 08:59 AM, Ankur Tyagi wrote:
> > This variable is only respected when VOLATILE_LOG_DIR is "no".
> >
> > The default value is "" which results in the /var/log being log
> directory.
> >
> > The user could override this value to a path e.g "/home/root/log" which
> > results /var/log being a link pointing to /home/root/log directory on
> > persistent storage.
> >
> > Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> > ---
> >   meta/conf/bitbake.conf | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> > index e5dc1ac..9db22c8 100644
> > --- a/meta/conf/bitbake.conf
> > +++ b/meta/conf/bitbake.conf
> > @@ -88,6 +88,8 @@ ROOT_HOME ??= "/home/root"
> >   # If set to boolean true ('yes', 'y', 'true', 't', '1'), /var/log
> links to /var/volatile/log.
> >   # If set to boolean false ('no', 'n', 'false', 'f', '0'), /var/log is
> on persistent storage.
> >   VOLATILE_LOG_DIR ?= "yes"
> > +# If VOLATILE_LOG_DIR is false and PERSISTENT_LOG_DIR is set, /var/log
> links to PERSISTENT_LOG_DIR
> > +PERSISTENT_LOG_DIR ??= ""
> >
> >   ##################################################################
> >   # Architecture-dependent build variables.
>
>
>

[-- Attachment #2: Type: text/html, Size: 3394 bytes --]

Re: [rocko][sumo][master][PATCH 1/2] bitbake.conf: add PERSISTENT_LOG_DIR variable

[Ankur Tyagi]

[-- Attachment #1: Type: text/plain, Size: 2220 bytes --]

Ping

Regards
Ankur

On Mon 20 Aug, 2018, 9:12 PM Ankur Tyagi, <ankur.tyagi85@gmail.com> wrote:

> Initially I thought of doing that but then dropped it because it would
> create a dependency on syslog configuration file.
> If in future syslog configuration parameter (LOGFILE) gets renamed, then
> we need to make corresponding change as well.
>
> I think creating /var/log as a link is a less dependent change.
>
> Let me know your thoughts.
>
> Regards
> Ankur
>
> On Mon, Aug 20, 2018 at 1:49 PM ChenQi <Qi.Chen@windriver.com> wrote:
>
>> The requirement is to put logs into directories other than /var/log.
>> Could it be achieved by modifying the syslog daemon configuration file
>> (e.g. /etc/syslog.conf) to replace /var/log with the specified
>> directory. Maybe the corresponding logrotate configuration file also
>> needs to be modified.
>>
>> Best Regards,
>> Chen Qi
>>
>> On 08/18/2018 08:59 AM, Ankur Tyagi wrote:
>> > This variable is only respected when VOLATILE_LOG_DIR is "no".
>> >
>> > The default value is "" which results in the /var/log being log
>> directory.
>> >
>> > The user could override this value to a path e.g "/home/root/log" which
>> > results /var/log being a link pointing to /home/root/log directory on
>> > persistent storage.
>> >
>> > Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
>> > ---
>> >   meta/conf/bitbake.conf | 2 ++
>> >   1 file changed, 2 insertions(+)
>> >
>> > diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
>> > index e5dc1ac..9db22c8 100644
>> > --- a/meta/conf/bitbake.conf
>> > +++ b/meta/conf/bitbake.conf
>> > @@ -88,6 +88,8 @@ ROOT_HOME ??= "/home/root"
>> >   # If set to boolean true ('yes', 'y', 'true', 't', '1'), /var/log
>> links to /var/volatile/log.
>> >   # If set to boolean false ('no', 'n', 'false', 'f', '0'), /var/log is
>> on persistent storage.
>> >   VOLATILE_LOG_DIR ?= "yes"
>> > +# If VOLATILE_LOG_DIR is false and PERSISTENT_LOG_DIR is set, /var/log
>> links to PERSISTENT_LOG_DIR
>> > +PERSISTENT_LOG_DIR ??= ""
>> >
>> >   ##################################################################
>> >   # Architecture-dependent build variables.
>>
>>
>>

[-- Attachment #2: Type: text/html, Size: 3854 bytes --]

Re: [rocko][sumo][master][PATCH 1/2] bitbake.conf: add PERSISTENT_LOG_DIR variable

[Ankur Tyagi]

[-- Attachment #1: Type: text/plain, Size: 1282 bytes --]

Ping

Regards
Ankur

On Sat 18 Aug, 2018, 12:59 PM Ankur Tyagi, <ankur.tyagi85@gmail.com> wrote:

> This variable is only respected when VOLATILE_LOG_DIR is "no".
>
> The default value is "" which results in the /var/log being log directory.
>
> The user could override this value to a path e.g "/home/root/log" which
> results /var/log being a link pointing to /home/root/log directory on
> persistent storage.
>
> Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> ---
>  meta/conf/bitbake.conf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index e5dc1ac..9db22c8 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -88,6 +88,8 @@ ROOT_HOME ??= "/home/root"
>  # If set to boolean true ('yes', 'y', 'true', 't', '1'), /var/log links
> to /var/volatile/log.
>  # If set to boolean false ('no', 'n', 'false', 'f', '0'), /var/log is on
> persistent storage.
>  VOLATILE_LOG_DIR ?= "yes"
> +# If VOLATILE_LOG_DIR is false and PERSISTENT_LOG_DIR is set, /var/log
> links to PERSISTENT_LOG_DIR
> +PERSISTENT_LOG_DIR ??= ""
>
>  ##################################################################
>  # Architecture-dependent build variables.
> --
> 2.7.4
>
>

[-- Attachment #2: Type: text/html, Size: 1916 bytes --]

Re: [rocko][sumo][master][PATCH 2/2] base-files: respect PERSISTENT_LOG_DIR

[Ankur Tyagi]

[-- Attachment #1: Type: text/plain, Size: 1894 bytes --]

Ping

Regards
Ankur

On Sat 18 Aug, 2018, 12:59 PM Ankur Tyagi, <ankur.tyagi85@gmail.com> wrote:

> Respect PERSISTENT_LOG_DIR variable. In this way, if the user overrides
> this variable to be e.g "/home/root/log", /var/log on the final image would
> be a link pointing to /home/root/log on persistent storage.
>
> Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> ---
>  meta/recipes-core/base-files/base-files_3.0.14.bb | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb
> b/meta/recipes-core/base-files/base-files_3.0.14.bb
> index 1c0863b..597fdaa 100644
> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> @@ -42,7 +42,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir}
> ${base_libdir} \
>             ${localstatedir}/backups ${localstatedir}/lib \
>             /sys ${localstatedir}/lib/misc ${localstatedir}/spool \
>             ${localstatedir}/volatile \
> -           ${localstatedir}/${@'volatile/' if
> oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
> +           ${@'${localstatedir}/volatile/log' if
> oe.types.boolean('${VOLATILE_LOG_DIR}') else '${PERSISTENT_LOG_DIR}' if
> d.getVar('PERSISTENT_LOG_DIR') else '${localstatedir}/log' } \
>             /home ${prefix}/src ${localstatedir}/local \
>             /media"
>
> @@ -106,6 +106,10 @@ do_install () {
>                 ln -sf volatile/$d ${D}${localstatedir}/$d
>         done
>
> +       if [ ${@ oe.types.boolean('${VOLATILE_LOG_DIR}') } = False -a ! -z
> ${PERSISTENT_LOG_DIR} ]; then
> +               ln -sf ${PERSISTENT_LOG_DIR} ${D}/${localstatedir}/log
> +       fi
> +
>         ln -snf ../run ${D}${localstatedir}/run
>         ln -snf ../run/lock ${D}${localstatedir}/lock
>
> --
> 2.7.4
>
>

[-- Attachment #2: Type: text/html, Size: 2944 bytes --]

Re: [rocko][sumo][master][PATCH 2/2] base-files: respect PERSISTENT_LOG_DIR

[Khem Raj]

On Fri, Aug 17, 2018 at 6:00 PM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
>
> Respect PERSISTENT_LOG_DIR variable. In this way, if the user overrides
> this variable to be e.g "/home/root/log", /var/log on the final image would
> be a link pointing to /home/root/log on persistent storage.
>

I would suggest to stick with VOLATILE_BINDS

> Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> ---
>  meta/recipes-core/base-files/base-files_3.0.14.bb | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
> index 1c0863b..597fdaa 100644
> --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> @@ -42,7 +42,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
>             ${localstatedir}/backups ${localstatedir}/lib \
>             /sys ${localstatedir}/lib/misc ${localstatedir}/spool \
>             ${localstatedir}/volatile \
> -           ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
> +           ${@'${localstatedir}/volatile/log' if oe.types.boolean('${VOLATILE_LOG_DIR}') else '${PERSISTENT_LOG_DIR}' if d.getVar('PERSISTENT_LOG_DIR') else '${localstatedir}/log' } \
>             /home ${prefix}/src ${localstatedir}/local \
>             /media"
>
> @@ -106,6 +106,10 @@ do_install () {
>                 ln -sf volatile/$d ${D}${localstatedir}/$d
>         done
>
> +       if [ ${@ oe.types.boolean('${VOLATILE_LOG_DIR}') } = False -a ! -z ${PERSISTENT_LOG_DIR} ]; then
> +               ln -sf ${PERSISTENT_LOG_DIR} ${D}/${localstatedir}/log
> +       fi
> +
>         ln -snf ../run ${D}${localstatedir}/run
>         ln -snf ../run/lock ${D}${localstatedir}/lock
>
> --
> 2.7.4
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [rocko][sumo][master][PATCH 2/2] base-files: respect PERSISTENT_LOG_DIR

[Ankur Tyagi]

On Sat, Aug 25, 2018 at 12:17 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Fri, Aug 17, 2018 at 6:00 PM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
> >
> > Respect PERSISTENT_LOG_DIR variable. In this way, if the user overrides
> > this variable to be e.g "/home/root/log", /var/log on the final image would
> > be a link pointing to /home/root/log on persistent storage.
> >
>
> I would suggest to stick with VOLATILE_BINDS

But this won't help with VOLATILE_LOG_DIR set as "no".
I think it is a common requirement to have persistent logging mounted
in a separate partition.
This patch makes it easy (hopefully) for the user to achieve the above
without any additional recipe.

>
> > Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> > ---
> >  meta/recipes-core/base-files/base-files_3.0.14.bb | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
> > index 1c0863b..597fdaa 100644
> > --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> > +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> > @@ -42,7 +42,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
> >             ${localstatedir}/backups ${localstatedir}/lib \
> >             /sys ${localstatedir}/lib/misc ${localstatedir}/spool \
> >             ${localstatedir}/volatile \
> > -           ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
> > +           ${@'${localstatedir}/volatile/log' if oe.types.boolean('${VOLATILE_LOG_DIR}') else '${PERSISTENT_LOG_DIR}' if d.getVar('PERSISTENT_LOG_DIR') else '${localstatedir}/log' } \
> >             /home ${prefix}/src ${localstatedir}/local \
> >             /media"
> >
> > @@ -106,6 +106,10 @@ do_install () {
> >                 ln -sf volatile/$d ${D}${localstatedir}/$d
> >         done
> >
> > +       if [ ${@ oe.types.boolean('${VOLATILE_LOG_DIR}') } = False -a ! -z ${PERSISTENT_LOG_DIR} ]; then
> > +               ln -sf ${PERSISTENT_LOG_DIR} ${D}/${localstatedir}/log
> > +       fi
> > +
> >         ln -snf ../run ${D}${localstatedir}/run
> >         ln -snf ../run/lock ${D}${localstatedir}/lock
> >
> > --
> > 2.7.4
> >
> > --
> > _______________________________________________
> > Openembedded-core mailing list
> > Openembedded-core@lists.openembedded.org
> > http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [rocko][sumo][master][PATCH 2/2] base-files: respect PERSISTENT_LOG_DIR

[Ankur Tyagi]

Hi Khem,

Is this patch being accepted ?

regards
Ankur

On Tue, Aug 28, 2018 at 7:45 AM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
>
> On Sat, Aug 25, 2018 at 12:17 PM Khem Raj <raj.khem@gmail.com> wrote:
> >
> > On Fri, Aug 17, 2018 at 6:00 PM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
> > >
> > > Respect PERSISTENT_LOG_DIR variable. In this way, if the user overrides
> > > this variable to be e.g "/home/root/log", /var/log on the final image would
> > > be a link pointing to /home/root/log on persistent storage.
> > >
> >
> > I would suggest to stick with VOLATILE_BINDS
>
> But this won't help with VOLATILE_LOG_DIR set as "no".
> I think it is a common requirement to have persistent logging mounted
> in a separate partition.
> This patch makes it easy (hopefully) for the user to achieve the above
> without any additional recipe.
>
> >
> > > Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> > > ---
> > >  meta/recipes-core/base-files/base-files_3.0.14.bb | 6 +++++-
> > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
> > > index 1c0863b..597fdaa 100644
> > > --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> > > +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> > > @@ -42,7 +42,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
> > >             ${localstatedir}/backups ${localstatedir}/lib \
> > >             /sys ${localstatedir}/lib/misc ${localstatedir}/spool \
> > >             ${localstatedir}/volatile \
> > > -           ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
> > > +           ${@'${localstatedir}/volatile/log' if oe.types.boolean('${VOLATILE_LOG_DIR}') else '${PERSISTENT_LOG_DIR}' if d.getVar('PERSISTENT_LOG_DIR') else '${localstatedir}/log' } \
> > >             /home ${prefix}/src ${localstatedir}/local \
> > >             /media"
> > >
> > > @@ -106,6 +106,10 @@ do_install () {
> > >                 ln -sf volatile/$d ${D}${localstatedir}/$d
> > >         done
> > >
> > > +       if [ ${@ oe.types.boolean('${VOLATILE_LOG_DIR}') } = False -a ! -z ${PERSISTENT_LOG_DIR} ]; then
> > > +               ln -sf ${PERSISTENT_LOG_DIR} ${D}/${localstatedir}/log
> > > +       fi
> > > +
> > >         ln -snf ../run ${D}${localstatedir}/run
> > >         ln -snf ../run/lock ${D}${localstatedir}/lock
> > >
> > > --
> > > 2.7.4
> > >
> > > --
> > > _______________________________________________
> > > Openembedded-core mailing list
> > > Openembedded-core@lists.openembedded.org
> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [rocko][sumo][master][PATCH 2/2] base-files: respect PERSISTENT_LOG_DIR

[Khem Raj]

On Thu, Aug 30, 2018 at 1:34 AM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
>
> Hi Khem,
>
> Is this patch being accepted ?
>

I am not convinced if we need this patch as we can do this using volatile binds.
or base-files changes if needed.

> regards
> Ankur
>
> On Tue, Aug 28, 2018 at 7:45 AM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
> >
> > On Sat, Aug 25, 2018 at 12:17 PM Khem Raj <raj.khem@gmail.com> wrote:
> > >
> > > On Fri, Aug 17, 2018 at 6:00 PM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
> > > >
> > > > Respect PERSISTENT_LOG_DIR variable. In this way, if the user overrides
> > > > this variable to be e.g "/home/root/log", /var/log on the final image would
> > > > be a link pointing to /home/root/log on persistent storage.
> > > >
> > >
> > > I would suggest to stick with VOLATILE_BINDS
> >
> > But this won't help with VOLATILE_LOG_DIR set as "no".
> > I think it is a common requirement to have persistent logging mounted
> > in a separate partition.
> > This patch makes it easy (hopefully) for the user to achieve the above
> > without any additional recipe.
> >
> > >
> > > > Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> > > > ---
> > > >  meta/recipes-core/base-files/base-files_3.0.14.bb | 6 +++++-
> > > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
> > > > index 1c0863b..597fdaa 100644
> > > > --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> > > > +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> > > > @@ -42,7 +42,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
> > > >             ${localstatedir}/backups ${localstatedir}/lib \
> > > >             /sys ${localstatedir}/lib/misc ${localstatedir}/spool \
> > > >             ${localstatedir}/volatile \
> > > > -           ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
> > > > +           ${@'${localstatedir}/volatile/log' if oe.types.boolean('${VOLATILE_LOG_DIR}') else '${PERSISTENT_LOG_DIR}' if d.getVar('PERSISTENT_LOG_DIR') else '${localstatedir}/log' } \
> > > >             /home ${prefix}/src ${localstatedir}/local \
> > > >             /media"
> > > >
> > > > @@ -106,6 +106,10 @@ do_install () {
> > > >                 ln -sf volatile/$d ${D}${localstatedir}/$d
> > > >         done
> > > >
> > > > +       if [ ${@ oe.types.boolean('${VOLATILE_LOG_DIR}') } = False -a ! -z ${PERSISTENT_LOG_DIR} ]; then
> > > > +               ln -sf ${PERSISTENT_LOG_DIR} ${D}/${localstatedir}/log
> > > > +       fi
> > > > +
> > > >         ln -snf ../run ${D}${localstatedir}/run
> > > >         ln -snf ../run/lock ${D}${localstatedir}/lock
> > > >
> > > > --
> > > > 2.7.4
> > > >
> > > > --
> > > > _______________________________________________
> > > > Openembedded-core mailing list
> > > > Openembedded-core@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-core

Re: [rocko][sumo][master][PATCH 2/2] base-files: respect PERSISTENT_LOG_DIR

[Ankur Tyagi]

On Thu, Aug 30, 2018 at 8:38 PM Khem Raj <raj.khem@gmail.com> wrote:
>
> On Thu, Aug 30, 2018 at 1:34 AM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
> >
> > Hi Khem,
> >
> > Is this patch being accepted ?
> >
>
> I am not convinced if we need this patch as we can do this using volatile binds.
> or base-files changes if needed.
>

How volatile binds will help with VOLATILE_LOG_DIR set as "no" ?
This patch is modifying base-files so that users can simply set a
variable in conf file instead of modifying base-files.

> > regards
> > Ankur
> >
> > On Tue, Aug 28, 2018 at 7:45 AM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
> > >
> > > On Sat, Aug 25, 2018 at 12:17 PM Khem Raj <raj.khem@gmail.com> wrote:
> > > >
> > > > On Fri, Aug 17, 2018 at 6:00 PM Ankur Tyagi <ankur.tyagi85@gmail.com> wrote:
> > > > >
> > > > > Respect PERSISTENT_LOG_DIR variable. In this way, if the user overrides
> > > > > this variable to be e.g "/home/root/log", /var/log on the final image would
> > > > > be a link pointing to /home/root/log on persistent storage.
> > > > >
> > > >
> > > > I would suggest to stick with VOLATILE_BINDS
> > >
> > > But this won't help with VOLATILE_LOG_DIR set as "no".
> > > I think it is a common requirement to have persistent logging mounted
> > > in a separate partition.
> > > This patch makes it easy (hopefully) for the user to achieve the above
> > > without any additional recipe.
> > >
> > > >
> > > > > Signed-off-by: Ankur Tyagi <ankur.tyagi85@gmail.com>
> > > > > ---
> > > > >  meta/recipes-core/base-files/base-files_3.0.14.bb | 6 +++++-
> > > > >  1 file changed, 5 insertions(+), 1 deletion(-)
> > > > >
> > > > > diff --git a/meta/recipes-core/base-files/base-files_3.0.14.bb b/meta/recipes-core/base-files/base-files_3.0.14.bb
> > > > > index 1c0863b..597fdaa 100644
> > > > > --- a/meta/recipes-core/base-files/base-files_3.0.14.bb
> > > > > +++ b/meta/recipes-core/base-files/base-files_3.0.14.bb
> > > > > @@ -42,7 +42,7 @@ dirs755 = "/boot /dev ${base_bindir} ${base_sbindir} ${base_libdir} \
> > > > >             ${localstatedir}/backups ${localstatedir}/lib \
> > > > >             /sys ${localstatedir}/lib/misc ${localstatedir}/spool \
> > > > >             ${localstatedir}/volatile \
> > > > > -           ${localstatedir}/${@'volatile/' if oe.types.boolean('${VOLATILE_LOG_DIR}') else ''}log \
> > > > > +           ${@'${localstatedir}/volatile/log' if oe.types.boolean('${VOLATILE_LOG_DIR}') else '${PERSISTENT_LOG_DIR}' if d.getVar('PERSISTENT_LOG_DIR') else '${localstatedir}/log' } \
> > > > >             /home ${prefix}/src ${localstatedir}/local \
> > > > >             /media"
> > > > >
> > > > > @@ -106,6 +106,10 @@ do_install () {
> > > > >                 ln -sf volatile/$d ${D}${localstatedir}/$d
> > > > >         done
> > > > >
> > > > > +       if [ ${@ oe.types.boolean('${VOLATILE_LOG_DIR}') } = False -a ! -z ${PERSISTENT_LOG_DIR} ]; then
> > > > > +               ln -sf ${PERSISTENT_LOG_DIR} ${D}/${localstatedir}/log
> > > > > +       fi
> > > > > +
> > > > >         ln -snf ../run ${D}${localstatedir}/run
> > > > >         ln -snf ../run/lock ${D}${localstatedir}/lock
> > > > >
> > > > > --
> > > > > 2.7.4
> > > > >
> > > > > --
> > > > > _______________________________________________
> > > > > Openembedded-core mailing list
> > > > > Openembedded-core@lists.openembedded.org
> > > > > http://lists.openembedded.org/mailman/listinfo/openembedded-core