[U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h

[U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h

[Faisal H]

While building with omap3_beagle_config configuration,
getting an error about not finding asm/arch/gpio.h (which does not exist).
Found that header files are moved to arch/arm/include/asm/arch-.
Fixed the includes to find the file..

Signed-off-by: Faisal Hassan<faah87@gmail.com>
Cc: Wolfgang Denk<wd@denx.de>


--- a/board/cm-bf537e/gpio_cfi_flash.c
+++ b/board/cm-bf537e/gpio_cfi_flash.c
@@ -8,7 +8,7 @@

  #include<common.h>
  #include<asm/blackfin.h>
-#include<asm/gpio.h>
+#include<asm/mach-bf537/gpio.h>
  #include<asm/io.h>
  #include "gpio_cfi_flash.h"

--- a/board/bf548-ezkit/video.c
+++ b/board/bf548-ezkit/video.c
@@ -11,7 +11,7 @@
  #include<config.h>
  #include<malloc.h>
  #include<asm/blackfin.h>
-#include<asm/gpio.h>
+#include<asm/mach-bf548/gpio.h>
  #include<asm/portmux.h>
  #include<asm/mach-common/bits/dma.h>
  #include<i2c.h>
--- a/board/bf548-ezkit/bf548-ezkit.c
+++ b/board/bf548-ezkit/bf548-ezkit.c
@@ -11,7 +11,7 @@
  #include<command.h>
  #include<netdev.h>
  #include<asm/blackfin.h>
-#include<asm/gpio.h>
+#include<asm/mach-bf548/gpio.h>
  #include<asm/portmux.h>
  #include<asm/sdh.h>

--- a/board/bf537-stamp/post.c
+++ b/board/bf537-stamp/post.c
@@ -12,7 +12,7 @@
  #include<config.h>
  #include<command.h>
  #include<asm/blackfin.h>
-#include<asm/gpio.h>
+#include<asm/mach-bf537/gpio.h>

  /* Using sw10-PF5 as the hotkey */
  int post_hotkeys_pressed(void)
--- a/board/bf533-stamp/bf533-stamp.c
+++ b/board/bf533-stamp/bf533-stamp.c
@@ -27,7 +27,7 @@

  #include<common.h>
  #include<netdev.h>
-#include<asm/gpio.h>
+#include<asm/mach-bf533/gpio.h>

  DECLARE_GLOBAL_DATA_PTR;

--- a/board/bf527-sdp/bf527-sdp.c
+++ b/board/bf527-sdp/bf527-sdp.c
@@ -8,7 +8,7 @@

  #include<common.h>
  #include<asm/blackfin.h>
-#include<asm/gpio.h>
+#include<asm/mach-bf527/gpio.h>
  #include<asm/mach-common/bits/pll.h>

  int checkboard(void)
--- a/board/bf527-ezkit/bf527-ezkit.c
+++ b/board/bf527-ezkit/bf527-ezkit.c
@@ -12,7 +12,7 @@
  #include<net.h>
  #include<netdev.h>
  #include<asm/blackfin.h>
-#include<asm/gpio.h>
+#include<mach-bf527/gpio.h>
  #include<asm/net.h>
  #include<asm/mach-common/bits/otp.h>

--- a/board/cm-bf548/video.c
+++ b/board/cm-bf548/video.c
@@ -11,7 +11,7 @@
  #include<config.h>
  #include<malloc.h>
  #include<asm/blackfin.h>
-#include<asm/gpio.h>
+#include<asm/mach-bf548/gpio.h>
  #include<asm/portmux.h>
  #include<asm/mach-common/bits/dma.h>
  #include<i2c.h>
--- a/board/ti/beagle/beagle.c
+++ b/board/ti/beagle/beagle.c
@@ -38,7 +38,7 @@
  #include<asm/arch/mmc_host_def.h>
  #include<asm/arch/mux.h>
  #include<asm/arch/sys_proto.h>
-#include<asm/arch/gpio.h>
+#include<asm/arch-omap3/gpio.h>
  #include<asm/mach-types.h>
  #ifdef CONFIG_USB_EHCI
  #include<usb.h>
--- a/board/ti/beagle/led.c
+++ b/board/ti/beagle/led.c
@@ -22,7 +22,7 @@
  #include<asm/arch/cpu.h>
  #include<asm/io.h>
  #include<asm/arch/sys_proto.h>
-#include<asm/arch/gpio.h>
+#include<asm/arch-omap3/gpio.h>

  static unsigned int saved_state[2] = {STATUS_LED_OFF, STATUS_LED_OFF};

[U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h

[Wolfgang Denk]

Dear Faisal H,

In message <CADyx3a0pYfW9Ee0kC0h6OQOGtFAd5ceviJvUv9ufSPaRTeOmxw@mail.gmail.com> you wrote:
> While building with omap3_beagle_config configuration,
> getting an error about not finding asm/arch/gpio.h (which does not exist).
> Found that header files are moved to arch/arm/include/asm/arch-.
> Fixed the includes to find the file..
> 
> Signed-off-by: Faisal Hassan<faah87@gmail.com>
> Cc: Wolfgang Denk<wd@denx.de>
> 
> 
> --- a/board/cm-bf537e/gpio_cfi_flash.c
> +++ b/board/cm-bf537e/gpio_cfi_flash.c

What has building for OMAP3 boards to do with files from the Blackfin
source tree?

Please fix the commit message.  And please put the respective
architecture custodian on Cc:, not me.

Thanks.

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The shortest unit of time in the multiverse is the News York  Second,
defined  as  the  period  of  time between the traffic lights turning
green and the cab behind you honking.
                                - Terry Pratchett, _Lords and Ladies_

[U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h

[Stefano Babic]

On 08/25/2011 08:29 AM, Faisal H wrote:
> While building with omap3_beagle_config configuration,
> getting an error about not finding asm/arch/gpio.h (which does not exist).
> Found that header files are moved to arch/arm/include/asm/arch-.

"make <board>_config" sets a link for asm/arch to
arch/arm/include/asm/arch-. The file is not moved.

Then in my understanding asm/arch/gpio.h is included in asm/gpio.h, and
must not be included directly. Have I missed something ?


> Fixed the includes to find the file..
> 
> Signed-off-by: Faisal Hassan<faah87@gmail.com>
> Cc: Wolfgang Denk<wd@denx.de>
> 
> 
> --- a/board/cm-bf537e/gpio_cfi_flash.c
> +++ b/board/cm-bf537e/gpio_cfi_flash.c
> @@ -8,7 +8,7 @@
> 
>   #include<common.h>
>   #include<asm/blackfin.h>
> -#include<asm/gpio.h>
> +#include<asm/mach-bf537/gpio.h>

However, asm/gpio.h is the correct general interface. The specific part
for the microprocessor is included with #include <asm/arch/gpio.h> in
asm/gpio.h.

You should not need to change it if the links are correctly set. If not,
it is another bug.

>   #include<asm/blackfin.h>
> -#include<asm/gpio.h>
> +#include<asm/mach-bf548/gpio.h>

IMHO this change is wrong, and it is correct how it is done currently.

Best regards,
Stefano Babic

-- 
=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH] Error : Not finding asm/arch/gpio.h

[Mike Frysinger]

On Thursday, August 25, 2011 02:29:12 Faisal H wrote:
> While building with omap3_beagle_config configuration,
> getting an error about not finding asm/arch/gpio.h (which does not exist).
> Found that header files are moved to arch/arm/include/asm/arch-.
> Fixed the includes to find the file..

NAK on all the Blackfin pieces as that arch properly sets up asm/gpio.h for 
people to include (all the board/*bf5*/ dirs).
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part.
Url : http://lists.denx.de/pipermail/u-boot/attachments/20110825/2b97f12d/attachment.pgp