* [PATCH linux-next] drm/msm/dp: remove unneeded variable
@ 2021-11-10 12:05 ` cgel.zte
0 siblings, 0 replies; 4+ messages in thread
From: cgel.zte @ 2021-11-10 12:05 UTC (permalink / raw)
To: robdclark
Cc: sean, airlied, daniel, swboyd, abhinavk, deng.changcheng,
linux-arm-msm, dri-devel, freedreno, linux-kernel, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Fix the following coccicheck review:
./drivers/gpu/drm/msm/dp/dp_debug.c: Unneeded variable
Remove unneeded variable used to store return value.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/gpu/drm/msm/dp/dp_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c b/drivers/gpu/drm/msm/dp/dp_debug.c
index 2f6247e80e9d..c5c75273d1e5 100644
--- a/drivers/gpu/drm/msm/dp/dp_debug.c
+++ b/drivers/gpu/drm/msm/dp/dp_debug.c
@@ -365,7 +365,6 @@ static const struct file_operations test_active_fops = {
static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor)
{
- int rc = 0;
struct dp_debug_private *debug = container_of(dp_debug,
struct dp_debug_private, dp_debug);
@@ -386,7 +385,7 @@ static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor)
debug->root = minor->debugfs_root;
- return rc;
+ return 0;
}
struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH linux-next] drm/msm/dp: remove unneeded variable
@ 2021-11-10 12:05 ` cgel.zte
0 siblings, 0 replies; 4+ messages in thread
From: cgel.zte @ 2021-11-10 12:05 UTC (permalink / raw)
To: robdclark
Cc: freedreno, airlied, linux-arm-msm, Zeal Robot, deng.changcheng,
abhinavk, swboyd, dri-devel, sean, linux-kernel
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Fix the following coccicheck review:
./drivers/gpu/drm/msm/dp/dp_debug.c: Unneeded variable
Remove unneeded variable used to store return value.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/gpu/drm/msm/dp/dp_debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c b/drivers/gpu/drm/msm/dp/dp_debug.c
index 2f6247e80e9d..c5c75273d1e5 100644
--- a/drivers/gpu/drm/msm/dp/dp_debug.c
+++ b/drivers/gpu/drm/msm/dp/dp_debug.c
@@ -365,7 +365,6 @@ static const struct file_operations test_active_fops = {
static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor)
{
- int rc = 0;
struct dp_debug_private *debug = container_of(dp_debug,
struct dp_debug_private, dp_debug);
@@ -386,7 +385,7 @@ static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor)
debug->root = minor->debugfs_root;
- return rc;
+ return 0;
}
struct dp_debug *dp_debug_get(struct device *dev, struct dp_panel *panel,
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] drm/msm/dp: remove unneeded variable
2021-11-10 12:05 ` cgel.zte
@ 2021-11-16 0:43 ` Stephen Boyd
-1 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-11-16 0:43 UTC (permalink / raw)
To: cgel.zte, robdclark
Cc: freedreno, airlied, linux-arm-msm, Zeal Robot, deng.changcheng,
abhinavk, linux-kernel, dri-devel, sean
Quoting cgel.zte@gmail.com (2021-11-10 04:05:12)
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/gpu/drm/msm/dp/dp_debug.c: Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> ---
> drivers/gpu/drm/msm/dp/dp_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c b/drivers/gpu/drm/msm/dp/dp_debug.c
> index 2f6247e80e9d..c5c75273d1e5 100644
> --- a/drivers/gpu/drm/msm/dp/dp_debug.c
> +++ b/drivers/gpu/drm/msm/dp/dp_debug.c
> @@ -365,7 +365,6 @@ static const struct file_operations test_active_fops = {
>
> static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor)
Would be nice to make it void as well and then cleanup the caller. Can
you do that too?
> {
> - int rc = 0;
> struct dp_debug_private *debug = container_of(dp_debug,
> struct dp_debug_private, dp_debug);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH linux-next] drm/msm/dp: remove unneeded variable
@ 2021-11-16 0:43 ` Stephen Boyd
0 siblings, 0 replies; 4+ messages in thread
From: Stephen Boyd @ 2021-11-16 0:43 UTC (permalink / raw)
To: cgel.zte, robdclark
Cc: sean, airlied, daniel, abhinavk, deng.changcheng, linux-arm-msm,
dri-devel, freedreno, linux-kernel, Zeal Robot
Quoting cgel.zte@gmail.com (2021-11-10 04:05:12)
> From: Changcheng Deng <deng.changcheng@zte.com.cn>
>
> Fix the following coccicheck review:
> ./drivers/gpu/drm/msm/dp/dp_debug.c: Unneeded variable
>
> Remove unneeded variable used to store return value.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
> ---
> drivers/gpu/drm/msm/dp/dp_debug.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/dp/dp_debug.c b/drivers/gpu/drm/msm/dp/dp_debug.c
> index 2f6247e80e9d..c5c75273d1e5 100644
> --- a/drivers/gpu/drm/msm/dp/dp_debug.c
> +++ b/drivers/gpu/drm/msm/dp/dp_debug.c
> @@ -365,7 +365,6 @@ static const struct file_operations test_active_fops = {
>
> static int dp_debug_init(struct dp_debug *dp_debug, struct drm_minor *minor)
Would be nice to make it void as well and then cleanup the caller. Can
you do that too?
> {
> - int rc = 0;
> struct dp_debug_private *debug = container_of(dp_debug,
> struct dp_debug_private, dp_debug);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-16 3:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-10 12:05 [PATCH linux-next] drm/msm/dp: remove unneeded variable cgel.zte
2021-11-10 12:05 ` cgel.zte
2021-11-16 0:43 ` Stephen Boyd
2021-11-16 0:43 ` Stephen Boyd
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.