From: Stephen Boyd <swboyd@chromium.org> To: Baoquan He <bhe@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>, Evan Green <evgreen@chromium.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Dave Young <dyoung@redhat.com>, Vivek Goyal <vgoyal@redhat.com>, kexec@lists.infradead.org Subject: Re: [PATCH v5 13/13] kdump: Use vmlinux_build_id to simplify Date: Thu, 29 Apr 2021 01:14:43 +0200 [thread overview] Message-ID: <CAE-0n517ZDD8ySTqT2GvKv-KNf1DFP2qmaqt3Pc=-AEndLTevg@mail.gmail.com> (raw) In-Reply-To: <20210428101355.GB8374@localhost.localdomain> Quoting Baoquan He (2021-04-28 03:13:55) > On 04/20/21 at 02:50pm, Stephen Boyd wrote: > > We can use the vmlinux_build_id array here now instead of open coding > > it. This mostly consolidates code. > > > > Cc: Jiri Olsa <jolsa@kernel.org> > > Cc: Alexei Starovoitov <ast@kernel.org> > > Cc: Jessica Yu <jeyu@kernel.org> > > Cc: Evan Green <evgreen@chromium.org> > > Cc: Hsin-Yi Wang <hsinyi@chromium.org> > > Cc: Dave Young <dyoung@redhat.com> > > Cc: Baoquan He <bhe@redhat.com> > > Cc: Vivek Goyal <vgoyal@redhat.com> > > Cc: <kexec@lists.infradead.org> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > --- > > include/linux/crash_core.h | 12 ++++----- > > kernel/crash_core.c | 50 ++------------------------------------ > > 2 files changed, 8 insertions(+), 54 deletions(-) > > > > diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h > > index 206bde8308b2..de62a722431e 100644 > > --- a/include/linux/crash_core.h > > +++ b/include/linux/crash_core.h > > @@ -38,8 +38,12 @@ phys_addr_t paddr_vmcoreinfo_note(void); > > > > #define VMCOREINFO_OSRELEASE(value) \ > > vmcoreinfo_append_str("OSRELEASE=%s\n", value) > > -#define VMCOREINFO_BUILD_ID(value) \ > > - vmcoreinfo_append_str("BUILD-ID=%s\n", value) > > +#define VMCOREINFO_BUILD_ID() \ > > + ({ \ > > + static_assert(sizeof(vmlinux_build_id) == 20); \ > > + vmcoreinfo_append_str("BUILD-ID=%20phN\n", vmlinux_build_id); \ > > Since there has been static_assert at above, can we remove the magic > number '20'? > > And I checked format_decode(), didn't find which type corresponds to > 'N', could you tell? It is documented in Documentation/core-api/printk-formats.rst (see "Raw buffer as a hex string") where the '20' replaces the '*' to specify a fixed size buffer to format. We could pass the 20 as an argument instead of encoding it in the format, but then it would still be there twice. We could use a #define but then it would have to be passed as an argument. I don't know of a good way to enforce in printk that the buffer is the size that matches the format size. Maybe it shouldn't be an option to have a size in the format string if it's a problem to put the size of the buffer in there. > > Other than these, this patch looks good to me, thanks for the effort. > Thanks.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org> To: Baoquan He <bhe@redhat.com> Cc: Andrew Morton <akpm@linux-foundation.org>, linux-kernel@vger.kernel.org, Jiri Olsa <jolsa@kernel.org>, Alexei Starovoitov <ast@kernel.org>, Jessica Yu <jeyu@kernel.org>, Evan Green <evgreen@chromium.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Dave Young <dyoung@redhat.com>, Vivek Goyal <vgoyal@redhat.com>, kexec@lists.infradead.org Subject: Re: [PATCH v5 13/13] kdump: Use vmlinux_build_id to simplify Date: Thu, 29 Apr 2021 01:14:43 +0200 [thread overview] Message-ID: <CAE-0n517ZDD8ySTqT2GvKv-KNf1DFP2qmaqt3Pc=-AEndLTevg@mail.gmail.com> (raw) In-Reply-To: <20210428101355.GB8374@localhost.localdomain> Quoting Baoquan He (2021-04-28 03:13:55) > On 04/20/21 at 02:50pm, Stephen Boyd wrote: > > We can use the vmlinux_build_id array here now instead of open coding > > it. This mostly consolidates code. > > > > Cc: Jiri Olsa <jolsa@kernel.org> > > Cc: Alexei Starovoitov <ast@kernel.org> > > Cc: Jessica Yu <jeyu@kernel.org> > > Cc: Evan Green <evgreen@chromium.org> > > Cc: Hsin-Yi Wang <hsinyi@chromium.org> > > Cc: Dave Young <dyoung@redhat.com> > > Cc: Baoquan He <bhe@redhat.com> > > Cc: Vivek Goyal <vgoyal@redhat.com> > > Cc: <kexec@lists.infradead.org> > > Signed-off-by: Stephen Boyd <swboyd@chromium.org> > > --- > > include/linux/crash_core.h | 12 ++++----- > > kernel/crash_core.c | 50 ++------------------------------------ > > 2 files changed, 8 insertions(+), 54 deletions(-) > > > > diff --git a/include/linux/crash_core.h b/include/linux/crash_core.h > > index 206bde8308b2..de62a722431e 100644 > > --- a/include/linux/crash_core.h > > +++ b/include/linux/crash_core.h > > @@ -38,8 +38,12 @@ phys_addr_t paddr_vmcoreinfo_note(void); > > > > #define VMCOREINFO_OSRELEASE(value) \ > > vmcoreinfo_append_str("OSRELEASE=%s\n", value) > > -#define VMCOREINFO_BUILD_ID(value) \ > > - vmcoreinfo_append_str("BUILD-ID=%s\n", value) > > +#define VMCOREINFO_BUILD_ID() \ > > + ({ \ > > + static_assert(sizeof(vmlinux_build_id) == 20); \ > > + vmcoreinfo_append_str("BUILD-ID=%20phN\n", vmlinux_build_id); \ > > Since there has been static_assert at above, can we remove the magic > number '20'? > > And I checked format_decode(), didn't find which type corresponds to > 'N', could you tell? It is documented in Documentation/core-api/printk-formats.rst (see "Raw buffer as a hex string") where the '20' replaces the '*' to specify a fixed size buffer to format. We could pass the 20 as an argument instead of encoding it in the format, but then it would still be there twice. We could use a #define but then it would have to be passed as an argument. I don't know of a good way to enforce in printk that the buffer is the size that matches the format size. Maybe it shouldn't be an option to have a size in the format string if it's a problem to put the size of the buffer in there. > > Other than these, this patch looks good to me, thanks for the effort. > Thanks. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-04-28 23:14 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-04-20 21:49 [PATCH v5 00/13] Add build ID to stacktraces Stephen Boyd 2021-04-20 21:49 ` Stephen Boyd 2021-04-20 21:49 ` Stephen Boyd 2021-04-20 21:49 ` [PATCH v5 01/13] buildid: Only consider GNU notes for build ID parsing Stephen Boyd 2021-04-20 21:49 ` [PATCH v5 02/13] buildid: Add API to parse build ID out of buffer Stephen Boyd 2021-04-20 21:49 ` [PATCH v5 03/13] buildid: Stash away kernels build ID on init Stephen Boyd 2021-04-20 21:49 ` Stephen Boyd 2021-04-28 10:02 ` Baoquan He 2021-04-28 10:02 ` Baoquan He 2021-04-20 21:49 ` [PATCH v5 04/13] dump_stack: Add vmlinux build ID to stack traces Stephen Boyd 2021-04-26 11:04 ` Petr Mladek 2021-04-26 23:40 ` Stephen Boyd 2021-04-20 21:49 ` [PATCH v5 05/13] module: Add printk formats to add module build ID to stacktraces Stephen Boyd 2021-04-21 11:49 ` Andy Shevchenko 2021-04-22 23:46 ` Stephen Boyd 2021-04-23 13:24 ` Andy Shevchenko 2021-04-23 13:45 ` Rasmus Villemoes 2021-04-23 14:08 ` Andy Shevchenko 2021-04-26 23:42 ` Stephen Boyd 2021-04-20 21:49 ` [PATCH v5 06/13] arm64: stacktrace: Use %pSb for backtrace printing Stephen Boyd 2021-04-20 21:49 ` Stephen Boyd 2021-04-21 9:58 ` Catalin Marinas 2021-04-21 9:58 ` Catalin Marinas 2021-04-20 21:49 ` [PATCH v5 07/13] x86/dumpstack: Use %pSb/%pBb " Stephen Boyd 2021-04-20 21:49 ` [PATCH v5 08/13] scripts/decode_stacktrace.sh: Support debuginfod Stephen Boyd 2021-04-20 21:49 ` [PATCH v5 09/13] scripts/decode_stacktrace.sh: Silence stderr messages from addr2line/nm Stephen Boyd 2021-04-20 21:50 ` [PATCH v5 10/13] scripts/decode_stacktrace.sh: Indicate 'auto' can be used for base path Stephen Boyd 2021-04-20 21:50 ` [PATCH v5 11/13] buildid: Mark some arguments const Stephen Boyd 2021-04-20 21:50 ` [PATCH v5 12/13] buildid: Fix kernel-doc notation Stephen Boyd 2021-04-20 21:50 ` [PATCH v5 13/13] kdump: Use vmlinux_build_id to simplify Stephen Boyd 2021-04-20 21:50 ` Stephen Boyd 2021-04-28 10:13 ` Baoquan He 2021-04-28 10:13 ` Baoquan He 2021-04-28 23:14 ` Stephen Boyd [this message] 2021-04-28 23:14 ` Stephen Boyd 2021-05-07 3:54 ` Baoquan He 2021-05-07 3:54 ` Baoquan He 2021-05-07 4:04 ` Baoquan He 2021-05-07 4:04 ` Baoquan He
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAE-0n517ZDD8ySTqT2GvKv-KNf1DFP2qmaqt3Pc=-AEndLTevg@mail.gmail.com' \ --to=swboyd@chromium.org \ --cc=akpm@linux-foundation.org \ --cc=ast@kernel.org \ --cc=bhe@redhat.com \ --cc=dyoung@redhat.com \ --cc=evgreen@chromium.org \ --cc=hsinyi@chromium.org \ --cc=jeyu@kernel.org \ --cc=jolsa@kernel.org \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=vgoyal@redhat.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.