From: Stephen Boyd <swboyd@chromium.org>
To: Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: quic_kalyant <quic_kalyant@quicinc.com>,
"dianders@chromium.org" <dianders@chromium.org>,
quic_vproddut <quic_vproddut@quicinc.com>,
"airlied@linux.ie" <airlied@linux.ie>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
"steev@kali.org" <steev@kali.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
"seanpaul@chromium.org" <seanpaul@chromium.org>,
"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
Aravind Venkateswaran <quic_aravindh@quicinc.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"sean@poorly.run" <sean@poorly.run>
Subject: RE: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus
Date: Mon, 25 Apr 2022 13:26:09 -0700 [thread overview]
Message-ID: <CAE-0n51oUFkYuZ5qd2CbnaUGo2xcAjU+F0M+Kptk8b=7curH0Q@mail.gmail.com> (raw)
In-Reply-To: <MW4PR02MB7186108BA0131C8BFC46A219E1F89@MW4PR02MB7186.namprd02.prod.outlook.com>
Quoting Sankeerth Billakanti (QUIC) (2022-04-25 02:39:43)
> Hi Stephen,
>
> >Quoting Sankeerth Billakanti (2022-04-22 02:11:03)
> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> >> b/drivers/gpu/drm/msm/dp/dp_display.c
> >> index d7a19d6..055681a 100644
> >> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> >
> >Some nitpicks
> >
> >Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> >
> >> @@ -1508,7 +1509,8 @@ void msm_dp_irq_postinstall(struct msm_dp
> >> *dp_display)
> >>
> >> dp_hpd_event_setup(dp);
> >>
> >> - dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100);
> >> + if (!dp_display->is_edp)
> >> + dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100);
> >
> >Did it turn out that in fact DP isn't ready still to setup even after delaying the
> >irq?
> >
>
> The host_init, config_hpd, phy_init and enable_irq are happening in modeset_init already for eDP.
> So, I am not scheduling the EV_HPD_INIT_SETUP event for eDP. I am not modifying the delay for DP.
Cool. That didn't answer my question though. Why does DP still need the
delay? I thought recent changes made it unnecessary.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: "robdclark@gmail.com" <robdclark@gmail.com>,
"seanpaul@chromium.org" <seanpaul@chromium.org>,
quic_kalyant <quic_kalyant@quicinc.com>,
Abhinav Kumar <quic_abhinavk@quicinc.com>,
"dianders@chromium.org" <dianders@chromium.org>,
Kuogee Hsieh <quic_khsieh@quicinc.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"sean@poorly.run" <sean@poorly.run>,
"airlied@linux.ie" <airlied@linux.ie>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
quic_vproddut <quic_vproddut@quicinc.com>,
Aravind Venkateswaran <quic_aravindh@quicinc.com>,
"steev@kali.org" <steev@kali.org>
Subject: RE: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus
Date: Mon, 25 Apr 2022 13:26:09 -0700 [thread overview]
Message-ID: <CAE-0n51oUFkYuZ5qd2CbnaUGo2xcAjU+F0M+Kptk8b=7curH0Q@mail.gmail.com> (raw)
In-Reply-To: <MW4PR02MB7186108BA0131C8BFC46A219E1F89@MW4PR02MB7186.namprd02.prod.outlook.com>
Quoting Sankeerth Billakanti (QUIC) (2022-04-25 02:39:43)
> Hi Stephen,
>
> >Quoting Sankeerth Billakanti (2022-04-22 02:11:03)
> >> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
> >> b/drivers/gpu/drm/msm/dp/dp_display.c
> >> index d7a19d6..055681a 100644
> >> --- a/drivers/gpu/drm/msm/dp/dp_display.c
> >> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
> >
> >Some nitpicks
> >
> >Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> >
> >> @@ -1508,7 +1509,8 @@ void msm_dp_irq_postinstall(struct msm_dp
> >> *dp_display)
> >>
> >> dp_hpd_event_setup(dp);
> >>
> >> - dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100);
> >> + if (!dp_display->is_edp)
> >> + dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100);
> >
> >Did it turn out that in fact DP isn't ready still to setup even after delaying the
> >irq?
> >
>
> The host_init, config_hpd, phy_init and enable_irq are happening in modeset_init already for eDP.
> So, I am not scheduling the EV_HPD_INIT_SETUP event for eDP. I am not modifying the delay for DP.
Cool. That didn't answer my question though. Why does DP still need the
delay? I thought recent changes made it unnecessary.
next prev parent reply other threads:[~2022-04-25 20:26 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 9:11 [PATCH v9 0/4] Add support for the eDP panel over aux_bus Sankeerth Billakanti
2022-04-22 9:11 ` Sankeerth Billakanti
2022-04-22 9:11 ` [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus Sankeerth Billakanti
2022-04-22 9:11 ` Sankeerth Billakanti
2022-04-22 14:03 ` Doug Anderson
2022-04-22 14:03 ` Doug Anderson
2022-04-23 0:13 ` Stephen Boyd
2022-04-23 0:13 ` Stephen Boyd
2022-04-25 9:39 ` Sankeerth Billakanti (QUIC)
2022-04-25 9:39 ` Sankeerth Billakanti (QUIC)
2022-04-25 20:26 ` Stephen Boyd [this message]
2022-04-25 20:26 ` Stephen Boyd
2022-04-25 21:12 ` Dmitry Baryshkov
2022-04-25 21:12 ` Dmitry Baryshkov
2022-04-26 1:58 ` Sankeerth Billakanti (QUIC)
2022-04-26 1:58 ` Sankeerth Billakanti (QUIC)
2022-04-22 9:11 ` [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP Sankeerth Billakanti
2022-04-22 9:11 ` Sankeerth Billakanti
2022-04-22 14:03 ` Doug Anderson
2022-04-22 14:03 ` Doug Anderson
2022-04-22 15:55 ` Doug Anderson
2022-04-22 15:55 ` Doug Anderson
2022-04-22 16:04 ` Abhinav Kumar
2022-04-22 16:04 ` Abhinav Kumar
2022-04-22 16:10 ` Doug Anderson
2022-04-22 16:10 ` Doug Anderson
2022-04-22 17:35 ` Abhinav Kumar
2022-04-22 17:35 ` Abhinav Kumar
2022-04-23 0:29 ` Stephen Boyd
2022-04-23 0:29 ` Stephen Boyd
2022-04-25 2:55 ` Sankeerth Billakanti (QUIC)
2022-04-25 2:55 ` Sankeerth Billakanti (QUIC)
2022-04-25 20:27 ` Stephen Boyd
2022-04-25 20:27 ` Stephen Boyd
2022-04-26 3:45 ` Sankeerth Billakanti (QUIC)
2022-04-26 3:45 ` Sankeerth Billakanti (QUIC)
2022-04-22 9:11 ` [PATCH v9 3/4] drm/msm/dp: wait for hpd high before aux transaction Sankeerth Billakanti
2022-04-22 9:11 ` Sankeerth Billakanti
2022-04-23 1:38 ` Stephen Boyd
2022-04-23 1:38 ` Stephen Boyd
2022-04-22 9:11 ` [PATCH v9 4/4] drm/msm/dp: Support the eDP modes given by panel Sankeerth Billakanti
2022-04-22 9:11 ` Sankeerth Billakanti
2022-04-23 1:39 ` Stephen Boyd
2022-04-23 1:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n51oUFkYuZ5qd2CbnaUGo2xcAjU+F0M+Kptk8b=7curH0Q@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_aravindh@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_sbillaka@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
--cc=steev@kali.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.