From: Slavomir Kaslev <kaslevs@vmware.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>,
Yordan Karadzhov <ykaradzhov@vmware.com>,
"linux-trace-devel@vger.kernel.org"
<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 1/4] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark
Date: Tue, 9 Apr 2019 14:59:54 +0000 [thread overview]
Message-ID: <CAE0o1NtOBbVGjHfYyqOhrCrmywSNjYWOprDU66uMTPx4hX4UGA@mail.gmail.com> (raw)
In-Reply-To: <20190409092349.3e7cb6e3@gandalf.local.home>
On Tue, Apr 9, 2019 at 4:24 PM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 9 Apr 2019 15:23:56 +0300
> "Yordan Karadzhov (VMware)" <y.karadz@gmail.com> wrote:
>
> > I can make the GUI to check if _KS_CACHE_DIR is defined and if its value
> > (path) belongs to the user who runs the GUI. If this is not the case,
> > The GUI will use the default location (~/cache/kernelshark).
>
> Can't we just make it so that it always does this path?
Dropping KS_CACHE_DIR as build time constant in CMake sounds great. I
think that having an environment variable override for it is still
useful.
We also have the same problem with KS_DIR and TRACECMD_BIN_DIR though.
They both point inside the trace-cmd source directory for the user who
built kernelshark atm.
Cheers,
-- Slavi
next prev parent reply other threads:[~2019-04-09 14:59 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 14:55 [PATCH 0/4] Various modifications and fixes toward KS 1.0 Yordan Karadzhov
2019-04-04 14:56 ` [PATCH 1/4] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark Yordan Karadzhov
2019-04-08 15:01 ` Slavomir Kaslev
2019-04-08 15:13 ` Steven Rostedt
2019-04-09 12:23 ` Yordan Karadzhov (VMware)
2019-04-09 13:11 ` Slavomir Kaslev
2019-04-09 13:23 ` Steven Rostedt
2019-04-09 13:33 ` Yordan Karadzhov
2019-04-09 14:59 ` Slavomir Kaslev [this message]
2019-04-09 15:11 ` Steven Rostedt
2019-04-09 15:44 ` Slavomir Kaslev
2019-04-09 17:02 ` Steven Rostedt
2019-04-15 11:05 ` Yordan Karadzhov (VMware)
2019-04-15 13:11 ` Slavomir Kaslev
2019-04-15 13:58 ` Yordan Karadzhov (VMware)
2019-04-15 11:16 ` Yordan Karadzhov (VMware)
2019-04-15 20:04 ` Steven Rostedt
2019-04-04 14:56 ` [PATCH 2/4] kernel-shark: Set the configuration cache directory via env. variable Yordan Karadzhov
2019-04-04 14:56 ` [PATCH 3/4] kernel-shark: Load Last Session from command line Yordan Karadzhov
2019-04-04 14:56 ` [PATCH 4/4] kernel-shark: Configuration file directory to be created by the executable Yordan Karadzhov
2019-04-08 15:03 ` Slavomir Kaslev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE0o1NtOBbVGjHfYyqOhrCrmywSNjYWOprDU66uMTPx4hX4UGA@mail.gmail.com \
--to=kaslevs@vmware.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=y.karadz@gmail.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.