All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
To: Slavomir Kaslev <kaslevs@vmware.com>,
	Steven Rostedt <rostedt@goodmis.org>
Cc: Yordan Karadzhov <ykaradzhov@vmware.com>,
	"linux-trace-devel@vger.kernel.org" 
	<linux-trace-devel@vger.kernel.org>
Subject: Re: [PATCH 1/4] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark
Date: Mon, 15 Apr 2019 14:05:54 +0300	[thread overview]
Message-ID: <edebede3-e508-022e-5d71-13226cd2df58@gmail.com> (raw)
In-Reply-To: <CAE0o1Nv_JgHpTHgwpLhw7dkyxqW_u-rRUBMojgzPENCwVUDbmg@mail.gmail.com>



On 9.04.19 г. 18:44 ч., Slavomir Kaslev wrote:
> The problem is the way they are defined atm:
> 
> # First search in the user provided paths.
> find_path(TRACECMD_BIN_DIR      NAMES  trace-cmd
>                                  PATHS  $ENV{TRACE_CMD}/tracecmd/
>                                         ${CMAKE_SOURCE_DIR}/../tracecmd/
>                                  NO_DEFAULT_PATH)
> 
> This will never evaluate to /usr/bin which is what it should be for
> distro builds.

I think there is a bit of confusion here. The code above will never 
search in /usr/bin. This statement is correct.

However if this search fails we will perform another search that will 
this time search in /usr/bin. Look few lines below in  FindTraceCmd.cmake.

The reason for this is to avoid confusion in the case when the user has 
the distro package installed, but in the same time is trying to build 
KernelShark from source. We want in this case the GUI to link with the 
version of the trace-cmd library that is being build (not the one from 
the package).

Thanks!
Yordan



  parent reply	other threads:[~2019-04-15 11:06 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-04 14:55 [PATCH 0/4] Various modifications and fixes toward KS 1.0 Yordan Karadzhov
2019-04-04 14:56 ` [PATCH 1/4] kernel-shark: Configuration information in ${HOME}/.cache/kernelshark Yordan Karadzhov
2019-04-08 15:01   ` Slavomir Kaslev
2019-04-08 15:13     ` Steven Rostedt
2019-04-09 12:23       ` Yordan Karadzhov (VMware)
2019-04-09 13:11         ` Slavomir Kaslev
2019-04-09 13:23         ` Steven Rostedt
2019-04-09 13:33           ` Yordan Karadzhov
2019-04-09 14:59           ` Slavomir Kaslev
2019-04-09 15:11             ` Steven Rostedt
2019-04-09 15:44               ` Slavomir Kaslev
2019-04-09 17:02                 ` Steven Rostedt
2019-04-15 11:05                 ` Yordan Karadzhov (VMware) [this message]
2019-04-15 13:11                   ` Slavomir Kaslev
2019-04-15 13:58                     ` Yordan Karadzhov (VMware)
2019-04-15 11:16                 ` Yordan Karadzhov (VMware)
2019-04-15 20:04                   ` Steven Rostedt
2019-04-04 14:56 ` [PATCH 2/4] kernel-shark: Set the configuration cache directory via env. variable Yordan Karadzhov
2019-04-04 14:56 ` [PATCH 3/4] kernel-shark: Load Last Session from command line Yordan Karadzhov
2019-04-04 14:56 ` [PATCH 4/4] kernel-shark: Configuration file directory to be created by the executable Yordan Karadzhov
2019-04-08 15:03   ` Slavomir Kaslev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=edebede3-e508-022e-5d71-13226cd2df58@gmail.com \
    --to=y.karadz@gmail.com \
    --cc=kaslevs@vmware.com \
    --cc=linux-trace-devel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=ykaradzhov@vmware.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.